#include <QApplication>
#include <QClipboard>
+#include <QDebug>
#include <QFont>
#include <QKeyEvent>
#include <QScrollBar>
}
}
-void QHexView::setMode(Mode m)
+void QHexView::set_mode(Mode m)
{
mode_ = m;
// so we don't update the viewport here
}
-void QHexView::setData(const DecodeBinaryClass* data)
+void QHexView::set_data(const DecodeBinaryClass* data)
{
data_ = data;
- data_size_ = 0;
- for (const DecodeBinaryDataChunk& chunk : data_->chunks)
- data_size_ += chunk.data.size();
+ size_t size = 0;
+ if (data) {
+ size_t chunks = data_->chunks.size();
+ for (size_t i = 0; i < chunks; i++)
+ size += data_->chunks[i].data.size();
+ }
+ data_size_ = size;
viewport()->update();
}
+unsigned int QHexView::get_bytes_per_line() const
+{
+ return BYTES_PER_LINE;
+}
+
void QHexView::clear()
{
verticalScrollBar()->setValue(0);
viewport()->update();
}
+QSizePolicy QHexView::sizePolicy() const
+{
+ return QSizePolicy(QSizePolicy::Fixed, QSizePolicy::Expanding);
+}
+
+pair<size_t, size_t> QHexView::get_selection() const
+{
+ size_t start = selectBegin_ / 2;
+ size_t end = selectEnd_ / 2;
+
+ if (start == end) {
+ // Nothing is currently selected
+ start = 0;
+ end = data_size_;
+ } if (end < data_size_)
+ end++;
+
+ return std::make_pair(start, end);
+}
+
+size_t QHexView::create_hex_line(size_t start, size_t end, QString* dest,
+ bool with_offset, bool with_ascii)
+{
+ dest->clear();
+
+ // Determine start address for the row
+ uint64_t row = start / BYTES_PER_LINE;
+ uint64_t offset = row * BYTES_PER_LINE;
+ end = std::min((uint64_t)end, offset + BYTES_PER_LINE);
+
+ if (with_offset)
+ dest->append(QString("%1 ").arg(row * BYTES_PER_LINE, 10, 16, QChar('0')).toUpper());
+
+ initialize_byte_iterator(offset);
+ for (size_t i = offset; i < offset + BYTES_PER_LINE; i++) {
+ uint8_t value = 0;
+
+ if (i < end)
+ value = get_next_byte();
+
+ if ((i < start) || (i >= end))
+ dest->append(" ");
+ else
+ dest->append(QString("%1 ").arg(value, 2, 16, QChar('0')).toUpper());
+ }
+
+ if (with_ascii) {
+ initialize_byte_iterator(offset);
+ for (size_t i = offset; i < end; i++) {
+ uint8_t value = get_next_byte();
+
+ if ((value < 0x20) || (value > 0x7E))
+ value = '.';
+
+ if (i < start)
+ dest->append(' ');
+ else
+ dest->append((char)value);
+ }
+ }
+
+ return end;
+}
+
void QHexView::initialize_byte_iterator(size_t offset)
{
current_chunk_id_ = 0;
current_chunk_offset_ = 0;
+ current_offset_ = offset;
+
+ size_t chunks = data_->chunks.size();
+ for (size_t i = 0; i < chunks; i++) {
+ size_t size = data_->chunks[i].data.size();
- for (const DecodeBinaryDataChunk& chunk : data_->chunks)
- if (offset >= chunk.data.size()) {
+ if (offset >= size) {
current_chunk_id_++;
- offset -= chunk.data.size();
+ offset -= size;
} else {
current_chunk_offset_ = offset;
break;
}
+ }
- current_chunk_ = &(data_->chunks[current_chunk_id_]);
+ if (current_chunk_id_ < data_->chunks.size())
+ current_chunk_ = data_->chunks[current_chunk_id_];
}
uint8_t QHexView::get_next_byte(bool* is_next_chunk)
if (is_next_chunk != nullptr)
*is_next_chunk = (current_chunk_offset_ == 0);
- uint8_t v = current_chunk_->data[current_chunk_offset_];
+ uint8_t v = 0;
+ if (current_chunk_offset_ < current_chunk_.data.size())
+ v = current_chunk_.data[current_chunk_offset_];
+ current_offset_++;
current_chunk_offset_++;
- if (current_chunk_offset_ == current_chunk_->data.size()) {
+
+ if (current_offset_ > data_size_) {
+ qWarning() << "QHexView::get_next_byte() overran binary data boundary:" <<
+ current_offset_ << "of" << data_size_ << "bytes";
+ return 0xEE;
+ }
+
+ if ((current_chunk_offset_ == current_chunk_.data.size()) && (current_offset_ < data_size_)) {
current_chunk_id_++;
current_chunk_offset_ = 0;
- current_chunk_ = &(data_->chunks[current_chunk_id_]);
+ current_chunk_ = data_->chunks[current_chunk_id_];
}
return v;
QSize QHexView::getFullSize() const
{
- size_t width = posAscii_ + (BYTES_PER_LINE * charWidth_) +
- GAP_ASCII_SLIDER + verticalScrollBar()->width();
+ size_t width = posAscii_ + (BYTES_PER_LINE * charWidth_);
+
+ if (verticalScrollBar()->isEnabled())
+ width += GAP_ASCII_SLIDER + verticalScrollBar()->width();
- if (!data_)
+ if (!data_ || (data_size_ == 0))
return QSize(width, 0);
size_t height = data_size_ / BYTES_PER_LINE;
QSize widgetSize = getFullSize();
setMinimumWidth(widgetSize.width());
setMaximumWidth(widgetSize.width());
- QSize areaSize = viewport()->size();
+ QSize areaSize = viewport()->size() - QSize(0, charHeight_);
- verticalScrollBar()->setPageStep(areaSize.height() / charHeight_);
- verticalScrollBar()->setRange(0, (widgetSize.height() - areaSize.height()) / charHeight_ + 1);
+ // Only show scrollbar if the content goes beyond the visible area
+ if (widgetSize.height() > areaSize.height()) {
+ verticalScrollBar()->setEnabled(true);
+ verticalScrollBar()->setPageStep(areaSize.height() / charHeight_);
+ verticalScrollBar()->setRange(0, ((widgetSize.height() - areaSize.height())) / charHeight_ + 1);
+ } else
+ verticalScrollBar()->setEnabled(false);
// Fill widget background
painter.fillRect(event->rect(), palette().color(QPalette::Base));
// Determine first/last line indices
size_t firstLineIdx = verticalScrollBar()->value();
- size_t lastLineIdx = firstLineIdx + areaSize.height() / charHeight_;
+ size_t lastLineIdx = firstLineIdx + (areaSize.height() / charHeight_);
if (lastLineIdx > (data_size_ / BYTES_PER_LINE)) {
lastLineIdx = data_size_ / BYTES_PER_LINE;
if (data_size_ % BYTES_PER_LINE)
// Paint address area
painter.setPen(palette().color(QPalette::ButtonText));
- int yStart = charHeight_;
+ int yStart = 2 * charHeight_;
for (size_t lineIdx = firstLineIdx, y = yStart; lineIdx < lastLineIdx; lineIdx++) {
QString address = QString("%1").arg(lineIdx * 16, 10, 16, QChar('0')).toUpper();
y += charHeight_;
}
+ // Paint top row with hex offsets
+ painter.setPen(palette().color(QPalette::ButtonText));
+ for (int offset = 0; offset <= 0xF; offset++)
+ painter.drawText(posHex_ + (1 + offset * 3) * charWidth_,
+ charHeight_, QString::number(offset, 16).toUpper());
+
// Paint hex values
QBrush regular = palette().buttonText();
QBrush selected = palette().highlight();
unsigned int chunk_color = 0;
initialize_byte_iterator(firstLineIdx * BYTES_PER_LINE);
- yStart = charHeight_;
+ yStart = 2 * charHeight_;
for (size_t lineIdx = firstLineIdx, y = yStart; lineIdx < lastLineIdx; lineIdx++) {
int x = posHex_;
- for (size_t i = 0; i < BYTES_PER_LINE && ((lineIdx - firstLineIdx) * BYTES_PER_LINE + i) < data_size_; i++) {
+ for (size_t i = 0; (i < BYTES_PER_LINE) && (current_offset_ < data_size_); i++) {
size_t pos = (lineIdx * BYTES_PER_LINE + i) * 2;
// Fetch byte
val = QString::number((byte_value & 0xF), 16).toUpper();
painter.drawText(x + charWidth_, y, val);
+ if ((pos >= selectBegin_) && (pos < selectEnd_ - 1) && (i < BYTES_PER_LINE - 1))
+ painter.drawText(x + 2 * charWidth_, y, QString(' '));
+
x += 3 * charWidth_;
}
// Paint ASCII characters
initialize_byte_iterator(firstLineIdx * BYTES_PER_LINE);
- yStart = charHeight_;
+ yStart = 2 * charHeight_;
for (size_t lineIdx = firstLineIdx, y = yStart; lineIdx < lastLineIdx; lineIdx++) {
int x = posAscii_;
- for (size_t i = 0; ((lineIdx - firstLineIdx) * BYTES_PER_LINE + i) < data_size_ && (i < BYTES_PER_LINE); i++) {
+ for (size_t i = 0; (i < BYTES_PER_LINE) && (current_offset_ < data_size_); i++) {
// Fetch byte
uint8_t ch = get_next_byte();
int y = cursorPos_ / (2 * BYTES_PER_LINE);
y -= firstLineIdx;
int cursorX = (((x / 2) * 3) + (x % 2)) * charWidth_ + posHex_;
- int cursorY = y * charHeight_ + 4;
+ int cursorY = charHeight_ + y * charHeight_ + 4;
painter.fillRect(cursorX, cursorY, 2, charHeight_, palette().color(QPalette::WindowText));
}
}
x = (2 * x + 1) / 3;
size_t firstLineIdx = verticalScrollBar()->value();
- size_t y = (position.y() / charHeight_) * 2 * BYTES_PER_LINE;
+ size_t y = ((position.y() / charHeight_) - 1) * 2 * BYTES_PER_LINE;
pos = x + y + firstLineIdx * BYTES_PER_LINE * 2;
}