Bug 964 - Windows: NSIS: register .sr file extension
Summary: Windows: NSIS: register .sr file extension
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Other (show other bugs)
Version: unreleased development snapshot
Hardware: All Windows
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-31 21:28 CEST by Uwe Hermann
Modified: 2017-06-03 23:22 CEST (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2017-05-31 21:28:38 CEST 
The PulseView NSIS installer should allow registering the .sr extension with PulseView.

Ideally, this could be a checkbox (default: on), which is rather common with other installers, to give the user the choice of *not* registering the file format if so desired.
Comment 1 Uwe Hermann 2017-06-03 23:22:38 CEST 
Fixed in 63ebd7fe196b3418f1a06e73642aa964cacbed93, thanks!

Works fine on Windows XP, apart from the .sr files not having the sigrok logo (that seems to be not currently be supported in FileAssociation.nsh, but I guess it could be added).

It's unclear whether it works on Windows 10 (maybe 7/8), needs more testing.