Bug 74 - Number of samples selector is not limited to the capability of the device
Summary: Number of samples selector is not limited to the capability of the device
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Acquisition (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: PulseView 0.2.0
Assignee: Joel Holdsworth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-09 12:56 CET by Joel Holdsworth
Modified: 2014-01-20 18:22 CET (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Holdsworth 2013-03-09 12:56:03 CET 
At the moment the user might select 1M samples which is impossible with an OLS. The list should be filtered.
Comment 1 Joel Holdsworth 2013-03-21 23:05:13 CET 
What is needed is some kind of API to expose the capability of the device, some kind of hardware capabilities API, or HWCAP - if you will.
Comment 2 Joel Holdsworth 2013-04-22 23:18:49 CEST 
We should be able to just sr_config_list on SR_CONF_LIMIT_SAMPLES, but there is little (or no?) support for this in the drivers.
Comment 3 Joseph Lane 2013-11-30 01:35:46 CET 
In addition to this problem the maximum number of samples an OLS user can capture with 8 probes is limited to 10k because of the drop-down menu. The next option is 25k which is 1,000 more samples than the OLS supports. I edited my local install to resolve this issue but it would be much more efficient to allow users to enter their own value; the samplerate option allows this already (though it is set in two different place, both of which must match to be successful).
Comment 4 Bert Vermeulen 2014-01-09 16:57:08 CET 
libsigrok now has a facility for this: SR_CONF_MAX_UNCOMPRESSED_SAMPLES.

Check sigrok-cli commits c7a5cb124 and be7813219 for implementation.
Comment 5 Bert Vermeulen 2014-01-20 18:22:45 CET 
Fixed in 1d04852f3d78a49360da3e8a5289793fbeae2e0f