Bug 67 - "$ DESTDIR=/path/to/destination make install" does not work as expected (install dir hardcoded)
Summary: "$ DESTDIR=/path/to/destination make install" does not work as expected (inst...
Status: RESOLVED FIXED
Alias: None
Product: sigrok-firmware-fx2lafw
Classification: Unclassified
Component: Build system (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: mrnuke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 18:04 CET by mrnuke
Modified: 2023-04-06 06:56 CEST (History)
2 users (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mrnuke 2013-02-22 18:04:09 CET
The installation directory is hardcoded to:
/usr/local/share/sigrok-firmware

That's bad since a huge number of distros use /usr/share instead of /usr/local/share.

When building rpms (at least for Fedora), we rely on DESTDIR to work in order to be able to place the install files in a build root before compressing them into an rpm.
"$ configure --prefix=$(pwd)/install" will not work when building an rpm.

Here's what happens:

[mrnuke@nukelap build]$ DESTDIR=$(pwd)/install make install
Making install in include
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
Making install in fx2lib
Making install in include
make[3]: Nothing to be done for `install-exec-am'.
make[3]: Nothing to be done for `install-data-am'.
Making install in lib
Making install in interrupts
make[4]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `install-data-am'.
make[4]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `install-data-am'.
make[3]: Nothing to be done for `install-exec-am'.
make[3]: Nothing to be done for `install-data-am'.
Making install in hw
Making install in braintechnology-usb-lps
make[3]: Nothing to be done for `fx2lafw'.
  GEN      fx2lafw-braintechnology-usb-lps.ihx
  GEN      fx2lafw-braintechnology-usb-lps.fw
make[3]: Nothing to be done for `install-exec-am'.
make[4]: Nothing to be done for `fx2lafw'.
  GEN      fx2lafw-braintechnology-usb-lps.ihx
  GEN      fx2lafw-braintechnology-usb-lps.fw
/usr/bin/mkdir: cannot create directory ‘/usr/local/share/sigrok-firmware’: Permission denied
make[3]: *** [install-data-local] Error 1
make[2]: *** [install-am] Error 2
make[1]: *** [install-recursive] Error 1
make: *** [install-recursive] Error 1
Comment 2 Uwe Hermann 2013-03-03 20:04:12 CET
Thanks, merged as 8ca25313c231a0284b214ac31f8c1179286a8cc6, with a small fix in 39ac5a27ab438ec17ff0198748141f50f08b72d8.
Comment 3 chris 2023-04-06 06:55:47 CEST
When shopping for a tablet, the first factor to consider is the size. The size of the tablet will determine how easy it is to carry and use. Larger tablets are great for watching movies or playing video games, but can be bulky and difficult to take with you on the go. Smaller tablets are more portable and can be used for more tasks, including taking notes or reading. <a href="https://workusingtablets.com/best-tablet-under-300/">https://workusingtablets.com/best-tablet-under-300/</a>
Comment 4 chris 2023-04-06 06:56:23 CEST
When shopping for a tablet, the first factor to consider is the size. The size of the tablet will determine how easy it is to carry and use. Larger tablets are great for watching movies or playing video games, but can be bulky and difficult to take with you on the go. Smaller tablets are more portable and can be used for more tasks, including taking notes or reading. https://workusingtablets.com/best-tablet-under-300/