Bug 278 - zoom-fit should clamp to min and max h-scale
Summary: zoom-fit should clamp to min and max h-scale
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Data display (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: PulseView 0.2.0
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-17 14:41 CET by Joel Holdsworth
Modified: 2014-04-22 19:25 CEST (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel Holdsworth 2014-01-17 14:41:33 CET 
Some sessions have a missing, or broken samplerate value, causing the zoom-fit command to compute crazy h-scale values, resulting in asserts.

The h-scale should be clamped to the zoom limits.

zoom-fit should also do something sensible with the samplerate if it's undefined.
Comment 1 Joel Holdsworth 2014-01-18 22:52:23 CET 
Fixed in a472a88
Comment 2 Uwe Hermann 2014-04-22 19:25:00 CEST 
This was also (further?) fixed in 7831112753a3a419e328d7d6b0d474435a09d6ed.