Bug 1682 - Build is broken with glib 2.68
Summary: Build is broken with glib 2.68
Status: CONFIRMED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Build system (show other bugs)
Version: unreleased development snapshot
Hardware: All Linux
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-11 18:41 CEST by bbbsnowball+sigrok
Modified: 2021-05-11 18:41 CEST (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bbbsnowball+sigrok 2021-05-11 18:41:14 CEST 
Two files are including libsigrokdecode.h in `extern "C"`, which is unnecessary and it breaks the use of <type_traits> in gatomic.h. Other files include it without `extern "C"`.


This is the first error message:

In file included from /usr/include/glib-2.0/glib/gatomic.h:31,
from /usr/include/glib-2.0/glib/gthread.h:32,
from /usr/include/glib-2.0/glib/gasyncqueue.h:32,
from /usr/include/glib-2.0/glib.h:32,
from /usr/include/libsigrokdecode/libsigrokdecode.h:25,
from /home/abuild/rpmbuild/BUILD/pulseview-0.4.2/pv/data/decode/annotation.cpp:21:
/usr/include/c++/10/type_traits:2308:3: error: template with C linkage
2308 | template<typename _CTp, typename _Rp>


Someone has already created a pull request for this:

https://github.com/sigrokproject/pulseview/pull/39