Bug 1576 - rigol-ds not working for Agillent / keysight DSO1072B
Summary: rigol-ds not working for Agillent / keysight DSO1072B
Status: RESOLVED FIXED
Alias: None
Product: sigrok-cli
Classification: Unclassified
Component: Protocol decoding (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
: 1397 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-12 22:31 CEST by Thales Maia
Modified: 2020-10-07 20:57 CEST (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thales Maia 2020-07-12 22:31:50 CEST 
I'm trying to connect to a keysight DSO1072B osciloscope. However, the scope return an 'X' character when only float numbers are expected.


sr: [00:07.315886] scpi: Got response: '0', length 1.
sr: [00:07.315920] rigol-ds: Current analog channel state:
sr: [00:07.315955] rigol-ds: CH1 on
sr: [00:07.315981] rigol-ds: CH2 off
sr: [00:07.316134] scpi_usbtmc: Successfully sent SCPI command: ':TIM:SCAL?'.
sr: [00:07.317011] scpi: Got response: '1.000e-03', length 9.
sr: [00:07.317050] rigol-ds: Current timebase 0,001
sr: [00:07.317259] scpi_usbtmc: Successfully sent SCPI command: ':CHAN1:PROB?'.
sr: [00:07.317885] scpi: Got response: '50X', length 3.
sr: [00:07.317927] rigol-ds: Failed to get device config: generic/unspecified error.
Notifying user of session error: "generic/unspecified error"

https://pastebin.com/n8M2JwM4


As it seems, sr_scpi_get_float is throwing the error.
https://sigrok.org/gitweb/?p=libsigrok.git;a=blob;f=src/scpi/scpi.c;h=2477cf2323971c314880c3bc235732fd076c0af3;hb=HEAD#l745
Comment 1 Soeren Apel 2020-07-12 22:34:59 CEST 
On IRC, https://www.keysight.com/upload/cmc_upload/All/1000_series_prog_guide.pdf was provided as reference
Comment 2 Soeren Apel 2020-07-12 23:33:51 CEST 
Fixed in 34ce4d8258e61cb98446e027b2af0d6b522388fc, thanks!
Comment 3 Gerhard Sittig 2020-10-07 20:57:31 CEST 
*** Bug 1397 has been marked as a duplicate of this bug. ***