Bug 1476 - last change of vcd is not visualized/imported
Summary: last change of vcd is not visualized/imported
Status: RESOLVED FIXED
Alias: None
Product: libsigrok
Classification: Unclassified
Component: Input: vcd (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal minor
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-01 20:55 CET by Mathias Walter
Modified: 2020-07-24 14:04 CEST (History)
1 user (show)


Attachments
short vcd file to reproduce the problem (220 bytes, text/plain)
2020-01-01 20:55 CET, Mathias Walter 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Walter 2020-01-01 20:55:09 CET 
Created attachment 570 [details]
short vcd file to reproduce the problem

In addition to bug 1470 I discovered at the same time that the last change/entry of a vcd is ignored/not imported if the end header is missing.

Command to reproduce: sigrok-cli -i test.vcd -O ascii

Output:

1:...../""""\..../""""

Expected output:

1:...../""""\..../""""\

Because of the missing edge, a protocol decoder cannot finalize the decoding.
Comment 1 Mathias Walter 2020-01-01 20:56:05 CET 
The problem applies to PulseView, too.
Comment 2 Gerhard Sittig 2020-01-02 18:20:34 CET 
The issue is independent of the application, it's completely internal to the 
VCD import module which is implemented in the libsigrok library.
Comment 3 Gerhard Sittig 2020-07-24 14:04:37 CEST 
Fixed in libsigrok 0ab36d2f544. Thanks for reporting.