Bug 1396 - driver inappropriately open codes conn=/dev/ttyUSB0 as the default
Summary: driver inappropriately open codes conn=/dev/ttyUSB0 as the default
Status: CONFIRMED
Alias: None
Product: libsigrok
Classification: Unclassified
Component: Driver: link-mso19 (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-22 12:03 CEST by Gerhard Sittig
Modified: 2019-06-22 12:03 CEST (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerhard Sittig 2019-06-22 12:03:44 CEST 
It's common to require that serial port names get specified by users, and 
drivers shall not assume specific names. Enumeration is an option _if_ a 
serial port is involved and the VID/PID is not generic (cannot get confused 
with other regular ports).

The link-mso19 driver should drop the /dev/ttyUSB0 default, and _may_ use 
the 3195.f190 USB identifiers if they are unique to this instrument.

[ Background: Bug 1155 comment 4 made me look at the link-mso19 driver. 
The /dev/ttyUSB0 default is obviously inappropriate. The USB serial adapter 
lookup in the complex udev logic may or may not obsolete it. But that's 
another story, touching portability, haven't completely groked it yet. 
Could be that the link-mso19 driver re-invents parts of libserialport and 
limits itself in the process. ]