Bug 1291 - Cursor and vertical marker line snapping should have a way to snap by sample points (not just edges)
Summary: Cursor and vertical marker line snapping should have a way to snap by sample ...
Status: CONFIRMED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Data display (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-29 14:10 CEST by Uwe Hermann
Modified: 2018-09-29 14:10 CEST (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2018-09-29 14:10:29 CEST 
As mentioned by joefitz in #684#c1 it would be great if there was a way to also hhave cursors (and the vertical marker from #770) snap to sample points (not just signal edges).

"In addition to snap-to-edge, snap-to-sample would be a nice to have. Psuedocode might be:

When dragging timing marker:
If CTRL (or other) key is pressed
-- place cursor in absolute position
ELSE
-- If mouse over a dataline
---- If nearest edge on moused-over dataline is < (5% * Display width)
------ Then snap to nearest edge of datalin
------ Else snap to nearest sample edge"

One method to do sample-snapping could be that it's only done if you enable "show sample points" (e.g. by pressing "." or via the menu). If that's not enabled, there'll be no snapping to samples (?) But maybe there's useful cases to snap to samples even when the dots are not being shown (?) Not sure.

Additionally, with the snapping the #1290 "show number of samples between cursors" becomes more convenient.