*
* @return SR_OK upon success, SR_ERR_BUG if no session exists.
*/
-SR_API int sr_session_dev_clear(void)
+SR_API int sr_session_dev_remove_all(void)
{
if (!session) {
sr_err("session: %s: session was NULL", __func__);
return SR_ERR_ARG;
}
+ if (!session) {
+ sr_err("session: %s: session was NULL", __func__);
+ return SR_ERR_BUG;
+ }
+
+ /* If dev->driver is NULL, this is a virtual device. */
if (!dev->driver) {
- sr_err("session: %s: dev->driver was NULL", __func__);
- return SR_ERR_ARG;
+ sr_dbg("session: %s: dev->driver was NULL, this seems to be "
+ "a virtual device; continuing", __func__);
+ /* Just add the device, don't run dev_open(). */
+ session->devs = g_slist_append(session->devs, dev);
+ return SR_OK;
}
+ /* dev->driver is non-NULL (i.e. we have a real device). */
if (!dev->driver->dev_open) {
sr_err("session: %s: dev->driver->dev_open was NULL",
__func__);
- return SR_ERR_ARG;
- }
-
- if (!session) {
- sr_err("session: %s: session was NULL", __func__);
- return SR_ERR; /* TODO: SR_ERR_BUG? */
+ return SR_ERR_BUG;
}
if ((ret = dev->driver->dev_open(dev->driver_index)) != SR_OK) {
}
/**
- * Clear all datafeed callbacks in the current session.
+ * Remove all datafeed callbacks in the current session.
*
* @return SR_OK upon success, SR_ERR_BUG if no session exists.
*/
-SR_API int sr_session_datafeed_callback_clear(void)
+SR_API int sr_session_datafeed_callback_remove_all(void)
{
if (!session) {
sr_err("session: %s: session was NULL", __func__);
* Add a datafeed callback to the current session.
*
* @param cb Function to call when a chunk of data is received.
+ * Must not be NULL.
*
* @return SR_OK upon success, SR_ERR_BUG if no session exists.
*/
return SR_ERR_BUG;
}
- /* TODO: Is 'cb' allowed to be NULL? */
+ if (!cb) {
+ sr_err("session: %s: cb was NULL", __func__);
+ return SR_ERR_ARG;
+ }
session->datafeed_callbacks =
g_slist_append(session->datafeed_callbacks, cb);
if (!session) {
sr_err("session: %s: session was NULL; a session must be "
"created first, before starting it.", __func__);
- return SR_ERR; /* TODO: SR_ERR_BUG? */
+ return SR_ERR_BUG;
}
if (!session->devs) {
/* TODO: Actually the case? */
sr_err("session: %s: session->devs was NULL; a session "
"cannot be started without devices.", __func__);
- return SR_ERR; /* TODO: SR_ERR_BUG? */
+ return SR_ERR_BUG;
}
/* TODO: Check driver_index validity? */
return SR_ERR_ARG;
}
- if (!dev->driver) {
- sr_err("session: %s: dev->driver was NULL", __func__);
- return SR_ERR_ARG;
- }
-
if (!packet) {
sr_err("session: %s: packet was NULL", __func__);
return SR_ERR_ARG;
* @param fd TODO.
* @param events TODO.
* @param timeout TODO.
- * @param cb TODO.
- * @param cb_data TODO.
+ * @param cb Callback function to add. Must not be NULL.
+ * @param cb_data Data for the callback function. Can be NULL.
*
* @return SR_OK upon success, SR_ERR_ARG upon invalid arguments, or
* SR_ERR_MALLOC upon memory allocation errors.
if (!sources) {
sr_err("session: %s: sources was NULL", __func__);
- return SR_ERR_BUG; /* TODO: Other? */
+ return SR_ERR_BUG;
}
/* TODO: Check if 'fd' valid. */