]>
Commit | Line | Data |
---|---|---|
a2353f60 UH |
1 | ------------------------------------------------------------------------------- |
2 | HACKING | |
3 | ------------------------------------------------------------------------------- | |
4 | ||
5 | Coding style | |
6 | ------------ | |
7 | ||
8 | This project is programmed using the Linux kernel coding style, see | |
9 | http://lxr.linux.no/linux/Documentation/CodingStyle for details. | |
10 | ||
11 | Please use the same style for any code contributions, thanks! | |
12 | ||
13 | ||
14 | Contributions | |
15 | ------------- | |
16 | ||
17 | - Patches should be sent to the development mailinglist at | |
18 | sigrok-devel@lists.sourceforge.net (please subscribe to the list first). | |
19 | ||
20 | https://lists.sourceforge.net/lists/listinfo/sigrok-devel | |
21 | ||
22 | - Alternatively, you can also clone the git repository and let us know | |
23 | from where to pull/review your changes. You can use gitorious.org, | |
24 | github.com, or any other public git hosting site. | |
25 | ||
26 | ||
2bba3dd3 UH |
27 | Adding a new hardware driver |
28 | ---------------------------- | |
29 | ||
30 | The simple, scripted way (recommended): | |
31 | --------------------------------------- | |
32 | ||
33 | Use the 'new-driver' script from the sigrok-util repo: | |
34 | ||
35 | $ git clone git://sigrok.org/sigrok-util | |
36 | $ cd sigrok-util/source | |
37 | $ ./new-driver "Tondaj SL-814" | |
38 | ||
39 | The example above generates a patch file against the current libsigrok | |
40 | development git tree which adds a simple "stub" driver for your device | |
41 | (the Tondaj SL-814 sound level meter in this case). | |
42 | ||
43 | You can apply it like this: | |
44 | ||
45 | $ cd libsigrok | |
46 | $ git am 0001-tondaj-sl-814-Initial-driver-skeleton.patch | |
47 | ||
487c23fc | 48 | You can now edit the files in src/hardware/tondaj-sl-814 as needed |
ef1020f9 UH |
49 | and implement your driver based on the skeleton files there. That means your |
50 | patch submission later will consist of at least two patches: the initial one | |
51 | adding the skeleton driver, and one or more additional patches that actually | |
52 | implement the respective driver code. | |
2bba3dd3 UH |
53 | |
54 | ||
55 | The manual way: | |
56 | --------------- | |
57 | ||
58 | This is a rough overview of what you need to do in order to add a new driver | |
59 | (using the Tondaj SL-814 device as example). It's basically what the | |
60 | 'new-driver' script (see above) does for you: | |
61 | ||
487c23fc UH |
62 | - Makefile.am: Add HW_TONDAJ_SL_814 and add to libsigrok_la_SOURCES. |
63 | - configure.ac: Add a DRIVER() and DRIVER2() call. | |
64 | - src/drivers.c: Add a tondaj_sl_814_driver_info entry in two places. | |
65 | - src/hardware/tondaj-sl-814/ directory: Add api.c, protocol.c, protocol.h. | |
2bba3dd3 UH |
66 | |
67 | See existing drivers or the 'new-driver' output for the details. | |
68 | ||
69 | ||
a2353f60 UH |
70 | Random notes |
71 | ------------ | |
72 | ||
ef1020f9 UH |
73 | - Don't do variable declarations in compound statements, only at the |
74 | beginning of a function. | |
75 | ||
76 | - Generally avoid assigning values to variables at declaration time, | |
77 | especially so for complex and/or run-time dependent values. | |
78 | ||
c7e45562 | 79 | - Consistently use g_*malloc() / g_*malloc0(). Do not use standard |
a2353f60 UH |
80 | malloc()/calloc() if it can be avoided (sometimes other libs such |
81 | as libftdi can return malloc()'d memory, for example). | |
82 | ||
83 | - Always properly match allocations with the proper *free() functions. If | |
c7e45562 | 84 | glib's g_*malloc()/g_*malloc0() was used, use g_free() to free the |
a2353f60 UH |
85 | memory. Otherwise use standard free(). Never use the wrong function! |
86 | ||
c7e45562 UH |
87 | - We assume that "small" memory allocations (< 1MB) will always succeed. |
88 | Thus, it's fine to use g_malloc() or g_malloc0() for allocations of | |
89 | simple/small structs and such (instead of using g_try_malloc()), and | |
90 | there's no need to check the return value. | |
91 | ||
92 | Do use g_try_malloc() or g_try_malloc0() for large (>= 1MB) allocations | |
93 | and check the return value. | |
a2353f60 | 94 | |
8ed26250 | 95 | - You should never print any messages (neither to stdout nor stderr nor |
a2353f60 UH |
96 | elsewhere) "manually" via e.g. printf() or g_log() or similar functions. |
97 | Only sr_err()/sr_warn()/sr_info()/sr_dbg()/sr_spew() should be used. | |
98 | ||
99 | - Use glib's gboolean / TRUE / FALSE for boolean types consistently. | |
100 | Do not use <stdbool.h> and its true / false, and do not invent private | |
101 | definitions for this either. | |
102 | ||
103 | - Consistently use the same naming convention for #include guards in headers: | |
104 | <PROJECTNAME>_<PATH_TO_FILE>_<FILE> | |
105 | This ensures that all #include guards are always unique and consistent. | |
487c23fc | 106 | Example: LIBSIGROK_HARDWARE_MIC_985XX_PROTOCOL_H |
a2353f60 UH |
107 | |
108 | - Consistently use the same naming convention for API functions: | |
109 | <libprefix>_<groupname>_<action>(). | |
110 | ||
111 | Examples: | |
112 | sr_log_loglevel_set(), sr_log_loglevel_get(), sr_log_handler_set(), | |
113 | sr_log_handler_set_default(), and so on. | |
114 | Or: | |
115 | sr_session_new(), sr_session_destroy(), sr_session_load(), and so on. | |
116 | ||
117 | Getter/setter function names should usually end with "_get" or "_set". | |
118 | Functions creating new "objects" should end with "_new". | |
119 | Functions destroying "objects" should end with "_destroy". | |
120 | Functions adding or removing items (e.g. from lists) should end with | |
121 | either "_add" or "_remove". | |
122 | Functions operating on all items from a list (not on only one of them), | |
123 | should end with "_all", e.g. "_remove_all", "_get_all", and so on. | |
124 | Use "_remove_all" in favor of "_clear" for consistency. | |
125 | ||
f18297a5 UH |
126 | - All enums should generally use an explicit start number of 10000. |
127 | If there are multiple "categories" in the enum entries, each category | |
128 | should be 10000 entries apart from the next one. The start of categories | |
129 | are thus 10000, 20000, 30000, and so on. | |
130 | ||
131 | Adding items to an enum MUST always append to a "category", never add | |
132 | items in the middle of a category. The order of items MUST NOT be changed. | |
133 | Any of the above would break the ABI. | |
134 | ||
135 | The enum item 0 is special and is used as terminator in some lists, thus | |
136 | enums should not use this for "valid" entries (and start at 10000 instead). | |
137 | ||
b4bd7088 UH |
138 | |
139 | Doxygen | |
140 | ------- | |
141 | ||
a2353f60 UH |
142 | - In Doxygen comments, put an empty line between the block of @param lines |
143 | and the final @return line. The @param lines themselves (if there is more | |
144 | than one) are not separated by empty lines. | |
145 | ||
b4bd7088 UH |
146 | - Mark private functions (SR_PRIV) with /** @private */, so that Doxygen |
147 | doesn't include them in the output. Functions that are "static" anyway | |
148 | don't need to be marked like this. | |
149 | ||
150 | - Mark private variables/#defines with /** @cond PRIVATE */ and | |
151 | /** @endcond */, so that Doxygen doesn't include them in the output. | |
152 | Variables that are "static" don't need to be marked like this. | |
153 | ||
9fb5f2df | 154 | - Mark all public API functions (SR_API) with a @since tag which indicates |
ef1020f9 UH |
155 | in which release the respective function was added (e.g. "@since 0.1.0"). |
156 | ||
157 | If the function has existed before, but its API changed later, the @since | |
158 | tag should mention only the release when the API last changed. | |
159 | ||
160 | Example: The sr_foo() call was added in 0.1.0, but the API changed in | |
161 | the later 0.2.0 release. The docs should read "@since 0.2.0" in that case. | |
9fb5f2df UH |
162 | |
163 | Non-public functions (static ones, and those marked SR_PRIV) don't need | |
164 | to have @since markers. | |
165 | ||
166 | The @since tag should be the last one, i.e. it should come after @param, | |
167 | @return, @see, and so on. | |
168 | ||
a2353f60 | 169 | |
79bb0e97 UH |
170 | Testsuite |
171 | --------- | |
172 | ||
173 | You can run the libsigrok testsuite using: | |
174 | ||
175 | $ make check | |
176 | ||
177 | ||
a2353f60 UH |
178 | Release engineering |
179 | ------------------- | |
180 | ||
181 | See | |
182 | ||
183 | http://sigrok.org/wiki/Developers/Release_process | |
184 | ||
185 | for a list of items that need to be done when releasing a new tarball. | |
186 |