Bug 942 - Selecting 0/0 pos/neg vdivs makes channel unselectable
Summary: Selecting 0/0 pos/neg vdivs makes channel unselectable
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Other (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-03 15:27 CEST by Uwe Hermann
Modified: 2017-05-27 20:09 CEST (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2017-05-03 15:27:23 CEST 
How to reproduce:

 - Start PV, use demo driver.

 - Click on A0, set 0 pos vdivs and 0 neg vdivs.

The A0 trace will now be below the A1 trace and cannot be seen anymore and it cannot easily be selected to revert the changes.

You can drag away A1, but as soon as you release, it'll pop back right on top of A0.

Workaroud: Ungroup A0-A3, manually move channels, select A0 and restore settings, regroup.

A proper fix would probably be to not allow 0/0 vdivs, always enforce at least one (or at least pretend that there's >= 1 for the resp. check in the code).
Comment 1 Uwe Hermann 2017-05-27 20:09:25 CEST 
Fixed in 80067e4944e111bfa8d6b399812dddaa29d5a4ab, thanks!