Bug 814 - SVG application icon causes QPainter warnings when using dock windows
Summary: SVG application icon causes QPainter warnings when using dock windows
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Other (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-10 13:18 CEST by Soeren Apel
Modified: 2016-08-19 01:22 CEST (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2016-07-10 13:18:29 CEST 
Once the multiview stuff is merged to PV mainline, it will be hit by this bug:

https://bugreports.qt.io/browse/QTBUG-31485

Judging by its history, I wouldn't count on it ever being fixed for Qt4. It may have been fixed for Qt5 but I can't verify this at the moment.

Commenting out this portion of MainWindow::setup_ui() proves that indeed it's the application icon that causes this:

	// Set the window icon
	QIcon icon;
	icon.addFile(QString(":/icons/sigrok-logo-notext.svg"));
	setWindowIcon(icon);

Obviously, simply removing the icon isn't a viable solution, so unless it's fixed in Qt5, we may have to use a PNG icon instead.
Comment 1 Uwe Hermann 2016-07-19 09:11:53 CEST 
That's fine IMHO, using a PNG is acceptable if it avoids the issue.
Comment 2 Uwe Hermann 2016-08-19 01:22:14 CEST 
Fixed in 14f9d4a1f4472d29366ed8333b20f4041cf1b443, thanks!