Bug 810 - PV fails to build on some architectures due to incorrect libatomic handling
Summary: PV fails to build on some architectures due to incorrect libatomic handling
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Portability (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-11 16:37 CEST by Uwe Hermann
Modified: 2016-06-12 20:22 CEST (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2016-06-11 16:37:34 CEST 
As reported on the mailing list PV fails to build e.g. on sparc-buildroot-linux-uclibc:

http://article.gmane.org/gmane.comp.debugging.sigrok.devel/2097


/home/jenkins_slave/buildroot-sparc-buildroot-linux-uclibc/output/host/usr/lib/gcc/sparc-buildroot-linux-uclibc/4.9.3/../../../../sparc-buildroot-linux-uclibc/bin/ld: CMakeFiles/pulseview.dir/pv/mainwindow.cpp.o: undefined reference to symbol '__atomic_fetch_add_4@@LIBATOMIC_1.0'
/home/jenkins_slave/buildroot-sparc-buildroot-linux-uclibc/output/host/usr/sparc-buildroot-linux-uclibc/sysroot/lib/libatomic.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status


A patch is available and will be merged after a test, adding this bug purely for track-keeping purposes.
Comment 1 Uwe Hermann 2016-06-12 20:22:07 CEST 
Fixed in 4da54b6be6a1ca19a2026908d48ae5c8d327ec86, thanks a lot!

Can confirm that the patch indeed fixes the issue, and also that it doesn't break the build on any other architecture AFAICS (Mac OS X, FreeBSD, Android, MinGW, ...).