Bug 792 - crash when Save Selected Range As has cursor at less than zero seconds
Summary: crash when Save Selected Range As has cursor at less than zero seconds
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Other (show other bugs)
Version: unreleased development snapshot
Hardware: Other Windows
: Normal major
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-02 11:23 CEST by Joe Butler
Modified: 2016-05-04 01:17 CEST (History)
2 users (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Butler 2016-05-02 11:23:07 CEST
The Saving... dialog with a percentage progress bar and a Cancel button appears. Then Windows pops up the 'pulseview.exe has stopped working' dialog.

64 bit Windows 8.1

An unhandled win32 exception occurred in pulsview.exe 

Unhandled exception at 0x7677B5F0 (msvcrt.dll) in pulseview.exe: 0xC0000005: Access violation reading location 0x0571F000.

_memcpy()

7677B5F0  rep movs    dword ptr es:[edi],dword ptr [esi]  
7677B5F2  jmp         dword ptr [edx*4+7677B440h]  
7677B5F9  cmp         edi,eax  
7677B5FB  jae         _memcpy+1Ch (7677B3BCh)  
7677B601  jmp         _memcpy+0B0h (7677B450h)  
7677B606  mov         eax,dword ptr [esi+ecx*4-0Ch]  
7677B60A  mov         dword ptr [edi+ecx*4-0Ch],eax  
7677B60E  jmp         _memcpy+4Ah (7677B3EAh)  
7677B613  mov         eax,dword ptr [esi+ecx*4-10h]  
7677B617  mov         dword ptr [edi+ecx*4-10h],eax  
7677B61B  jmp         _memcpy+266h (7677B606h)  
7677B61D  mov         al,byte ptr [esi]  
7677B61F  mov         byte ptr [edi],al  
7677B621  mov         al,byte ptr [esi+1]  
7677B624  mov         byte ptr [edi+1],al  
7677B627  mov         eax,dword ptr [ebp+8]  
7677B62A  pop         esi  
7677B62B  pop         edi  
7677B62C  leave  
7677B62D  ret  
7677B62E  nop  
7677B62F  nop  
___clocalestr:
7677B630  inc         ebx  
7677B631  add         byte ptr [eax+2E90h],dl  
7677B637  nop  
___lconv_static_W_decimal:
7677B638  add         byte ptr cs:[eax],al  
7677B63B  add         byte ptr [eax],al  
7677B63D  add         byte ptr [eax+6E755390h],dl  
7677B643  add         byte ptr [ebp+6Fh],cl  
7677B646  outs        dx,byte ptr [esi]
Comment 1 Soeren Apel 2016-05-03 21:13:22 CEST
The reason for this bug is that we were requesting a sample range that is outside the range of samples we have.

Fix here: https://github.com/abraxa/pulseview/commit/baed700e7c30fa6428eb646f652584c295692cfb
Comment 2 Uwe Hermann 2016-05-04 01:17:19 CEST
Fixed in 40ec0302a21055e85572ced539c457f0d8484c82, thanks!