Bug 727 - Can't edit traces after loading file using an import module
Summary: Can't edit traces after loading file using an import module
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Other (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-02 11:28 CET by Soeren Apel
Modified: 2016-05-11 20:13 CEST (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2016-01-02 11:28:42 CET 
Steps to reproduce:

1) Load a file using an import module (e.g. binary)
2) Click on the trace arrow of any trace to open the channel popup
3) Change the name and/or color

Expected result: the channel settings are changed

Actual result: nothing happens - this becomes especially clear when opening the popup a second time: the original settings are still there.


I tried debugging the issue and noticed that Trace::on_colour_changed() is triggered when an actual device is used or a loaded .sr file. However, it is not triggered when an import module is loaded.

The only difference to me seems to be that the session device is NULL when an import module is used but I currently have no idea how that could cause this behavior.
Comment 1 Soeren Apel 2016-05-03 21:13:03 CEST 
Turns out that https://github.com/abraxa/pulseview/commit/2b01e6201162a1acacbd7afcff3bd76bb6945686 fixes this as a side-effect. I assume it's because there is a stale previous device instance that the popups use but which isn't the current device.
Comment 2 Uwe Hermann 2016-05-11 20:13:23 CEST 
Confirmed, this was indeed fixed in cda515676ce6c2fa81e1cecacba3ea26ec2ee50e (thanks!), closing the bug.