Bug 711 - PV crashes after loading and ungrouping
Summary: PV crashes after loading and ungrouping
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: File handling (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: High blocker
Target Milestone: PulseView 0.3.0
Assignee: Soeren Apel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-12 13:21 CET by Soeren Apel
Modified: 2016-01-02 10:31 CET (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2015-12-12 13:21:52 CET 
How to reproduce:

1) Load a file in PV
2) Ungroup the channels
3) Click on one of the channel labels
4) PV crashes with "Caught exception: generic/unspecified error"

This doesn't happen after a regular acquisition, only for loaded files.
Comment 1 Soeren Apel 2015-12-13 15:50:29 CET 
Turns out this happens also if you just click on the label without ungrouping first.
Comment 2 Soeren Apel 2016-01-02 10:31:47 CET 
Fixed by libsigrok commit 36bb818d6f10ac1187f160f4c2ab1169aeb4e86f and friends. The original issue was that Configurable::config_keys() threw an exception in the check(sr_config_list()) call as sr_config_list() returns SR_ERR when device is null.
This was the case for loaded files using an import module, so PV crashed.

Alas, the patch set fixed this issue as a side effect.