Bug 685 - Visualize SR_DF_TRIGGER
Summary: Visualize SR_DF_TRIGGER
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Markers (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-31 10:30 CET by Tilman Sauerbeck
Modified: 2015-11-06 07:32 CET (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tilman Sauerbeck 2015-10-31 10:30:52 CET 
PulseView should automatically add a non-movable marker at the point in the sample stream where the trigger matched (ie, when SR_DF_TRIGGER was sent).
Comment 1 Uwe Hermann 2015-10-31 18:58:17 CET 
Yup, agreed. This should be added.
Comment 2 Soeren Apel 2015-11-05 21:03:12 CET 
Possible implementation: https://github.com/abraxa/pulseview/commit/ef3caae37e790b29a40d2690ec8329a4667902e3
Comment 3 Soeren Apel 2015-11-05 21:09:04 CET 
Whitespace fixes: https://github.com/abraxa/pulseview/commit/e14e5d570c6bd3c031aeb489ab9e54dec53dbe56

Should've included them in the first place... my bad =(
Comment 4 Uwe Hermann 2015-11-05 23:15:45 CET 
Fixed in 48257a69ffad409c9893605d99cd6e15161dff4f, thanks!
Comment 5 Soeren Apel 2015-11-06 07:32:06 CET 
Fixed whitespace fix :)

https://github.com/abraxa/pulseview/commit/e260704f97e8bae917dca49863ccb89c38b298a0