Bug 599 - PulseView writes broken session files
Summary: PulseView writes broken session files
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: File handling (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal major
Target Milestone: PulseView 0.3.0
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-25 15:03 CEST by Daniel Elstner
Modified: 2015-08-09 17:13 CEST (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Elstner 2015-06-25 15:03:58 CEST 
Steps to reproduce:

1) Open session file sigrok-dumps/z80/kc85/kc85-20mhz.sr
2) Save session as srzip file

Result: An empty, non-closable window opens (PulseView is still responsive though). The saved session file seems to be truncated (1.5k vs 3.4k).

When loading the saved session file, it appears that only 1/5 of the samples have been saved. This hints at a problem with the unit size handling, which is 5 for this particular dump.

It may also be a bug in the output module; but I cannot test this at the moment as sigrok-cli crashes on me when trying to do anything beyond --help output.
Comment 1 Daniel Elstner 2015-06-25 15:15:42 CEST 
OK, I solved my sigrok-cli problem and tested an acquisition with the LWLA1034:

  sigrok-cli -d sysclk-lwla -c samplerate=100000000 -o test.sr --samples 1000000

The resulting file contains all 1 million samples. When doing the same capture with PulseView, only 200000 samples are saved.
Comment 2 Uwe Hermann 2015-07-31 21:40:21 CEST 
Fixed in a42efb9d247268dde5c78f112b3970211bac4088, thanks!

Verified to work correctly on Sysclk LWLA1034 (34ch, unitsize 5), OLS (32ch, unitsize 4), Saleae Logic16 (16ch, unitsize 2), Ikalogic ScanaPLUS (9ch, unitsize 2).