Bug 598 - Panning corrupts border of highlighted trace marker
Summary: Panning corrupts border of highlighted trace marker
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Data display (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: PulseView 0.3.0
Assignee: Soeren Apel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-21 21:52 CEST by Soeren Apel
Modified: 2017-12-23 01:07 CET (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2015-06-21 21:52:16 CEST 
How to reproduce:
1) Start sigrok
2) Click on any trace marker to highlight a trace
3) Click on the trace line associated with the trace to hide the popup
4) Move the trace vertically, no matter the distance
5) Pan the trace horizontally

Result:
The tip of the border supposed to highlight the trace isn't redrawn.

Note:
It is unclear to me what the bug actually is: the missing repaint or the fact that the trace remains selected after step 4.
Comment 1 Joel Holdsworth 2015-06-28 22:56:46 CEST 
The cause of this is that the "labels" are drawn spilling out of the the Header and Ruler windows onto the Viewport without being clipped. One solution is to request that the damaged region of the Viewport be invalidated also. A possibly better solution would be to make the Ruler and Header be layered windows composited on top of Viewport so that they don't damage it.
Comment 2 Soeren Apel 2017-12-23 01:07:40 CET 
No longer relevant as the trace labels have been moved so that they no longer damage the viewport.