Bug 404 - Session saving is broken for devices with more than one channel
Summary: Session saving is broken for devices with more than one channel
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: File handling (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal blocker
Target Milestone: PulseView 0.3.0
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-31 14:56 CEST by Soeren Apel
Modified: 2015-07-31 21:40 CEST (History)
2 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Soeren Apel 2014-08-31 14:56:35 CEST 
Problem:
When trying to save a session with only a single channel being enabled, PV still refuses to save. The error message is "PulseView currently only has support for storing a single data stream".

Cause:
The underlying cause is that StoreSession::start() calls SigSession::get_data() and expects the returned data to only contain data for one channel. As get_data() however returns the data for all channels the device provides, this fails for all devices with more than one channel.

How to replicate:
- Open PV
- Use demo device
- Disable all channels except for one
- Try to save the session via File->Save As
Comment 1 Uwe Hermann 2015-07-31 21:40:05 CEST 
Fixed in de6e819c8a6b3f61e69bbb53b5c853ee6686641e, thanks!