Bug 1649 - PV Save dialog does not close automatically
Summary: PV Save dialog does not close automatically
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: UI (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Ralf
URL:
Keywords:
: 1685 1689 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-12-20 18:44 CET by Ralf
Modified: 2021-06-22 20:25 CEST (History)
4 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf 2020-12-20 18:44:48 CET 
Current HEAD revision does not close the save file dialog automatically, but requires pressing the cancel button after the progress bar reaches 100%
(Current HEAD is commit e6c8d58bde2c32f0ee8b73c5577505736caf8e23)

The same behavior can be observed with the current PulseView-NIGHTLY-x86_64.AppImage

Has this been addressed already or can I help?
Comment 1 Ralf 2021-01-10 18:26:50 CET 
Proposed fix: https://github.com/sigrokproject/pulseview/pull/35
(See also PR#36 and PR#37)
Comment 2 Francois Grieu 2021-02-03 14:25:20 CET 
The save dialag does not reach 100% (got 83% with a 50MSamples 8 bit trace) and does not close automatically.
Workaround: dismiss dialog with close box.
Confirmed with 2021-02-03 pulseview-64bit-static-release-installer.exe on clean Win10 latest everything.
Comment 3 Ralf 2021-05-17 11:29:37 CEST 
*** Bug 1685 has been marked as a duplicate of this bug. ***
Comment 4 Gerhard Sittig 2021-06-13 08:24:11 CEST 
*** Bug 1689 has been marked as a duplicate of this bug. ***
Comment 5 Soeren Apel 2021-06-22 20:25:35 CEST 
Fixed in a6fa4d477d783478935a78c1b70596e38ae8ca64, thanks!