Bug 1375 - Allow the user to filter the I²C and I²S decoders also as I2C and I2S.
Summary: Allow the user to filter the I²C and I²S decoders also as I2C and I2S.
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: UI (show other bugs)
Version: unreleased development snapshot
Hardware: x86 Windows
: Normal minor
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
: 1381 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-04-16 19:36 CEST by Carlos Diaz
Modified: 2019-04-24 20:56 CEST (History)
3 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Diaz 2019-04-16 19:36:48 CEST 
I find more comfortable to search for I2C (or i2c) and I2S (or i2s) in the decoder selector instead of I²C and I²S.

Is it possible to add an alias of some sort?

Using PulseView 0.5.0-git-af33d4c
Comment 1 Soeren Apel 2019-04-21 08:48:59 CEST 
Thanks for the hint, this indeed should work out-of-the-box.

The easiest solution to me would be to include the PD's ID in the search since the ID must be plain ASCII and for the I²C PD is indeed i2c. Currently, only the PD name (not ID) is used in the search.

As the ID is already present in the model and sits in a hidden column, this change can be done by telling the proxy model to look in all columns, not just column 0.

Fix is here:
https://github.com/abraxa/pulseview/commit/b032da6260e46cd7f9ff998da21d687e7d54cf9d
Comment 2 Carlos Diaz 2019-04-21 21:56:30 CEST 
Thanks for the quick fix.

Right now i'm not able to build PV from sources, so i will wait until this goes in the nightly build to test it.

Regards
Comment 3 Uwe Hermann 2019-04-22 21:27:06 CEST 
Merged in b032da6260e46cd7f9ff998da21d687e7d54cf9d, thanks!

Rebuilt Windows installers will be available in 30 minutes or so.
Comment 4 Soeren Apel 2019-04-24 20:56:10 CEST 
*** Bug 1381 has been marked as a duplicate of this bug. ***