Bug 1210 - Counter PD doesn't handle counts longer than ~2 digits
Summary: Counter PD doesn't handle counts longer than ~2 digits
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Data display (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-26 05:31 CEST by whitequark
Modified: 2018-05-30 19:16 CEST (History)
2 users (show)


Attachments
screenshot (23.81 KB, image/png)
2018-05-26 05:31 CEST, whitequark 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description whitequark 2018-05-26 05:31:53 CEST 
Created attachment 431 [details]
screenshot

See attached screenshot.
Comment 1 Gerhard Sittig 2018-05-26 10:48:53 CEST 
From the screenshot it's obvious that the decoder does support large counts, see 
the six digits in the tooltip.  It's just that the unfortunate implementation 
detail which emits narrow annotations of just one sample number width limits 
the visible area in the annotation row itself.

Adjusting the decoder implementation to emit wider annotations is possible, 
and probably useful.
Comment 2 whitequark 2018-05-26 11:07:01 CEST 
Yes, I was thinking that the decoder could/should emit a different annotation type.
Comment 3 Uwe Hermann 2018-05-30 14:27:29 CEST 
Fixed in 17869208b8cc79e1ff6bd003b9a64e1b6f07a140, thanks!
Comment 4 whitequark 2018-05-30 19:16:03 CEST 
Thanks for the prompt fixes!