Bug 1162 - Changing two parameters for a protocol decoder resets the first set parameter to its default value
Summary: Changing two parameters for a protocol decoder resets the first set parameter...
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Protocol decoding (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-17 11:03 CEST by Peter Mortensen
Modified: 2018-04-18 14:39 CEST (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Mortensen 2018-04-17 11:03:58 CEST
The following is for the CAN protocol decoder, but it may affect all protocol decoders.

The 8ce0e732cfe912e022eb96d06aaaa40390efcd6b (2018-04-08) fix to PulseView (now again updates the display when a parameter to an applied CAN protocol decoder is changed, e.g. bit rate) seemed to have introduced a new problem:

If the "Sample point (%)" parameter is changed then the protocol decoder reverts to using the default bit rate, 1000000. E.g. if the bit rate first has been set to 250000 then changing the "Sample point (%)" parameter will result in a effective bit rate of 1000000 (the display is updated immediately).

(It is the same the other way around - if the "Sample point (%)" parameter is first changed to 1% and the bit rate is changed from 1000000 to 1000001 it reverts to using the default of 71%.)
Comment 1 Peter Mortensen 2018-04-17 11:11:21 CEST
I actually don't know if 8ce0e732cfe912e022eb96d06aaaa40390efcd6b introduced a new problem. The described problem could have been introduced earlier (like the display update problem that was fixed with 8ce0e732cfe912e022eb96d06aaaa40390efcd6b).

All I know is that a nightly from end of December 2017 did not have any of these two problems.
Comment 2 Peter Mortensen 2018-04-17 11:21:13 CEST
Credit should go to IRC "keesj" (Kees Jongenburger, <http://keesj.github.io/A10-OLinuXino-LIME-5510-Shield/index.html>) for noticing this problem.
Comment 3 Peter Mortensen 2018-04-17 19:55:06 CEST
And IRC "L29Ah" - "PulseView goes nuts"
Comment 4 Peter Mortensen 2018-04-18 01:13:01 CEST
To be clear, the parameter appears as changed in the protocol decoder input field, but it is using another value, the default value, instead.
Comment 5 Uwe Hermann 2018-04-18 14:39:31 CEST
Fixed in c5f473341f9198532c44525104d04792c1bd6459, thanks!