Bug 1153 - PV scans too many drivers
Summary: PV scans too many drivers
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: Acquisition (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal minor
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-08 20:07 CEST by Uwe Hermann
Modified: 2018-04-15 14:48 CEST (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Hermann 2018-04-08 20:07:03 CEST
PV currently pretends to scan a lot more drivers than it can actually use.

DeviceManager::DeviceManager() iterates over *all* drivers and updates the progress bar via "Scanning for %1...". However, the actual scan function driver_scan() that's later used to do the actual scan will (correctly) filter out only LAs and scopes, and not scan anything else.

The progressbar should reflect that, i.e. only print progress for those that were actually scanned, IMHO.

The -l 5 output from libsigrok correctly only emits those drivers that were actually scanned by PV (a lot fewer than for e.g. sigrok-cli).
Comment 1 Uwe Hermann 2018-04-15 14:48:23 CEST
Fixed in 8d054b91e39afd8e3b04cdde8e37f2c94aa2e608, thanks!