Bug 1039 - file import, filename extension is * instead of the input module's *.ext
Summary: file import, filename extension is * instead of the input module's *.ext
Status: RESOLVED FIXED
Alias: None
Product: PulseView
Classification: Unclassified
Component: UI (show other bugs)
Version: unreleased development snapshot
Hardware: All All
: Normal normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-09-17 18:48 CEST by Gerhard Sittig
Modified: 2023-04-06 15:11 CEST (History)
2 users (show)



Attachments
file dialog, filename extension, * instead of *.vcd for VCD (8.44 KB, image/png)
2017-09-17 18:48 CEST, Gerhard Sittig
Details
file dialog, filename extension, *.sr (good) for srzip (7.78 KB, image/png)
2017-09-17 18:51 CEST, Gerhard Sittig
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerhard Sittig 2017-09-17 18:48:49 CEST
Created attachment 335 [details]
file dialog, filename extension, * instead of *.vcd for VCD

In the Pulseview UI, the toolbar has a button to open and to import files. 
"Open" (CTRL-O) assumes the native srzip format, and the file dialog uses the 
*.sr file extension.  For "Open As" (aka import) the name of the input module 
is reflected but the filename extension is * for all input format choices, 
instead of the input module's respective extension.

This may or may not be a duplicate of bug 753 (or its effect), which is about 
"Save" and not appending the output module's usual extension.  Which could 
have the same cause as the lack of extension for import dialogs.
Comment 1 Gerhard Sittig 2017-09-17 18:51:25 CEST
Created attachment 336 [details]
file dialog, filename extension, *.sr (good) for srzip

That "Open" does support a proper filename extension *.sr suggests that the 
dialog could work for input modules, too.
Comment 2 Gerhard Sittig 2017-09-17 19:04:52 CEST
Looks like MainBar::import_file() creates a filter from the input module's 
list of file extensions, but then opens the dialog with a fixed filter that 
does not reflect these extensions.
Comment 3 Uwe Hermann 2018-02-10 21:31:42 CET
Fixed in ca1d6d5f466272ac7e906b589e2804b12568fa96, thanks!
Comment 4 Rock 2023-04-06 15:11:35 CEST
Gravity-fed feeders are the most common type of hummingbird feeder. They consist of a plastic or glass reservoir that holds the sugar water and a feeding port that the birds can access. As the birds feed, the sugar water naturally flows down into the feeding port due to gravity. These feeders are easy to use and maintain, but they can be prone to leaking if not properly designed. https://hummingbirdfeedercenter.com/best-squirrel-proof-hummingbird-feeder/