sigrok-fwextract-kingst-la2016: concentrate RCC flags in one spot Move the symbolic identifiers for RCC flag bits to one common location in the Qt resource handling support code. Previous versions kept them local to individual methods which referenced them.
sigrok-fwextract-kingst-la2016: handle compressed Qt resources Qt resources in executable images support optional compression. Recent vendor software uses this feature. Uncompress firmware images during extraction of their blobs. This handles the Qt resource compression part of bug #1825.
cross-compile/mingw: comment on sigrok specific "MXE fixes" patch No change in behaviour, just comments and grouping and whitespace fixup. Separate the binutils downgrade from the glib downgrade. Provide empty lines for faster editor navigation. Provide comments for human readers. Keep MXE's style of glib.mk indentation when disabling warnings. This patch no longer applies to recent MXE versions, but might as well have become obsolete. A build without these "MXE fixes" patches is attempted, the result is yet to get determined. Needs more consideration.
sigrok-cross-mingw: pass PREFIX to sigrok-dumps install command Catch up with recent sigrok-dumps Makefile adjustment. The DESTDIR variable traditionally serves a different purpose. Prefer PREFIX to specify the in-filesystem base path where share/... is located.
cross-compile/macosx: Set DYLD_LIBRARY_PATH After a prior change to the dynamic library path location users have reported issues of nightly builds crashing on MacOS: - #1633 - #1627 - #1651 - #1744 This change, mentioned by Andrea Leofreddi in #1633, hints PulseView and sigrok-cli as to the correct location of dynamic libraries through the addition of an environment variable to the startup script.
sigrok-cross-mingw: use libusb1 version 1.0.24 for MXE builds Stick with libusb1 version 1.0.24 which is provided by current MXE (the patch "changes" from 1.0.24 to 1.0.24, remains in place in case version 1.0.25 is needed or desired later). Don't force a modified 1.0.20-rc3 any longer. Use a RAW_IO commit which is authored by jpa@ and which is discussed in libusb PR 1069.
sigrok-cross-mingw: group and sort libusb1 patches for MXE Order the different types of patches which are applied to MXE's libusb. Unbreak autotools use first, switch the library version then, enable RAW_IO after that. Comment on these groups to help casual readers.
sigrok-cross-mingw: move libusb1 manipulation out of "MXE fixes" Factor the libusb1 related tweaking out of the "MXE fixes" patch file. It is assumed that binutils and glib issues are rather different from the libusb manipulation. A separate libusb patch also simplifies its maintenance. Add comments discussing how the "event abstraction" branch reference may have become obsolete when libusb1 1.0.24 was released. Which only leaves RAW_IO as an essential motivation for a modified version (which is also being submitted towards mainline libusb).
sigrok-cross-mingw: patch for boost numeric literals issue in MXE builds Patch the pulseview cmake instructions within sigrok-util until the pulseview.git repository builds out of the box. General applicability of the compiler switch on all platforms is yet to get determined.
sigrok-fwextract-kingst-la2016: rephrase resource file writer Rearrange the res_writer class of the KingstVis firmware extractor. Separate the bytes/hexfile handling from file writing. Get the CRC in that data handing part. Which leaves data processing to internal helpers, while the calling public routine has all details available, to provide a more helpful log message to users. Separate the resource enumeration from the output file creation. Which prettifies the output (sorted order), and allows future implementations to easier filter the output if desired.
sigrok-fwextract-kingst-la2016: extract more blobs (all of them) The previous implementation exclusively extracted the 01a2 MCU firmware and the LA1016 and LA2016 FPGA bitstreams. The sigrok device driver already supports more devices, and may easily support even more similar devices when their firmware becomes available. Simplify users' reports for currently unsupported devices by just extracting all blobs from the KingstVis executable. This eliminates the necessity to manipulate the extractor script (including regexes), raising the application's diag verbosity is sufficient. Users decide how many of the extracted blobs they copy to the firmware directory, keeping unused files is non-fatal.
sigrok-fwextract-kingst-la2016: comment nits Move the comment on the script's purpose and compatibility with vendor firmware versions to the top of the file. Adress style nits in other comments (start with capital, end in punctuation). The ihex format conversion code most probably doesn't support "\r\n*" (any number of trailing newlines), and neither needs to. Split on LF and trim trailing whitespace is good enough (as the code already does). Make the comment catch up with the implementation.
sigrok-fwextract-kingst-la2016: use argparse(3) for commandline options Neither open code the access to the sys.argv[] detail nor indices of positional arguments. Use the argparse(3) Python module instead, which transparently handles presence checks and provides a help text.