From 12ea952e9a86f5184bf4e52b6a80fbf7072d50f4 Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Fri, 28 Dec 2012 17:30:56 +0100 Subject: [PATCH 1/1] configure.ac: Fix CFLAGS settings. Don't override/overwrite CFLAGS in configure.ac, but rather amend it with (currently) "-Wall -Wextra". This properly allows users/packagers to do things like: ./configure (this will default to using "-g -O2" additionally) CFLAGS="-g -O2" ./configure (same as above) CFLAGS="" ./configure (no additional flags) CFLAGS="-g -O0" ./configure (disable optimization, e.g. for valgrind use) etc. etc. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ea04095..a0c93ef 100644 --- a/configure.ac +++ b/configure.ac @@ -38,7 +38,8 @@ AH_TOP([#ifndef SIGROK_CLI_CONFIG_H #define SIGROK_CLI_CONFIG_H /* To stop multiple inclusions. */]) AH_BOTTOM([#endif /* SIGROK_CLI_CONFIG_H */]) -CFLAGS="-g -Wall -Wextra" +# Enable more compiler warnings via -Wall and -Wextra. +CFLAGS="$CFLAGS -Wall -Wextra" # Checks for programs. AC_PROG_CC -- 2.30.2