X-Git-Url: https://sigrok.org/gitweb/?p=sigrok-cli.git;a=blobdiff_plain;f=sigrok-cli.c;h=e96c67a463fac51fc119001b769f6bb15112fa48;hp=3a460bf67763234bd258a0243512bd33b4786c5e;hb=cfd3ec6e659e099f3b83c4a9bbad98ae30b00739;hpb=c6ca71bb7e80b50e1fc4f0424ddee15ea8dc5633

diff --git a/sigrok-cli.c b/sigrok-cli.c
index 3a460bf..e96c67a 100644
--- a/sigrok-cli.c
+++ b/sigrok-cli.c
@@ -36,15 +36,13 @@
 
 #define DEFAULT_OUTPUT_FORMAT "bits:width=64"
 
-extern struct sr_hwcap_option sr_hwcap_options[];
-
 static uint64_t limit_samples = 0;
 static uint64_t limit_frames = 0;
 static struct sr_output_format *output_format = NULL;
 static int default_output_format = FALSE;
 static char *output_format_param = NULL;
-static char *input_format_param = NULL;
 static GHashTable *pd_ann_visible = NULL;
+static struct sr_datastore *singleds = NULL;
 
 static gboolean opt_version = FALSE;
 static gint opt_loglevel = SR_LOG_WARN; /* Show errors+warnings per default. */
@@ -52,6 +50,7 @@ static gboolean opt_list_devs = FALSE;
 static gboolean opt_wait_trigger = FALSE;
 static gchar *opt_input_file = NULL;
 static gchar *opt_output_file = NULL;
+static gchar *opt_drv = NULL;
 static gchar *opt_dev = NULL;
 static gchar *opt_probes = NULL;
 static gchar *opt_triggers = NULL;
@@ -60,6 +59,7 @@ static gchar *opt_pd_stack = NULL;
 static gchar *opt_pd_annotations = NULL;
 static gchar *opt_input_format = NULL;
 static gchar *opt_output_format = NULL;
+static gchar *opt_show = NULL;
 static gchar *opt_time = NULL;
 static gchar *opt_samples = NULL;
 static gchar *opt_frames = NULL;
@@ -72,6 +72,8 @@ static GOptionEntry optargs[] = {
 			"Set libsigrok/libsigrokdecode loglevel", NULL},
 	{"list-devices", 'D', 0, G_OPTION_ARG_NONE, &opt_list_devs,
 			"Scan for devices", NULL},
+	{"driver", 0, 0, G_OPTION_ARG_STRING, &opt_drv,
+			"Use only this driver", NULL},
 	{"device", 'd', 0, G_OPTION_ARG_STRING, &opt_dev,
 			"Use specified device", NULL},
 	{"input-file", 'i', 0, G_OPTION_ARG_FILENAME, &opt_input_file,
@@ -94,6 +96,8 @@ static GOptionEntry optargs[] = {
 			"Protocol decoder stack", NULL},
 	{"protocol-decoder-annotations", 'A', 0, G_OPTION_ARG_STRING, &opt_pd_annotations,
 			"Protocol decoder annotation(s) to show", NULL},
+	{"show", 0, 0, G_OPTION_ARG_NONE, &opt_show,
+			"Show device detail", NULL},
 	{"time", 0, 0, G_OPTION_ARG_STRING, &opt_time,
 			"How long to sample (ms)", NULL},
 	{"samples", 0, 0, G_OPTION_ARG_STRING, &opt_samples,
@@ -105,6 +109,90 @@ static GOptionEntry optargs[] = {
 	{NULL, 0, 0, 0, NULL, NULL, NULL}
 };
 
+
+/* Convert driver options hash to GSList of struct sr_hwopt. */
+static GSList *hash_to_hwopt(GHashTable *hash)
+{
+	const struct sr_hwcap_option *hwo;
+	struct sr_hwopt *hwopt;
+	GList *gl, *keys;
+	GSList *opts;
+	char *key, *value;
+
+	keys = g_hash_table_get_keys(hash);
+	opts = NULL;
+	for (gl = keys; gl; gl = gl->next) {
+		key = gl->data;
+		if (!(hwo = sr_drvopt_name_get(key))) {
+			g_critical("Unknown option %s", key);
+			return NULL;
+		}
+		hwopt = g_try_malloc(sizeof(struct sr_hwopt));
+		hwopt->hwopt = hwo->hwcap;
+		value = g_hash_table_lookup(hash, key);
+		hwopt->value = g_strdup(value);
+		opts = g_slist_append(opts, hwopt);
+		break;
+	}
+	g_list_free(keys);
+
+	return opts;
+}
+
+static GSList *device_scan(void)
+{
+	struct sr_dev_driver **drivers, *driver;
+	GHashTable *drvargs;
+	GSList *drvopts, *devices, *tmpdevs, *l;
+	int i;
+	char *drvname;
+
+	if (opt_drv) {
+		drvargs = parse_generic_arg(opt_drv, TRUE);
+		drvname = g_strdup(g_hash_table_lookup(drvargs, "sigrok_key"));
+		g_hash_table_remove(drvargs, "sigrok_key");
+		driver = NULL;
+		drivers = sr_driver_list();
+		for (i = 0; drivers[i]; i++) {
+			if (strcmp(drivers[i]->name, drvname))
+				continue;
+			driver = drivers[i];
+		}
+		if (!driver) {
+			g_critical("Driver %s not found.", drvname);
+			return NULL;
+		}
+		g_free(drvname);
+		if (sr_driver_init(driver) != SR_OK) {
+			g_critical("Failed to initialize driver.");
+			return NULL;
+		}
+		drvopts = NULL;
+		if (g_hash_table_size(drvargs) > 0)
+			if (!(drvopts = hash_to_hwopt(drvargs)))
+				/* Unknown options, already logged. */
+				return NULL;
+		devices = sr_driver_scan(driver, drvopts);
+	} else {
+		/* No driver specified, let them all scan on their own. */
+		devices = NULL;
+		drivers = sr_driver_list();
+		for (i = 0; drivers[i]; i++) {
+			driver = drivers[i];
+			if (sr_driver_init(driver) != SR_OK) {
+				g_critical("Failed to initialize driver.");
+				return NULL;
+			}
+			tmpdevs = sr_driver_scan(driver, NULL);
+			for (l = tmpdevs; l; l = l->next)
+				devices = g_slist_append(devices, l->data);
+			g_slist_free(tmpdevs);
+		}
+	}
+
+	return devices;
+}
+
 static void show_version(void)
 {
 	GSList *l;
@@ -155,11 +243,8 @@ static void show_version(void)
 	printf("\n");
 }
 
-static void print_dev_line(const struct sr_dev *dev)
+static void print_dev_line(const struct sr_dev_inst *sdi)
 {
-	const struct sr_dev_inst *sdi;
-
-	sr_dev_info_get(dev, SR_DI_INST, (const void **)&sdi);
 
 	if (sdi->vendor && sdi->vendor[0])
 		printf("%s ", sdi->vendor);
@@ -167,62 +252,68 @@ static void print_dev_line(const struct sr_dev *dev)
 		printf("%s ", sdi->model);
 	if (sdi->version && sdi->version[0])
 		printf("%s ", sdi->version);
-	if (dev->probes)
-		printf("with %d probes", g_slist_length(dev->probes));
+	if (sdi->probes)
+		printf("with %d probes", g_slist_length(sdi->probes));
 	printf("\n");
 }
 
 static void show_dev_list(void)
 {
-	struct sr_dev *dev, *demo_dev;
-	GSList *devs, *l;
-	int devcnt;
-
-	devcnt = 0;
-	devs = sr_dev_list();
+	struct sr_dev_inst *sdi;
+	GSList *devices, *l;
 
-	if (g_slist_length(devs) == 0)
+	if (!(devices = device_scan()))
 		return;
 
-	printf("The following devices were found:\nID    Device\n");
-	demo_dev = NULL;
-	for (l = devs; l; l = l->next) {
-		dev = l->data;
-		if (sr_dev_has_hwcap(dev, SR_HWCAP_DEMO_DEV)) {
-			demo_dev = dev;
-			continue;
-		}
-		printf("%-3d   ", devcnt++);
-		print_dev_line(dev);
-	}
-	if (demo_dev) {
-		printf("demo  ");
-		print_dev_line(demo_dev);
+	printf("The following devices were found:\n");
+	for (l = devices; l; l = l->next) {
+		sdi = l->data;
+		print_dev_line(sdi);
 	}
+	g_slist_free(devices);
+
 }
 
 static void show_dev_detail(void)
 {
-	struct sr_dev *dev;
+	struct sr_dev_inst *sdi;
 	const struct sr_hwcap_option *hwo;
 	const struct sr_samplerates *samplerates;
 	struct sr_rational *rationals;
+	GSList *devices;
 	uint64_t *integers;
-	const int *hwcaps;
-	int cap, i;
+	const int *hwopts, *hwcaps;
+	int cap, num_devices, n, i;
 	char *s, *title;
 	const char *charopts, **stropts;
 
-	dev = parse_devstring(opt_dev);
-	if (!dev) {
-		printf("No such device. Use -D to list all devices.\n");
+	if (!(devices = device_scan())) {
+		g_critical("No devices found.");
 		return;
 	}
 
-	print_dev_line(dev);
+	num_devices = g_slist_length(devices);
+	if (num_devices > 1) {
+		if (!opt_dev) {
+			g_critical("%d devices found. Use --list-devices to show them, "
+					"and --device to select one.", num_devices);
+			return;
+		}
+		/* opt_dev is NULL if not specified, which is fine. */
+		n = strtol(opt_dev, NULL, 10);
+		if (n >= num_devices) {
+			g_critical("%d devices found, numbered starting from 0.",
+					num_devices);
+			return;
+		}
+		sdi = g_slist_nth_data(devices, n);
+	} else
+		sdi = g_slist_nth_data(devices, 0);
 
-	if (sr_dev_info_get(dev, SR_DI_TRIGGER_TYPES,
-					(const void **)&charopts) == SR_OK) {
+	print_dev_line(sdi);
+
+	if (sr_info_get(sdi->driver, SR_DI_TRIGGER_TYPES, (const void **)&charopts,
+			sdi) == SR_OK && charopts) {
 		printf("Supported triggers: ");
 		while (*charopts) {
 			printf("%c ", *charopts);
@@ -231,10 +322,24 @@ static void show_dev_detail(void)
 		printf("\n");
 	}
 
-	title = "Supported options:\n";
-	hwcaps = dev->driver->hwcap_get_all();
+	if ((sr_info_get(sdi->driver, SR_DI_HWOPTS, (const void **)&hwopts,
+			NULL) == SR_OK) && hwopts) {
+		printf("Supported driver options:\n");
+		for (i = 0; hwopts[i]; i++) {
+			if (!(hwo = sr_drvopt_get(hwopts[i])))
+				continue;
+			printf("    %s\n", hwo->shortname);
+		}
+	}
+
+	title = "Supported device options:\n";
+	if ((sr_info_get(sdi->driver, SR_DI_HWCAPS, (const void **)&hwcaps,
+			NULL) != SR_OK) || !hwcaps)
+		/* Driver supports no device instance options. */
+		return;
+
 	for (cap = 0; hwcaps[cap]; cap++) {
-		if (!(hwo = sr_hw_hwcap_get(hwcaps[cap])))
+		if (!(hwo = sr_devopt_get(hwcaps[cap])))
 			continue;
 
 		if (title) {
@@ -245,8 +350,8 @@ static void show_dev_detail(void)
 		if (hwo->hwcap == SR_HWCAP_PATTERN_MODE) {
 			/* Pattern generator modes */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_PATTERNS,
-					(const void **)&stropts) == SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_PATTERNS,
+					(const void **)&stropts, sdi) == SR_OK) {
 				printf(" - supported patterns:\n");
 				for (i = 0; stropts[i]; i++)
 					printf("      %s\n", stropts[i]);
@@ -257,8 +362,8 @@ static void show_dev_detail(void)
 		} else if (hwo->hwcap == SR_HWCAP_SAMPLERATE) {
 			/* Supported samplerates */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_SAMPLERATES,
-					(const void **)&samplerates) != SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_SAMPLERATES,
+					(const void **)&samplerates, sdi) != SR_OK) {
 				printf("\n");
 				continue;
 			}
@@ -287,8 +392,8 @@ static void show_dev_detail(void)
 		} else if (hwo->hwcap == SR_HWCAP_BUFFERSIZE) {
 			/* Supported buffer sizes */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_BUFFERSIZES,
-					(const void **)&integers) != SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_BUFFERSIZES,
+					(const void **)&integers, sdi) != SR_OK) {
 				printf("\n");
 				continue;
 			}
@@ -299,8 +404,8 @@ static void show_dev_detail(void)
 		} else if (hwo->hwcap == SR_HWCAP_TIMEBASE) {
 			/* Supported time bases */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_TIMEBASES,
-					(const void **)&rationals) != SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_TIMEBASES,
+					(const void **)&rationals, sdi) != SR_OK) {
 				printf("\n");
 				continue;
 			}
@@ -312,8 +417,8 @@ static void show_dev_detail(void)
 		} else if (hwo->hwcap == SR_HWCAP_TRIGGER_SOURCE) {
 			/* Supported trigger sources */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_TRIGGER_SOURCES,
-					(const void **)&stropts) != SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_TRIGGER_SOURCES,
+					(const void **)&stropts, sdi) != SR_OK) {
 				printf("\n");
 				continue;
 			}
@@ -324,8 +429,8 @@ static void show_dev_detail(void)
 		} else if (hwo->hwcap == SR_HWCAP_FILTER) {
 			/* Supported trigger sources */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_FILTERS,
-					(const void **)&stropts) != SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_FILTERS,
+					(const void **)&stropts, sdi) != SR_OK) {
 				printf("\n");
 				continue;
 			}
@@ -336,8 +441,8 @@ static void show_dev_detail(void)
 		} else if (hwo->hwcap == SR_HWCAP_VDIV) {
 			/* Supported volts/div values */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_VDIVS,
-					(const void **)&rationals) != SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_VDIVS,
+					(const void **)&rationals, sdi) != SR_OK) {
 				printf("\n");
 				continue;
 			}
@@ -348,8 +453,8 @@ static void show_dev_detail(void)
 		} else if (hwo->hwcap == SR_HWCAP_COUPLING) {
 			/* Supported coupling settings */
 			printf("    %s", hwo->shortname);
-			if (sr_dev_info_get(dev, SR_DI_COUPLING,
-					(const void **)&stropts) != SR_OK) {
+			if (sr_info_get(sdi->driver, SR_DI_COUPLING,
+					(const void **)&stropts, sdi) != SR_OK) {
 				printf("\n");
 				continue;
 			}
@@ -362,6 +467,7 @@ static void show_dev_detail(void)
 			printf("    %s\n", hwo->shortname);
 		}
 	}
+
 }
 
 static void show_pd_detail(void)
@@ -374,7 +480,7 @@ static void show_pd_detail(void)
 	pdtokens = g_strsplit(opt_pds, ",", -1);
 	for (pdtok = pdtokens; *pdtok; pdtok++) {
 		if (!(dec = srd_decoder_get_by_id(*pdtok))) {
-			printf("Protocol decoder %s not found.\n", *pdtok);
+			g_critical("Protocol decoder %s not found.", *pdtok);
 			return;
 		}
 		printf("ID: %s\nName: %s\nLong name: %s\nDescription: %s\n",
@@ -420,10 +526,11 @@ static void show_pd_detail(void)
 	g_strfreev(pdtokens);
 }
 
-static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
+static void datafeed_in(const struct sr_dev_inst *sdi,
+		struct sr_datafeed_packet *packet)
 {
 	static struct sr_output *o = NULL;
-	static int logic_probelist[SR_MAX_NUM_PROBES] = { 0 };
+	static int logic_probelist[SR_MAX_NUM_PROBES] = { -1 };
 	static struct sr_probe *analog_probelist[SR_MAX_NUM_PROBES];
 	static uint64_t received_samples = 0;
 	static int unitsize = 0;
@@ -454,7 +561,7 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 			exit(1);
 		}
 		o->format = output_format;
-		o->dev = dev;
+		o->sdi = (struct sr_dev_inst *)sdi;
 		o->param = output_format_param;
 		if (o->format->init) {
 			if (o->format->init(o) != SR_OK) {
@@ -485,7 +592,6 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 		if (opt_continuous)
 			g_warning("Device stopped after %" PRIu64 " samples.",
 			       received_samples);
-		sr_session_stop();
 		if (outfile && outfile != stdout)
 			fclose(outfile);
 		g_free(o);
@@ -505,10 +611,11 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 		meta_logic = packet->payload;
 		num_enabled_probes = 0;
 		for (i = 0; i < meta_logic->num_probes; i++) {
-			probe = g_slist_nth_data(dev->probes, i);
+			probe = g_slist_nth_data(sdi->probes, i);
 			if (probe->enabled)
 				logic_probelist[num_enabled_probes++] = probe->index;
 		}
+		logic_probelist[num_enabled_probes] = -1;
 		/* How many bytes we need to store num_enabled_probes bits */
 		unitsize = (num_enabled_probes + 7) / 8;
 
@@ -519,9 +626,9 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 				 * dump everything in the datastore as it comes in,
 				 * and save from there after the session. */
 				outfile = NULL;
-				ret = sr_datastore_new(unitsize, &(dev->datastore));
+				ret = sr_datastore_new(unitsize, &singleds);
 				if (ret != SR_OK) {
-					printf("Failed to create datastore.\n");
+					g_critical("Failed to create datastore.");
 					exit(1);
 				}
 			} else {
@@ -550,8 +657,8 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 			break;
 
 		ret = sr_filter_probes(sample_size, unitsize, logic_probelist,
-					   logic->data, logic->length,
-					   &filter_out, &filter_out_len);
+				logic->data, logic->length,
+				&filter_out, &filter_out_len);
 		if (ret != SR_OK)
 			break;
 
@@ -564,9 +671,9 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 				limit_samples * sample_size))
 			filter_out_len = limit_samples * sample_size - received_samples;
 
-		if (dev->datastore)
-			sr_datastore_put(dev->datastore, filter_out,
-					 filter_out_len, sample_size, logic_probelist);
+		if (singleds)
+			sr_datastore_put(singleds, filter_out,
+					filter_out_len, sample_size, logic_probelist);
 
 		if (opt_output_file && default_output_format)
 			/* saving to a session file, don't need to do anything else
@@ -599,7 +706,7 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 		num_analog_probes = meta_analog->num_probes;
 		num_enabled_analog_probes = 0;
 		for (i = 0; i < num_analog_probes; i++) {
-			probe = g_slist_nth_data(dev->probes, i);
+			probe = g_slist_nth_data(sdi->probes, i);
 			if (probe->enabled)
 				analog_probelist[num_enabled_analog_probes++] = probe;
 		}
@@ -611,9 +718,9 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
 				 * dump everything in the datastore as it comes in,
 				 * and save from there after the session. */
 				outfile = NULL;
-				ret = sr_datastore_new(unitsize, &(dev->datastore));
+				ret = sr_datastore_new(unitsize, &singleds);
 				if (ret != SR_OK) {
-					printf("Failed to create datastore.\n");
+					g_critical("Failed to create datastore.");
 					exit(1);
 				}
 			} else {
@@ -701,7 +808,7 @@ static int register_pds(struct sr_dev *dev, const char *pdstring)
 	pd_opthash = NULL;
 	pdtokens = g_strsplit(pdstring, ",", 0);
 	for (pdtok = pdtokens; *pdtok; pdtok++) {
-		if (!(pd_opthash = parse_generic_arg(*pdtok))) {
+		if (!(pd_opthash = parse_generic_arg(*pdtok, TRUE))) {
 			g_critical("Invalid protocol decoder option '%s'.", *pdtok);
 			goto err_out;
 		}
@@ -869,7 +976,7 @@ int setup_output_format(void)
 		default_output_format = TRUE;
 	}
 
-	fmtargs = parse_generic_arg(opt_output_format);
+	fmtargs = parse_generic_arg(opt_output_format, TRUE);
 	fmtspec = g_hash_table_lookup(fmtargs, "sigrok_key");
 	if (!fmtspec) {
 		g_critical("Invalid output format.");
@@ -930,9 +1037,8 @@ void show_pd_annotations(struct srd_proto_data *pdata, void *cb_data)
 	fflush(stdout);
 }
 
-static int select_probes(struct sr_dev *dev)
+static int select_probes(struct sr_dev_inst *sdi)
 {
-	struct sr_probe *probe;
 	char **probelist;
 	int max_probes, i;
 
@@ -943,7 +1049,7 @@ static int select_probes(struct sr_dev *dev)
 	 * This only works because a device by default initializes
 	 * and enables all its probes.
 	 */
-	max_probes = g_slist_length(dev->probes);
+	max_probes = g_slist_length(sdi->probes);
 	probelist = parse_probestring(max_probes, opt_probes);
 	if (!probelist) {
 		return SR_ERR;
@@ -951,11 +1057,10 @@ static int select_probes(struct sr_dev *dev)
 
 	for (i = 0; i < max_probes; i++) {
 		if (probelist[i]) {
-			sr_dev_probe_name_set(dev, i + 1, probelist[i]);
+			sr_dev_probe_name_set(sdi, i, probelist[i]);
 			g_free(probelist[i]);
 		} else {
-			probe = sr_dev_probe_find(dev, i + 1);
-			probe->enabled = FALSE;
+			sr_dev_probe_enable(sdi, i, FALSE);
 		}
 	}
 	g_free(probelist);
@@ -991,7 +1096,7 @@ static struct sr_input_format *determine_input_file_format(
 	/* If the user specified -I / --input-format, use that one. */
 	if (opt) {
 		for (i = 0; inputs[i]; i++) {
-			if (strcasecmp(inputs[i]->id, opt_input_format))
+			if (strcasecmp(inputs[i]->id, opt))
 				continue;
 			g_debug("Using user-specified input file format '%s'.",
 					inputs[i]->id);
@@ -1000,7 +1105,7 @@ static struct sr_input_format *determine_input_file_format(
 
 		/* The user specified an unknown input format, return NULL. */
 		g_critical("Error: specified input file format '%s' is "
-			"unknown.", opt_input_format);
+			"unknown.", opt);
 		return NULL;
 	}
 
@@ -1024,14 +1129,25 @@ static struct sr_input_format *determine_input_file_format(
 
 static void load_input_file_format(void)
 {
+	GHashTable *fmtargs = NULL;
 	struct stat st;
 	struct sr_input *in;
 	struct sr_input_format *input_format;
+	char *fmtspec = NULL;
+
+	if (opt_input_format) {
+		fmtargs = parse_generic_arg(opt_input_format, TRUE);
+		fmtspec = g_hash_table_lookup(fmtargs, "sigrok_key");
+	}
 
 	if (!(input_format = determine_input_file_format(opt_input_file,
-						   opt_input_format)))
+						   fmtspec))) {
 		/* The exact cause was already logged. */
 		return;
+	}
+
+	if (fmtargs)
+		g_hash_table_remove(fmtargs, "sigrok_key");
 
 	if (stat(opt_input_file, &st) == -1) {
 		g_critical("Failed to load %s: %s", opt_input_file,
@@ -1045,7 +1161,7 @@ static void load_input_file_format(void)
 		exit(1);
 	}
 	in->format = input_format;
-	in->param = input_format_param;
+	in->param = fmtargs;
 	if (in->format->init) {
 		if (in->format->init(in) != SR_OK) {
 			g_critical("Input format init failed.");
@@ -1053,12 +1169,12 @@ static void load_input_file_format(void)
 		}
 	}
 
-	if (select_probes(in->vdev) > 0)
+	if (select_probes(in->sdi) > 0)
             return;
 
 	sr_session_new();
 	sr_session_datafeed_callback_add(datafeed_in);
-	if (sr_session_dev_add(in->vdev) != SR_OK) {
+	if (sr_session_dev_add(in->sdi) != SR_OK) {
 		g_critical("Failed to use device.");
 		sr_session_destroy();
 		return;
@@ -1066,10 +1182,13 @@ static void load_input_file_format(void)
 
 	input_format->loadfile(in, opt_input_file);
 	if (opt_output_file && default_output_format) {
-		if (sr_session_save(opt_output_file) != SR_OK)
+		if (sr_session_save(opt_output_file, in->sdi, singleds) != SR_OK)
 			g_critical("Failed to save session.");
 	}
 	sr_session_destroy();
+
+	if (fmtargs)
+		g_hash_table_destroy(fmtargs);
 }
 
 static void load_input_file(void)
@@ -1088,97 +1207,118 @@ static void load_input_file(void)
 	}
 }
 
-int num_real_devs(void)
-{
-	struct sr_dev *dev;
-	GSList *devs, *l;
-	int num_devs;
-
-	num_devs = 0;
-	devs = sr_dev_list();
-	for (l = devs; l; l = l->next) {
-		dev = l->data;
-		if (!sr_dev_has_hwcap(dev, SR_HWCAP_DEMO_DEV))
-			num_devs++;
-	}
-
-	return num_devs;
-}
-
-static int set_dev_options(struct sr_dev *dev, GHashTable *args)
+static int set_dev_options(struct sr_dev_inst *sdi, GHashTable *args)
 {
+	const struct sr_hwcap_option *hwo;
 	GHashTableIter iter;
 	gpointer key, value;
-	int ret, i;
+	int ret;
 	float tmp_float;
 	uint64_t tmp_u64;
 	struct sr_rational tmp_rat;
 	gboolean tmp_bool;
-	gboolean found;
+	void *val;
 
 	g_hash_table_iter_init(&iter, args);
 	while (g_hash_table_iter_next(&iter, &key, &value)) {
-		found = FALSE;
-		for (i = 0; sr_hwcap_options[i].hwcap; i++) {
-			if (strcmp(sr_hwcap_options[i].shortname, key))
-				continue;
-			if ((value == NULL) && 
-			    (sr_hwcap_options[i].type != SR_T_BOOL)) {
-				g_critical("Option '%s' needs a value.", (char *)key);
-				return SR_ERR;
-			}
-			found = TRUE;
-			switch (sr_hwcap_options[i].type) {
-			case SR_T_UINT64:
-				ret = sr_parse_sizestring(value, &tmp_u64);
-				if (ret != SR_OK)
-					break;
-				ret = dev->driver->dev_config_set(dev->driver_index,
-					sr_hwcap_options[i].hwcap, &tmp_u64);
-				break;
-			case SR_T_CHAR:
-				ret = dev->driver->dev_config_set(dev->driver_index,
-					sr_hwcap_options[i].hwcap, value);
-				break;
-			case SR_T_BOOL:
-				if (!value)
-					tmp_bool = TRUE;
-				else 
-					tmp_bool = sr_parse_boolstring(value);
-				ret = dev->driver->dev_config_set(dev->driver_index,
-						sr_hwcap_options[i].hwcap, 
-						GINT_TO_POINTER(tmp_bool));
-				break;
-			case SR_T_FLOAT:
-				tmp_float = strtof(value, NULL);
-				ret = dev->driver->dev_config_set(dev->driver_index,
-						sr_hwcap_options[i].hwcap, &tmp_float);
+		if (!(hwo = sr_devopt_name_get(key))) {
+			g_critical("Unknown device option '%s'.", (char *) key);
+			return SR_ERR;
+		}
+
+		if ((value == NULL) &&
+			(hwo->type != SR_T_BOOL)) {
+			g_critical("Option '%s' needs a value.", (char *)key);
+			return SR_ERR;
+		}
+		val = NULL;
+		switch (hwo->type) {
+		case SR_T_UINT64:
+			ret = sr_parse_sizestring(value, &tmp_u64);
+			if (ret != SR_OK)
 				break;
-			case SR_T_RATIONAL_PERIOD:
-				if ((ret = sr_parse_period(value, &tmp_rat)) != SR_OK)
-					break;
-				ret = dev->driver->dev_config_set(dev->driver_index,
-						sr_hwcap_options[i].hwcap, &tmp_rat);
+			val = &tmp_u64;
+			break;
+		case SR_T_CHAR:
+			val = value;
+			break;
+		case SR_T_BOOL:
+			if (!value)
+				tmp_bool = TRUE;
+			else
+				tmp_bool = sr_parse_boolstring(value);
+			val = &tmp_bool;
+			break;
+		case SR_T_FLOAT:
+			tmp_float = strtof(value, NULL);
+			val = &tmp_float;
+			break;
+		case SR_T_RATIONAL_PERIOD:
+			if ((ret = sr_parse_period(value, &tmp_rat)) != SR_OK)
 				break;
-			case SR_T_RATIONAL_VOLT:
-				if ((ret = sr_parse_voltage(value, &tmp_rat)) != SR_OK)
-					break;
-				ret = dev->driver->dev_config_set(dev->driver_index,
-						sr_hwcap_options[i].hwcap, &tmp_rat);
+			val = &tmp_rat;
+			break;
+		case SR_T_RATIONAL_VOLT:
+			if ((ret = sr_parse_voltage(value, &tmp_rat)) != SR_OK)
 				break;
-			default:
-				ret = SR_ERR;
-			}
+			val = &tmp_rat;
+			break;
+		default:
+			ret = SR_ERR;
+		}
+		if (val)
+			ret = sdi->driver->dev_config_set(sdi, hwo->hwcap, val);
+		if (ret != SR_OK) {
+			g_critical("Failed to set device option '%s'.", (char *)key);
+			return ret;
+		}
+		else
+			break;
+	}
 
-			if (ret != SR_OK) {
-				g_critical("Failed to set device option '%s'.", (char *)key);
-				return ret;
-			}
-			else
-				break;
+	return SR_OK;
+}
+
+static int set_limit_time(const struct sr_dev_inst *sdi)
+{
+	uint64_t time_msec;
+	uint64_t *samplerate;
+
+	time_msec = sr_parse_timestring(opt_time);
+	if (time_msec == 0) {
+		g_critical("Invalid time '%s'", opt_time);
+		sr_session_destroy();
+		return SR_ERR;
+	}
+
+	if (sr_driver_hwcap_exists(sdi->driver, SR_HWCAP_LIMIT_MSEC)) {
+		if (sdi->driver->dev_config_set(sdi,
+			SR_HWCAP_LIMIT_MSEC, &time_msec) != SR_OK) {
+			g_critical("Failed to configure time limit.");
+			sr_session_destroy();
+			return SR_ERR;
 		}
-		if (!found) {
-			g_critical("Unknown device option '%s'.", (char *) key);
+	}
+	else {
+		/* time limit set, but device doesn't support this...
+		 * convert to samples based on the samplerate.
+		 */
+		limit_samples = 0;
+		if (sr_dev_has_hwcap(sdi, SR_HWCAP_SAMPLERATE)) {
+			sr_info_get(sdi->driver, SR_DI_CUR_SAMPLERATE,
+					(const void **)&samplerate, sdi);
+			limit_samples = (*samplerate) * time_msec / (uint64_t)1000;
+		}
+		if (limit_samples == 0) {
+			g_critical("Not enough time at this samplerate.");
+			sr_session_destroy();
+			return SR_ERR;
+		}
+
+		if (sdi->driver->dev_config_set(sdi,
+			SR_HWCAP_LIMIT_SAMPLES, &limit_samples) != SR_OK) {
+			g_critical("Failed to configure time-based sample limit.");
+			sr_session_destroy();
 			return SR_ERR;
 		}
 	}
@@ -1188,129 +1328,87 @@ static int set_dev_options(struct sr_dev *dev, GHashTable *args)
 
 static void run_session(void)
 {
-	struct sr_dev *dev;
+	GSList *devices;
 	GHashTable *devargs;
-	int num_devs, max_probes, i;
-	uint64_t time_msec;
-	char **probelist, *devspec;
+	struct sr_dev_inst *sdi;
+	int max_probes, i;
+	char **triggerlist;
 
-	devargs = NULL;
-	if (opt_dev) {
-		devargs = parse_generic_arg(opt_dev);
-		devspec = g_hash_table_lookup(devargs, "sigrok_key");
-		dev = parse_devstring(devspec);
-		if (!dev) {
-			g_critical("Device not found.");
-			return;
-		}
-		g_hash_table_remove(devargs, "sigrok_key");
-	} else {
-		num_devs = num_real_devs();
-		if (num_devs == 1) {
-			/* No device specified, but there is only one. */
-			devargs = NULL;
-			dev = parse_devstring("0");
-		} else if (num_devs == 0) {
-			g_critical("No devices found.");
-			return;
-		} else {
-			g_critical("%d devices found, please select one.", num_devs);
-			return;
-		}
+	devices = device_scan();
+	if (!devices) {
+		g_critical("No devices found.");
+		return;
+	}
+	if (g_slist_length(devices) > 1) {
+		g_critical("sigrok-cli only supports one device for capturing.");
+		return;
 	}
+	sdi = devices->data;
 
 	sr_session_new();
 	sr_session_datafeed_callback_add(datafeed_in);
 
-	if (sr_session_dev_add(dev) != SR_OK) {
+	if (opt_dev) {
+		if ((devargs = parse_generic_arg(opt_dev, FALSE))) {
+			if (set_dev_options(sdi, devargs) != SR_OK)
+				return;
+			g_hash_table_destroy(devargs);
+		}
+	}
+
+	if (sr_session_dev_add(sdi) != SR_OK) {
 		g_critical("Failed to use device.");
 		sr_session_destroy();
 		return;
 	}
 
-	if (devargs) {
-		if (set_dev_options(dev, devargs) != SR_OK) {
+	if (select_probes(sdi) != SR_OK) {
+		g_critical("Failed to set probes.");
+		sr_session_destroy();
+		return;
+	}
+
+	if (opt_triggers) {
+		if (!(triggerlist = sr_parse_triggerstring(sdi, opt_triggers))) {
 			sr_session_destroy();
 			return;
 		}
-		g_hash_table_destroy(devargs);
+		max_probes = g_slist_length(sdi->probes);
+		for (i = 0; i < max_probes; i++) {
+			if (triggerlist[i]) {
+				sr_dev_trigger_set(sdi, i, triggerlist[i]);
+				g_free(triggerlist[i]);
+			}
+		}
+		g_free(triggerlist);
 	}
 
-	if (select_probes(dev) != SR_OK)
-            return;
+	if (sdi->driver->dev_config_set(sdi, SR_HWCAP_PROBECONFIG,
+			(char *)sdi->probes) != SR_OK) {
+		g_critical("Failed to configure probes.");
+		sr_session_destroy();
+		return;
+	}
 
 	if (opt_continuous) {
-		if (!sr_driver_hwcap_exists(dev->driver, SR_HWCAP_CONTINUOUS)) {
+		if (!sr_driver_hwcap_exists(sdi->driver, SR_HWCAP_CONTINUOUS)) {
 			g_critical("This device does not support continuous sampling.");
 			sr_session_destroy();
 			return;
 		}
 	}
 
-	if (opt_triggers) {
-		probelist = sr_parse_triggerstring(dev, opt_triggers);
-		if (!probelist) {
-			sr_session_destroy();
-			return;
-		}
-
-		max_probes = g_slist_length(dev->probes);
-		for (i = 0; i < max_probes; i++) {
-			if (probelist[i]) {
-				sr_dev_trigger_set(dev, i + 1, probelist[i]);
-				g_free(probelist[i]);
-			}
-		}
-		g_free(probelist);
-	}
-
 	if (opt_time) {
-		time_msec = sr_parse_timestring(opt_time);
-		if (time_msec == 0) {
-			g_critical("Invalid time '%s'", opt_time);
+		if (set_limit_time(sdi) != SR_OK) {
 			sr_session_destroy();
 			return;
 		}
-
-		if (sr_driver_hwcap_exists(dev->driver, SR_HWCAP_LIMIT_MSEC)) {
-			if (dev->driver->dev_config_set(dev->driver_index,
-			    SR_HWCAP_LIMIT_MSEC, &time_msec) != SR_OK) {
-				g_critical("Failed to configure time limit.");
-				sr_session_destroy();
-				return;
-			}
-		}
-		else {
-			/* time limit set, but device doesn't support this...
-			 * convert to samples based on the samplerate.
-			 */
-			limit_samples = 0;
-			if (sr_dev_has_hwcap(dev, SR_HWCAP_SAMPLERATE)) {
-				const uint64_t *samplerate;
-
-				sr_dev_info_get(dev, SR_DI_CUR_SAMPLERATE,
-						(const void **)&samplerate);
-				limit_samples = (*samplerate) * time_msec / (uint64_t)1000;
-			}
-			if (limit_samples == 0) {
-				g_critical("Not enough time at this samplerate.");
-				sr_session_destroy();
-				return;
-			}
-
-			if (dev->driver->dev_config_set(dev->driver_index,
-			    SR_HWCAP_LIMIT_SAMPLES, &limit_samples) != SR_OK) {
-				g_critical("Failed to configure time-based sample limit.");
-				sr_session_destroy();
-				return;
-			}
-		}
 	}
 
 	if (opt_samples) {
 		if ((sr_parse_sizestring(opt_samples, &limit_samples) != SR_OK)
-			|| (dev->driver->dev_config_set(dev->driver_index,
-			    SR_HWCAP_LIMIT_SAMPLES, &limit_samples) != SR_OK)) {
+				|| (sdi->driver->dev_config_set(sdi, SR_HWCAP_LIMIT_SAMPLES,
+						&limit_samples) != SR_OK)) {
 			g_critical("Failed to configure sample limit.");
 			sr_session_destroy();
 			return;
@@ -1319,21 +1417,14 @@ static void run_session(void)
 
 	if (opt_frames) {
 		if ((sr_parse_sizestring(opt_frames, &limit_frames) != SR_OK)
-			|| (dev->driver->dev_config_set(dev->driver_index,
+				|| (sdi->driver->dev_config_set(sdi,
 			    SR_HWCAP_LIMIT_FRAMES, &limit_frames) != SR_OK)) {
-			printf("Failed to configure frame limit.\n");
+			g_critical("Failed to configure frame limit.");
 			sr_session_destroy();
 			return;
 		}
 	}
 
-	if (dev->driver->dev_config_set(dev->driver_index,
-		  SR_HWCAP_PROBECONFIG, (char *)dev->probes) != SR_OK) {
-		g_critical("Failed to configure probes.");
-		sr_session_destroy();
-		return;
-	}
-
 	if (sr_session_start() != SR_OK) {
 		g_critical("Failed to start session.");
 		sr_session_destroy();
@@ -1349,10 +1440,12 @@ static void run_session(void)
 		clear_anykey();
 
 	if (opt_output_file && default_output_format) {
-		if (sr_session_save(opt_output_file) != SR_OK)
+		if (sr_session_save(opt_output_file, sdi, singleds) != SR_OK)
 			g_critical("Failed to save session.");
 	}
 	sr_session_destroy();
+	g_slist_free(devices);
+
 }
 
 static void logger(const gchar *log_domain, GLogLevelFlags log_level,
@@ -1421,14 +1514,14 @@ int main(int argc, char **argv)
 		show_version();
 	else if (opt_list_devs)
 		show_dev_list();
+	else if (opt_show)
+		show_dev_detail();
+	else if (opt_pds)
+		show_pd_detail();
 	else if (opt_input_file)
 		load_input_file();
 	else if (opt_samples || opt_time || opt_frames || opt_continuous)
 		run_session();
-	else if (opt_dev)
-		show_dev_detail();
-	else if (opt_pds)
-		show_pd_detail();
 	else
 		printf("%s", g_option_context_get_help(context, TRUE, NULL));