X-Git-Url: https://sigrok.org/gitweb/?p=sigrok-cli.git;a=blobdiff_plain;f=sigrok-cli.c;h=084e9d29ea422d3943f3e94cada8d1cfab869813;hp=1b967814508ed76d906a9474faecd75e84df9ae1;hb=de0a066e82c23971966752c8abb6ade5e8084008;hpb=19c3e1f40ab6e86017bf9771006a1711b4c496ff

diff --git a/sigrok-cli.c b/sigrok-cli.c
index 1b96781..084e9d2 100644
--- a/sigrok-cli.c
+++ b/sigrok-cli.c
@@ -17,7 +17,10 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+#include "config.h"
+#ifdef HAVE_SRD
 #include <sigrokdecode.h> /* First, so we avoid a _POSIX_C_SOURCE warning. */
+#endif
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
@@ -32,17 +35,20 @@
 #include <glib/gstdio.h>
 #include <libsigrok/libsigrok.h>
 #include "sigrok-cli.h"
-#include "config.h"
 
 #define DEFAULT_OUTPUT_FORMAT "bits:width=64"
 
+static struct sr_context *sr_ctx = NULL;
+
 static uint64_t limit_samples = 0;
 static uint64_t limit_frames = 0;
 static struct sr_output_format *output_format = NULL;
 static int default_output_format = FALSE;
 static char *output_format_param = NULL;
+#ifdef HAVE_SRD
 static GHashTable *pd_ann_visible = NULL;
-static struct sr_datastore *singleds = NULL;
+#endif
+static GByteArray *savebuf;
 
 static gboolean opt_version = FALSE;
 static gint opt_loglevel = SR_LOG_WARN; /* Show errors+warnings per default. */
@@ -55,8 +61,10 @@ static gchar *opt_dev = NULL;
 static gchar *opt_probes = NULL;
 static gchar *opt_triggers = NULL;
 static gchar *opt_pds = NULL;
+#ifdef HAVE_SRD
 static gchar *opt_pd_stack = NULL;
 static gchar *opt_pd_annotations = NULL;
+#endif
 static gchar *opt_input_format = NULL;
 static gchar *opt_output_format = NULL;
 static gchar *opt_show = NULL;
@@ -64,6 +72,7 @@ static gchar *opt_time = NULL;
 static gchar *opt_samples = NULL;
 static gchar *opt_frames = NULL;
 static gchar *opt_continuous = NULL;
+static gchar *opt_set = NULL;
 
 static GOptionEntry optargs[] = {
 	{"version", 'V', 0, G_OPTION_ARG_NONE, &opt_version,
@@ -90,12 +99,14 @@ static GOptionEntry optargs[] = {
 			"Trigger configuration", NULL},
 	{"wait-trigger", 'w', 0, G_OPTION_ARG_NONE, &opt_wait_trigger,
 			"Wait for trigger", NULL},
+#ifdef HAVE_SRD
 	{"protocol-decoders", 'a', 0, G_OPTION_ARG_STRING, &opt_pds,
 			"Protocol decoders to run", NULL},
 	{"protocol-decoder-stack", 's', 0, G_OPTION_ARG_STRING, &opt_pd_stack,
 			"Protocol decoder stack", NULL},
 	{"protocol-decoder-annotations", 'A', 0, G_OPTION_ARG_STRING, &opt_pd_annotations,
 			"Protocol decoder annotation(s) to show", NULL},
+#endif
 	{"show", 0, 0, G_OPTION_ARG_NONE, &opt_show,
 			"Show device detail", NULL},
 	{"time", 0, 0, G_OPTION_ARG_STRING, &opt_time,
@@ -106,15 +117,16 @@ static GOptionEntry optargs[] = {
 			"Number of frames to acquire", NULL},
 	{"continuous", 0, 0, G_OPTION_ARG_NONE, &opt_continuous,
 			"Sample continuously", NULL},
+	{"set", 0, 0, G_OPTION_ARG_NONE, &opt_set, "Set device options only", NULL},
 	{NULL, 0, 0, 0, NULL, NULL, NULL}
 };
 
 
-/* Convert driver options hash to GSList of struct sr_hwopt. */
+/* Convert driver options hash to GSList of struct sr_config. */
 static GSList *hash_to_hwopt(GHashTable *hash)
 {
-	const struct sr_hwcap_option *hwo;
-	struct sr_hwopt *hwopt;
+	const struct sr_config_info *srci;
+	struct sr_config *src;
 	GList *gl, *keys;
 	GSList *opts;
 	char *key, *value;
@@ -123,21 +135,27 @@ static GSList *hash_to_hwopt(GHashTable *hash)
 	opts = NULL;
 	for (gl = keys; gl; gl = gl->next) {
 		key = gl->data;
-		if (!(hwo = sr_drvopt_name_get(key))) {
+		if (!(srci = sr_config_info_name_get(key))) {
 			g_critical("Unknown option %s", key);
 			return NULL;
 		}
-		hwopt = g_try_malloc(sizeof(struct sr_hwopt));
-		hwopt->hwopt = hwo->hwcap;
+		src = g_try_malloc(sizeof(struct sr_config));
+		src->key = srci->key;
 		value = g_hash_table_lookup(hash, key);
-		hwopt->value = g_strdup(value);
-		opts = g_slist_append(opts, hwopt);
+		src->value = g_strdup(value);
+		opts = g_slist_append(opts, src);
 	}
 	g_list_free(keys);
 
 	return opts;
 }
 
+static void free_drvopts(struct sr_config *src)
+{
+	g_free((void *)src->value);
+	g_free(src);
+}
+
 static GSList *device_scan(void)
 {
 	struct sr_dev_driver **drivers, *driver;
@@ -162,7 +180,7 @@ static GSList *device_scan(void)
 			return NULL;
 		}
 		g_free(drvname);
-		if (sr_driver_init(driver) != SR_OK) {
+		if (sr_driver_init(sr_ctx, driver) != SR_OK) {
 			g_critical("Failed to initialize driver.");
 			return NULL;
 		}
@@ -172,13 +190,14 @@ static GSList *device_scan(void)
 				/* Unknown options, already logged. */
 				return NULL;
 		devices = sr_driver_scan(driver, drvopts);
+		g_slist_free_full(drvopts, (GDestroyNotify)free_drvopts);
 	} else {
 		/* No driver specified, let them all scan on their own. */
 		devices = NULL;
 		drivers = sr_driver_list();
 		for (i = 0; drivers[i]; i++) {
 			driver = drivers[i];
-			if (sr_driver_init(driver) != SR_OK) {
+			if (sr_driver_init(sr_ctx, driver) != SR_OK) {
 				g_critical("Failed to initialize driver.");
 				return NULL;
 			}
@@ -194,19 +213,23 @@ static GSList *device_scan(void)
 
 static void show_version(void)
 {
-	GSList *l;
 	struct sr_dev_driver **drivers;
 	struct sr_input_format **inputs;
 	struct sr_output_format **outputs;
-	struct srd_decoder *dec;
 	int i;
+#ifdef HAVE_SRD
+	struct srd_decoder *dec;
+	const GSList *l;
+#endif
 
 	printf("sigrok-cli %s\n\n", VERSION);
 
 	printf("Using libsigrok %s (lib version %s).\n",
 	       sr_package_version_string_get(), sr_lib_version_string_get());
+#ifdef HAVE_SRD
 	printf("Using libsigrokdecode %s (lib version %s).\n\n",
 	       srd_package_version_string_get(), srd_lib_version_string_get());
+#endif
 
 	printf("Supported hardware drivers:\n");
 	drivers = sr_driver_list();
@@ -227,6 +250,7 @@ static void show_version(void)
 		printf("  %-20s %s\n", outputs[i]->id, outputs[i]->description);
 	printf("\n");
 
+#ifdef HAVE_SRD
 	if (srd_init(NULL) == SRD_OK) {
 		printf("Supported protocol decoders:\n");
 		srd_decoder_load_all();
@@ -240,10 +264,13 @@ static void show_version(void)
 		srd_exit();
 	}
 	printf("\n");
+#endif
 }
 
 static void print_dev_line(const struct sr_dev_inst *sdi)
 {
+	struct sr_probe *probe;
+	GSList *l;
 
 	if (sdi->vendor && sdi->vendor[0])
 		printf("%s ", sdi->vendor);
@@ -251,8 +278,18 @@ static void print_dev_line(const struct sr_dev_inst *sdi)
 		printf("%s ", sdi->model);
 	if (sdi->version && sdi->version[0])
 		printf("%s ", sdi->version);
-	if (sdi->probes)
-		printf("with %d probes", g_slist_length(sdi->probes));
+	if (sdi->probes) {
+		if (g_slist_length(sdi->probes) == 1) {
+			probe = sdi->probes->data;
+			printf("with 1 probe: %s", probe->name);
+		} else {
+			printf("with %d probes:", g_slist_length(sdi->probes));
+			for (l = sdi->probes; l; l = l->next) {
+				probe = l->data;
+				printf(" %s", probe->name);
+			}
+		}
+	}
 	printf("\n");
 }
 
@@ -276,13 +313,13 @@ static void show_dev_list(void)
 static void show_dev_detail(void)
 {
 	struct sr_dev_inst *sdi;
-	const struct sr_hwcap_option *hwo;
+	const struct sr_config_info *srci;
 	const struct sr_samplerates *samplerates;
 	struct sr_rational *rationals;
 	GSList *devices;
 	uint64_t *integers;
 	const int *hwopts, *hwcaps;
-	int cap, num_devices, n, i;
+	int cap, num_devices, *tmp_bool, i;
 	char *s, *title;
 	const char *charopts, **stropts;
 
@@ -293,25 +330,23 @@ static void show_dev_detail(void)
 
 	num_devices = g_slist_length(devices);
 	if (num_devices > 1) {
-		if (!opt_dev) {
-			g_critical("%d devices found. Use --list-devices to show them, "
-					"and --device to select one.", num_devices);
-			return;
-		}
-		/* opt_dev is NULL if not specified, which is fine. */
-		n = strtol(opt_dev, NULL, 10);
-		if (n >= num_devices) {
-			g_critical("%d devices found, numbered starting from 0.",
-					num_devices);
-			return;
-		}
-		sdi = g_slist_nth_data(devices, n);
-	} else
-		sdi = g_slist_nth_data(devices, 0);
+		g_critical("%d devices found. Use --list-devices to show them, "
+				"and --device to select one.", num_devices);
+		return;
+	}
 
+	sdi = devices->data;
 	print_dev_line(sdi);
 
-	if (sr_info_get(sdi->driver, SR_DI_TRIGGER_TYPES, (const void **)&charopts,
+	/* This properly opens and initializes the device, so we can get
+	 * current settings. */
+	sr_session_new();
+	if (sr_session_dev_add(sdi) != SR_OK) {
+		g_critical("Failed to use device.");
+		return;
+	}
+
+	if (sr_config_list(sdi->driver, SR_CONF_TRIGGER_TYPE, (const void **)&charopts,
 			sdi) == SR_OK && charopts) {
 		printf("Supported triggers: ");
 		while (*charopts) {
@@ -321,24 +356,24 @@ static void show_dev_detail(void)
 		printf("\n");
 	}
 
-	if ((sr_info_get(sdi->driver, SR_DI_HWOPTS, (const void **)&hwopts,
+	if ((sr_config_list(sdi->driver, SR_CONF_SCAN_OPTIONS, (const void **)&hwopts,
 			NULL) == SR_OK) && hwopts) {
 		printf("Supported driver options:\n");
 		for (i = 0; hwopts[i]; i++) {
-			if (!(hwo = sr_drvopt_get(hwopts[i])))
+			if (!(srci = sr_config_info_get(hwopts[i])))
 				continue;
-			printf("    %s\n", hwo->shortname);
+			printf("    %s\n", srci->id);
 		}
 	}
 
 	title = "Supported device options:\n";
-	if ((sr_info_get(sdi->driver, SR_DI_HWCAPS, (const void **)&hwcaps,
+	if ((sr_config_list(sdi->driver, SR_CONF_DEVICE_OPTIONS, (const void **)&hwcaps,
 			NULL) != SR_OK) || !hwcaps)
 		/* Driver supports no device instance options. */
 		return;
 
 	for (cap = 0; hwcaps[cap]; cap++) {
-		if (!(hwo = sr_devopt_get(hwcaps[cap])))
+		if (!(srci = sr_config_info_get(hwcaps[cap])))
 			continue;
 
 		if (title) {
@@ -346,10 +381,10 @@ static void show_dev_detail(void)
 			title = NULL;
 		}
 
-		if (hwo->hwcap == SR_HWCAP_PATTERN_MODE) {
+		if (srci->key == SR_CONF_PATTERN_MODE) {
 			/* Pattern generator modes */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_PATTERNS,
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_PATTERN_MODE,
 					(const void **)&stropts, sdi) == SR_OK) {
 				printf(" - supported patterns:\n");
 				for (i = 0; stropts[i]; i++)
@@ -358,10 +393,10 @@ static void show_dev_detail(void)
 				printf("\n");
 			}
 
-		} else if (hwo->hwcap == SR_HWCAP_SAMPLERATE) {
+		} else if (srci->key == SR_CONF_SAMPLERATE) {
 			/* Supported samplerates */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_SAMPLERATES,
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_SAMPLERATE,
 					(const void **)&samplerates, sdi) != SR_OK) {
 				printf("\n");
 				continue;
@@ -388,10 +423,10 @@ static void show_dev_detail(void)
 					printf("      %s\n", sr_samplerate_string(samplerates->list[i]));
 			}
 
-		} else if (hwo->hwcap == SR_HWCAP_BUFFERSIZE) {
+		} else if (srci->key == SR_CONF_BUFFERSIZE) {
 			/* Supported buffer sizes */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_BUFFERSIZES,
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_BUFFERSIZE,
 					(const void **)&integers, sdi) != SR_OK) {
 				printf("\n");
 				continue;
@@ -400,10 +435,10 @@ static void show_dev_detail(void)
 			for (i = 0; integers[i]; i++)
 				printf("      %"PRIu64"\n", integers[i]);
 
-		} else if (hwo->hwcap == SR_HWCAP_TIMEBASE) {
+		} else if (srci->key == SR_CONF_TIMEBASE) {
 			/* Supported time bases */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_TIMEBASES,
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_TIMEBASE,
 					(const void **)&rationals, sdi) != SR_OK) {
 				printf("\n");
 				continue;
@@ -413,10 +448,10 @@ static void show_dev_detail(void)
 				printf("      %s\n", sr_period_string(
 						rationals[i].p * rationals[i].q));
 
-		} else if (hwo->hwcap == SR_HWCAP_TRIGGER_SOURCE) {
+		} else if (srci->key == SR_CONF_TRIGGER_SOURCE) {
 			/* Supported trigger sources */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_TRIGGER_SOURCES,
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_TRIGGER_SOURCE,
 					(const void **)&stropts, sdi) != SR_OK) {
 				printf("\n");
 				continue;
@@ -425,10 +460,10 @@ static void show_dev_detail(void)
 			for (i = 0; stropts[i]; i++)
 				printf("      %s\n", stropts[i]);
 
-		} else if (hwo->hwcap == SR_HWCAP_FILTER) {
-			/* Supported trigger sources */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_FILTERS,
+		} else if (srci->key == SR_CONF_FILTER) {
+			/* Supported filters */
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_FILTER,
 					(const void **)&stropts, sdi) != SR_OK) {
 				printf("\n");
 				continue;
@@ -437,10 +472,10 @@ static void show_dev_detail(void)
 			for (i = 0; stropts[i]; i++)
 				printf("      %s\n", stropts[i]);
 
-		} else if (hwo->hwcap == SR_HWCAP_VDIV) {
+		} else if (srci->key == SR_CONF_VDIV) {
 			/* Supported volts/div values */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_VDIVS,
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_VDIV,
 					(const void **)&rationals, sdi) != SR_OK) {
 				printf("\n");
 				continue;
@@ -449,10 +484,10 @@ static void show_dev_detail(void)
 			for (i = 0; rationals[i].p && rationals[i].q; i++)
 				printf("      %s\n", sr_voltage_string(	&rationals[i]));
 
-		} else if (hwo->hwcap == SR_HWCAP_COUPLING) {
+		} else if (srci->key == SR_CONF_COUPLING) {
 			/* Supported coupling settings */
-			printf("    %s", hwo->shortname);
-			if (sr_info_get(sdi->driver, SR_DI_COUPLING,
+			printf("    %s", srci->id);
+			if (sr_config_list(sdi->driver, SR_CONF_COUPLING,
 					(const void **)&stropts, sdi) != SR_OK) {
 				printf("\n");
 				continue;
@@ -461,14 +496,25 @@ static void show_dev_detail(void)
 			for (i = 0; stropts[i]; i++)
 				printf("      %s\n", stropts[i]);
 
+		} else if (srci->key == SR_CONF_DATALOG) {
+			/* Turning on/off internal data logging. */
+			printf("    %s\t(on/off", srci->id);
+			if (sr_config_get(sdi->driver, SR_CONF_DATALOG,
+						(const void **)&tmp_bool, sdi) == SR_OK) {
+				printf(", currently %s", *tmp_bool ? "on" : "off");
+			}
+			printf(")\n");
 		} else {
 			/* Everything else */
-			printf("    %s\n", hwo->shortname);
+			printf("    %s\n", srci->id);
 		}
 	}
 
+	sr_session_destroy();
+
 }
 
+#ifdef HAVE_SRD
 static void show_pd_detail(void)
 {
 	GSList *l;
@@ -524,27 +570,45 @@ static void show_pd_detail(void)
 
 	g_strfreev(pdtokens);
 }
+#endif
+
+static GArray *get_enabled_logic_probes(const struct sr_dev_inst *sdi)
+{
+	struct sr_probe *probe;
+	GArray *probes;
+	GSList *l;
+
+	probes = g_array_new(FALSE, FALSE, sizeof(int));
+	for (l = sdi->probes; l; l = l->next) {
+		probe = l->data;
+		if (probe->type != SR_PROBE_LOGIC)
+			continue;
+		if (probe->enabled != TRUE)
+			continue;
+		g_array_append_val(probes, probe->index);
+	}
+
+	return probes;
+}
 
 static void datafeed_in(const struct sr_dev_inst *sdi,
-		struct sr_datafeed_packet *packet)
+		const struct sr_datafeed_packet *packet)
 {
+	const struct sr_datafeed_meta *meta;
+	const struct sr_datafeed_logic *logic;
+	const struct sr_datafeed_analog *analog;
+	struct sr_config *src;
 	static struct sr_output *o = NULL;
-	static int logic_probelist[SR_MAX_NUM_PROBES] = { -1 };
-	static struct sr_probe *analog_probelist[SR_MAX_NUM_PROBES];
+	static GArray *logic_probelist = NULL;
 	static uint64_t received_samples = 0;
 	static int unitsize = 0;
 	static int triggered = 0;
 	static FILE *outfile = NULL;
-	static int num_analog_probes = 0;
-	struct sr_probe *probe;
-	struct sr_datafeed_logic *logic;
-	struct sr_datafeed_meta_logic *meta_logic;
-	struct sr_datafeed_analog *analog;
-	struct sr_datafeed_meta_analog *meta_analog;
-	static int num_enabled_analog_probes = 0;
-	int num_enabled_probes, sample_size, ret, i;
-	uint64_t output_len, filter_out_len;
+	int sample_size, ret;
+	uint64_t *samplerate, output_len, filter_out_len;
 	uint8_t *output_buf, *filter_out;
+	GString *out;
+	GSList *l;
 
 	/* If the first packet to come in isn't a header, don't even try. */
 	if (packet->type != SR_DF_HEADER && o == NULL)
@@ -568,77 +632,65 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
 				exit(1);
 			}
 		}
-		break;
-
-	case SR_DF_END:
-		g_debug("cli: Received SR_DF_END");
-		if (!o) {
-			g_debug("cli: double end!");
-			break;
-		}
-		if (o->format->event) {
-			o->format->event(o, SR_DF_END, &output_buf, &output_len);
-			if (output_buf) {
-				if (outfile)
-					fwrite(output_buf, 1, output_len, outfile);
-				g_free(output_buf);
-				output_len = 0;
-			}
-		}
-		if (limit_samples && received_samples < limit_samples)
-			g_warning("Device only sent %" PRIu64 " samples.",
-			       received_samples);
-		if (opt_continuous)
-			g_warning("Device stopped after %" PRIu64 " samples.",
-			       received_samples);
-		if (outfile && outfile != stdout)
-			fclose(outfile);
-		g_free(o);
-		o = NULL;
-		break;
-
-	case SR_DF_TRIGGER:
-		g_debug("cli: received SR_DF_TRIGGER");
-		if (o->format->event)
-			o->format->event(o, SR_DF_TRIGGER, &output_buf,
-					 &output_len);
-		triggered = 1;
-		break;
-
-	case SR_DF_META_LOGIC:
-		g_message("cli: Received SR_DF_META_LOGIC");
-		meta_logic = packet->payload;
-		num_enabled_probes = 0;
-		for (i = 0; i < meta_logic->num_probes; i++) {
-			probe = g_slist_nth_data(sdi->probes, i);
-			if (probe->enabled)
-				logic_probelist[num_enabled_probes++] = probe->index;
-		}
-		logic_probelist[num_enabled_probes] = -1;
-		/* How many bytes we need to store num_enabled_probes bits */
-		unitsize = (num_enabled_probes + 7) / 8;
 
+		/* Prepare non-stdout output. */
 		outfile = stdout;
 		if (opt_output_file) {
 			if (default_output_format) {
-				/* output file is in session format, which means we'll
-				 * dump everything in the datastore as it comes in,
+				/* output file is in session format, so we'll
+				 * keep a copy of everything as it comes in
 				 * and save from there after the session. */
 				outfile = NULL;
-				ret = sr_datastore_new(unitsize, &singleds);
-				if (ret != SR_OK) {
-					g_critical("Failed to create datastore.");
-					exit(1);
-				}
+				savebuf = g_byte_array_new();
 			} else {
 				/* saving to a file in whatever format was set
 				 * with --format, so all we need is a filehandle */
 				outfile = g_fopen(opt_output_file, "wb");
 			}
 		}
-		if (opt_pds)
-			srd_session_start(num_enabled_probes, unitsize,
-					meta_logic->samplerate);
+
+		/* Prepare for logic data. */
+		logic_probelist = get_enabled_logic_probes(sdi);
+		/* How many bytes we need to store the packed samples. */
+		unitsize = (logic_probelist->len + 7) / 8;
+
+#ifdef HAVE_SRD
+		if (opt_pds && logic_probelist->len) {
+			if (sr_config_get(sdi->driver, SR_CONF_SAMPLERATE,
+					(const void **)&samplerate, sdi) != SR_OK) {
+				g_critical("Unable to initialize protocol "
+						"decoders: no samplerate found.");
+				break;
+			}
+			srd_session_start(logic_probelist->len, unitsize,
+					*samplerate);
+		}
+#endif
+		break;
+
+	case SR_DF_META:
+		g_debug("cli: received SR_DF_META");
+		meta = packet->payload;
+		for (l = meta->config; l; l = l->next) {
+			src = l->data;
+			switch (src->key) {
+			case SR_CONF_SAMPLERATE:
+				samplerate = (uint64_t *)src->value;
+				g_debug("cli: got samplerate %"PRIu64, *samplerate);
+				break;
+			default:
+				/* Unknown metadata is not an error. */
+				break;
+			}
+		}
+		break;
+
+	case SR_DF_TRIGGER:
+		g_debug("cli: received SR_DF_TRIGGER");
+		if (o->format->event)
+			o->format->event(o, SR_DF_TRIGGER, &output_buf,
+					 &output_len);
+		triggered = 1;
 		break;
 
 	case SR_DF_LOGIC:
@@ -661,7 +713,7 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
 		if (ret != SR_OK)
 			break;
 
-		/* what comes out of the filter is guaranteed to be packed into the
+		/* What comes out of the filter is guaranteed to be packed into the
 		 * minimum size needed to support the number of samples at this sample
 		 * size. however, the driver may have submitted too much -- cut off
 		 * the buffer of the last packet according to the sample limit.
@@ -670,64 +722,31 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
 				limit_samples * sample_size))
 			filter_out_len = limit_samples * sample_size - received_samples;
 
-		if (singleds)
-			sr_datastore_put(singleds, filter_out,
-					filter_out_len, sample_size, logic_probelist);
-
-		if (opt_output_file && default_output_format)
-			/* saving to a session file, don't need to do anything else
-			 * to this data for now. */
-			goto cleanup;
-
-		if (opt_pds) {
-			if (srd_session_send(received_samples, (uint8_t*)filter_out,
-					filter_out_len) != SRD_OK)
-				sr_session_stop();
+		if (opt_output_file && default_output_format) {
+			/* Saving to a session file. */
+			g_byte_array_append(savebuf, filter_out, filter_out_len);
 		} else {
-			output_len = 0;
-			if (o->format->data && packet->type == o->format->df_type)
-				o->format->data(o, filter_out, filter_out_len, &output_buf, &output_len);
-			if (output_buf) {
-				fwrite(output_buf, 1, output_len, outfile);
-				fflush(outfile);
-				g_free(output_buf);
+			if (opt_pds) {
+#ifdef HAVE_SRD
+				if (srd_session_send(received_samples, (uint8_t*)filter_out,
+						filter_out_len) != SRD_OK)
+					sr_session_stop();
+#endif
+			} else {
+				output_len = 0;
+				if (o->format->data && packet->type == o->format->df_type)
+					o->format->data(o, filter_out, filter_out_len,
+							&output_buf, &output_len);
+				if (output_len) {
+					fwrite(output_buf, 1, output_len, outfile);
+					fflush(outfile);
+					g_free(output_buf);
+				}
 			}
 		}
-
-		cleanup:
 		g_free(filter_out);
-		received_samples += logic->length / sample_size;
-		break;
 
-	case SR_DF_META_ANALOG:
-		g_message("cli: Received SR_DF_META_ANALOG");
-		meta_analog = packet->payload;
-		num_analog_probes = meta_analog->num_probes;
-		num_enabled_analog_probes = 0;
-		for (i = 0; i < num_analog_probes; i++) {
-			probe = g_slist_nth_data(sdi->probes, i);
-			if (probe->enabled)
-				analog_probelist[num_enabled_analog_probes++] = probe;
-		}
-
-		outfile = stdout;
-		if (opt_output_file) {
-			if (default_output_format) {
-				/* output file is in session format, which means we'll
-				 * dump everything in the datastore as it comes in,
-				 * and save from there after the session. */
-				outfile = NULL;
-				ret = sr_datastore_new(unitsize, &singleds);
-				if (ret != SR_OK) {
-					g_critical("Failed to create datastore.");
-					exit(1);
-				}
-			} else {
-				/* saving to a file in whatever format was set
-				 * with --format, so all we need is a filehandle */
-				outfile = g_fopen(opt_output_file, "wb");
-			}
-		}
+		received_samples += logic->length / sample_size;
 		break;
 
 	case SR_DF_ANALOG:
@@ -780,11 +799,61 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
 		break;
 
 	default:
-		g_message("received unknown packet type %d", packet->type);
+		break;
+	}
+
+	if (o && o->format->recv) {
+		out = o->format->recv(o, sdi, packet);
+		if (out && out->len) {
+			fwrite(out->str, 1, out->len, outfile);
+			fflush(outfile);
+		}
+	}
+
+	/* SR_DF_END needs to be handled after the output module's recv()
+	 * is called, so it can properly clean up that module etc. */
+	if (packet->type == SR_DF_END) {
+		g_debug("cli: Received SR_DF_END");
+
+		if (o->format->event) {
+			o->format->event(o, SR_DF_END, &output_buf, &output_len);
+			if (output_buf) {
+				if (outfile)
+					fwrite(output_buf, 1, output_len, outfile);
+				g_free(output_buf);
+				output_len = 0;
+			}
+		}
+
+		if (limit_samples && received_samples < limit_samples)
+			g_warning("Device only sent %" PRIu64 " samples.",
+			       received_samples);
+
+		if (opt_continuous)
+			g_warning("Device stopped after %" PRIu64 " samples.",
+			       received_samples);
+
+		g_array_free(logic_probelist, TRUE);
+
+		if (o->format->cleanup)
+			o->format->cleanup(o);
+		g_free(o);
+		o = NULL;
+
+		if (outfile && outfile != stdout)
+			fclose(outfile);
+
+		if (opt_output_file && default_output_format) {
+			if (sr_session_save(opt_output_file, sdi, savebuf->data,
+					unitsize, savebuf->len / unitsize) != SR_OK)
+				g_critical("Failed to save session.");
+			g_byte_array_free(savebuf, FALSE);
+		}
 	}
 
 }
 
+#ifdef HAVE_SRD
 /* Register the given PDs for this session.
  * Accepts a string of the form: "spi:sck=3:sdata=4,spi:sck=3:sdata=5"
  * That will instantiate two SPI decoders on the clock but different data
@@ -797,7 +866,6 @@ static int register_pds(struct sr_dev *dev, const char *pdstring)
 	int ret;
 	char **pdtokens, **pdtok, *pd_name;
 
-	/* Avoid compiler warnings. */
 	(void)dev;
 
 	ret = 0;
@@ -958,6 +1026,38 @@ int setup_pd_annotations(void)
 	return 0;
 }
 
+void show_pd_annotations(struct srd_proto_data *pdata, void *cb_data)
+{
+	int i;
+	char **annotations;
+	gpointer ann_format;
+
+	/* 'cb_data' is not used in this specific callback. */
+	(void)cb_data;
+
+	if (!pd_ann_visible)
+		return;
+
+	if (!g_hash_table_lookup_extended(pd_ann_visible, pdata->pdo->di->inst_id,
+			NULL, &ann_format))
+		/* Not in the list of PDs whose annotations we're showing. */
+		return;
+
+	if (pdata->ann_format != GPOINTER_TO_INT(ann_format))
+		/* We don't want this particular format from the PD. */
+		return;
+
+	annotations = pdata->data;
+	if (opt_loglevel > SR_LOG_WARN)
+		printf("%"PRIu64"-%"PRIu64" ", pdata->start_sample, pdata->end_sample);
+	printf("%s: ", pdata->pdo->proto_id);
+	for (i = 0; annotations[i]; i++)
+		printf("\"%s\" ", annotations[i]);
+	printf("\n");
+	fflush(stdout);
+}
+#endif
+
 int setup_output_format(void)
 {
 	GHashTable *fmtargs;
@@ -1005,64 +1105,25 @@ int setup_output_format(void)
 	return 0;
 }
 
-void show_pd_annotations(struct srd_proto_data *pdata, void *cb_data)
-{
-	int i;
-	char **annotations;
-	gpointer ann_format;
-
-	/* 'cb_data' is not used in this specific callback. */
-	(void)cb_data;
-
-	if (!pd_ann_visible)
-		return;
-
-	if (!g_hash_table_lookup_extended(pd_ann_visible, pdata->pdo->di->inst_id,
-			NULL, &ann_format))
-		/* Not in the list of PDs whose annotations we're showing. */
-		return;
-
-	if (pdata->ann_format != GPOINTER_TO_INT(ann_format))
-		/* We don't want this particular format from the PD. */
-		return;
-
-	annotations = pdata->data;
-	if (opt_loglevel > SR_LOG_WARN)
-		printf("%"PRIu64"-%"PRIu64" ", pdata->start_sample, pdata->end_sample);
-	printf("%s: ", pdata->pdo->proto_id);
-	for (i = 0; annotations[i]; i++)
-		printf("\"%s\" ", annotations[i]);
-	printf("\n");
-	fflush(stdout);
-}
-
 static int select_probes(struct sr_dev_inst *sdi)
 {
-	char **probelist;
-	int max_probes, i;
+	struct sr_probe *probe;
+	GSList *selected_probes, *l;
 
 	if (!opt_probes)
 		return SR_OK;
 
-	/*
-	 * This only works because a device by default initializes
-	 * and enables all its probes.
-	 */
-	max_probes = g_slist_length(sdi->probes);
-	probelist = parse_probestring(max_probes, opt_probes);
-	if (!probelist) {
+	if (!(selected_probes = parse_probestring(sdi, opt_probes)))
 		return SR_ERR;
-	}
 
-	for (i = 0; i < max_probes; i++) {
-		if (probelist[i]) {
-			sr_dev_probe_name_set(sdi, i, probelist[i]);
-			g_free(probelist[i]);
-		} else {
-			sr_dev_probe_enable(sdi, i, FALSE);
-		}
+	for (l = sdi->probes; l; l = l->next) {
+		probe = l->data;
+		if (g_slist_find(selected_probes, probe))
+			probe->enabled = TRUE;
+		else
+			probe->enabled = FALSE;
 	}
-	g_free(probelist);
+	g_slist_free(selected_probes);
 
 	return SR_OK;
 }
@@ -1162,14 +1223,14 @@ static void load_input_file_format(void)
 	in->format = input_format;
 	in->param = fmtargs;
 	if (in->format->init) {
-		if (in->format->init(in) != SR_OK) {
+		if (in->format->init(in, opt_input_file) != SR_OK) {
 			g_critical("Input format init failed.");
 			exit(1);
 		}
 	}
 
 	if (select_probes(in->sdi) > 0)
-            return;
+		return;
 
 	sr_session_new();
 	sr_session_datafeed_callback_add(datafeed_in);
@@ -1180,10 +1241,7 @@ static void load_input_file_format(void)
 	}
 
 	input_format->loadfile(in, opt_input_file);
-	if (opt_output_file && default_output_format) {
-		if (sr_session_save(opt_output_file, in->sdi, singleds) != SR_OK)
-			g_critical("Failed to save session.");
-	}
+
 	sr_session_destroy();
 
 	if (fmtargs)
@@ -1208,7 +1266,7 @@ static void load_input_file(void)
 
 static int set_dev_options(struct sr_dev_inst *sdi, GHashTable *args)
 {
-	const struct sr_hwcap_option *hwo;
+	const struct sr_config_info *srci;
 	GHashTableIter iter;
 	gpointer key, value;
 	int ret;
@@ -1220,18 +1278,18 @@ static int set_dev_options(struct sr_dev_inst *sdi, GHashTable *args)
 
 	g_hash_table_iter_init(&iter, args);
 	while (g_hash_table_iter_next(&iter, &key, &value)) {
-		if (!(hwo = sr_devopt_name_get(key))) {
+		if (!(srci = sr_config_info_name_get(key))) {
 			g_critical("Unknown device option '%s'.", (char *) key);
 			return SR_ERR;
 		}
 
 		if ((value == NULL) &&
-			(hwo->type != SR_T_BOOL)) {
+			(srci->datatype != SR_T_BOOL)) {
 			g_critical("Option '%s' needs a value.", (char *)key);
 			return SR_ERR;
 		}
 		val = NULL;
-		switch (hwo->type) {
+		switch (srci->datatype) {
 		case SR_T_UINT64:
 			ret = sr_parse_sizestring(value, &tmp_u64);
 			if (ret != SR_OK)
@@ -1266,18 +1324,50 @@ static int set_dev_options(struct sr_dev_inst *sdi, GHashTable *args)
 			ret = SR_ERR;
 		}
 		if (val)
-			ret = sr_dev_config_set(sdi, hwo->hwcap, val);
+			ret = sr_config_set(sdi, srci->key, val);
 		if (ret != SR_OK) {
 			g_critical("Failed to set device option '%s'.", (char *)key);
 			return ret;
 		}
-		else
-			break;
 	}
 
 	return SR_OK;
 }
 
+static void set_options(void)
+{
+	struct sr_dev_inst *sdi;
+	GSList *devices;
+	GHashTable *devargs;
+
+	if (!opt_dev) {
+		g_critical("No setting specified.");
+		return;
+	}
+
+	if (!(devargs = parse_generic_arg(opt_dev, FALSE)))
+		return;
+
+	if (!(devices = device_scan())) {
+		g_critical("No devices found.");
+		return;
+	}
+	sdi = devices->data;
+
+	sr_session_new();
+	if (sr_session_dev_add(sdi) != SR_OK) {
+		g_critical("Failed to use device.");
+		return;
+	}
+
+	set_dev_options(sdi, devargs);
+
+	sr_session_destroy();
+	g_slist_free(devices);
+	g_hash_table_destroy(devargs);
+
+}
+
 static int set_limit_time(const struct sr_dev_inst *sdi)
 {
 	uint64_t time_msec;
@@ -1290,8 +1380,8 @@ static int set_limit_time(const struct sr_dev_inst *sdi)
 		return SR_ERR;
 	}
 
-	if (sr_driver_hwcap_exists(sdi->driver, SR_HWCAP_LIMIT_MSEC)) {
-		if (sr_dev_config_set(sdi, SR_HWCAP_LIMIT_MSEC, &time_msec) != SR_OK) {
+	if (sr_dev_has_option(sdi, SR_CONF_LIMIT_MSEC)) {
+		if (sr_config_set(sdi, SR_CONF_LIMIT_MSEC, &time_msec) != SR_OK) {
 			g_critical("Failed to configure time limit.");
 			sr_session_destroy();
 			return SR_ERR;
@@ -1302,8 +1392,8 @@ static int set_limit_time(const struct sr_dev_inst *sdi)
 		 * convert to samples based on the samplerate.
 		 */
 		limit_samples = 0;
-		if (sr_dev_has_hwcap(sdi, SR_HWCAP_SAMPLERATE)) {
-			sr_info_get(sdi->driver, SR_DI_CUR_SAMPLERATE,
+		if (sr_dev_has_option(sdi, SR_CONF_SAMPLERATE)) {
+			sr_config_get(sdi->driver, SR_CONF_SAMPLERATE,
 					(const void **)&samplerate, sdi);
 			limit_samples = (*samplerate) * time_msec / (uint64_t)1000;
 		}
@@ -1313,7 +1403,7 @@ static int set_limit_time(const struct sr_dev_inst *sdi)
 			return SR_ERR;
 		}
 
-		if (sr_dev_config_set(sdi, SR_HWCAP_LIMIT_SAMPLES,
+		if (sr_config_set(sdi, SR_CONF_LIMIT_SAMPLES,
 					&limit_samples) != SR_OK) {
 			g_critical("Failed to configure time-based sample limit.");
 			sr_session_destroy();
@@ -1382,7 +1472,7 @@ static void run_session(void)
 	}
 
 	if (opt_continuous) {
-		if (!sr_driver_hwcap_exists(sdi->driver, SR_HWCAP_CONTINUOUS)) {
+		if (!sr_dev_has_option(sdi, SR_CONF_CONTINUOUS)) {
 			g_critical("This device does not support continuous sampling.");
 			sr_session_destroy();
 			return;
@@ -1398,7 +1488,7 @@ static void run_session(void)
 
 	if (opt_samples) {
 		if ((sr_parse_sizestring(opt_samples, &limit_samples) != SR_OK)
-				|| (sr_dev_config_set(sdi, SR_HWCAP_LIMIT_SAMPLES,
+				|| (sr_config_set(sdi, SR_CONF_LIMIT_SAMPLES,
 						&limit_samples) != SR_OK)) {
 			g_critical("Failed to configure sample limit.");
 			sr_session_destroy();
@@ -1408,7 +1498,7 @@ static void run_session(void)
 
 	if (opt_frames) {
 		if ((sr_parse_sizestring(opt_frames, &limit_frames) != SR_OK)
-				|| (sr_dev_config_set(sdi, SR_HWCAP_LIMIT_FRAMES,
+				|| (sr_config_set(sdi, SR_CONF_LIMIT_FRAMES,
 						&limit_frames) != SR_OK)) {
 			g_critical("Failed to configure frame limit.");
 			sr_session_destroy();
@@ -1430,10 +1520,6 @@ static void run_session(void)
 	if (opt_continuous)
 		clear_anykey();
 
-	if (opt_output_file && default_output_format) {
-		if (sr_session_save(opt_output_file, sdi, singleds) != SR_OK)
-			g_critical("Failed to save session.");
-	}
 	sr_session_destroy();
 	g_slist_free(devices);
 
@@ -1442,7 +1528,6 @@ static void run_session(void)
 static void logger(const gchar *log_domain, GLogLevelFlags log_level,
 		   const gchar *message, gpointer cb_data)
 {
-	/* Avoid compiler warnings. */
 	(void)log_domain;
 	(void)cb_data;
 
@@ -1459,6 +1544,7 @@ static void logger(const gchar *log_domain, GLogLevelFlags log_level,
 
 int main(int argc, char **argv)
 {
+	int ret = 1;
 	GOptionContext *context;
 	GError *error;
 
@@ -1470,57 +1556,70 @@ int main(int argc, char **argv)
 
 	if (!g_option_context_parse(context, &argc, &argv, &error)) {
 		g_critical("%s", error->message);
-		return 1;
+		goto done;
 	}
 
 	/* Set the loglevel (amount of messages to output) for libsigrok. */
 	if (sr_log_loglevel_set(opt_loglevel) != SR_OK)
-		return 1;
+		goto done;
+
+	if (sr_init(&sr_ctx) != SR_OK)
+		goto done;
 
+#ifdef HAVE_SRD
 	/* Set the loglevel (amount of messages to output) for libsigrokdecode. */
 	if (srd_log_loglevel_set(opt_loglevel) != SRD_OK)
-		return 1;
-
-	if (sr_init() != SR_OK)
-		return 1;
+		goto done;
 
 	if (opt_pds) {
 		if (srd_init(NULL) != SRD_OK)
-			return 1;
+			goto done;
 		if (register_pds(NULL, opt_pds) != 0)
-			return 1;
+			goto done;
 		if (srd_pd_output_callback_add(SRD_OUTPUT_ANN,
 				show_pd_annotations, NULL) != SRD_OK)
-			return 1;
+			goto done;
 		if (setup_pd_stack() != 0)
-			return 1;
+			goto done;
 		if (setup_pd_annotations() != 0)
-			return 1;
+			goto done;
 	}
+#endif
 
 	if (setup_output_format() != 0)
-		return 1;
+		goto done;
 
 	if (opt_version)
 		show_version();
 	else if (opt_list_devs)
 		show_dev_list();
+#ifdef HAVE_SRD
 	else if (opt_pds && opt_show)
 		show_pd_detail();
+#endif
 	else if (opt_show)
 		show_dev_detail();
 	else if (opt_input_file)
 		load_input_file();
+	else if (opt_set)
+		set_options();
 	else if (opt_samples || opt_time || opt_frames || opt_continuous)
 		run_session();
 	else
 		printf("%s", g_option_context_get_help(context, TRUE, NULL));
 
+#ifdef HAVE_SRD
 	if (opt_pds)
 		srd_exit();
+#endif
+
+	ret = 0;
+
+done:
+	if (sr_ctx)
+		sr_exit(sr_ctx);
 
 	g_option_context_free(context);
-	sr_exit();
 
-	return 0;
+	return ret;
 }