X-Git-Url: https://sigrok.org/gitweb/?p=sigrok-cli.git;a=blobdiff_plain;f=session.c;h=27fa262135d757dec7235c89e546bc1d975ae3d0;hp=acfbdaab529367fa19127dcf3dea241360103d19;hb=6b27bde46ccb02784a327b51b3e7beeb2f9c681a;hpb=667d4a18657b4a2b4ea77c97f4206a18dfcf86ad diff --git a/session.c b/session.c index acfbdaa..27fa262 100644 --- a/session.c +++ b/session.c @@ -18,7 +18,6 @@ */ #include "sigrok-cli.h" -#include "config.h" #include #include #include @@ -26,7 +25,6 @@ static struct sr_output_format *output_format = NULL; static int default_output_format = FALSE; -static char *output_format_param = NULL; static uint64_t limit_samples = 0; static uint64_t limit_frames = 0; @@ -84,11 +82,10 @@ static int set_limit_time(const struct sr_dev_inst *sdi) return SR_OK; } -int setup_output_format(void) +struct sr_output *setup_output_format(const struct sr_dev_inst *sdi) { GHashTable *fmtargs; - GHashTableIter iter; - gpointer key, value; + struct sr_output *o; struct sr_output_format **outputs; int i; char *fmtspec; @@ -110,32 +107,22 @@ int setup_output_format(void) fmtargs = parse_generic_arg(opt_output_format, TRUE); fmtspec = g_hash_table_lookup(fmtargs, "sigrok_key"); - if (!fmtspec) { + if (!fmtspec) g_critical("Invalid output format."); - return 1; - } outputs = sr_output_list(); for (i = 0; outputs[i]; i++) { if (strcmp(outputs[i]->id, fmtspec)) continue; g_hash_table_remove(fmtargs, "sigrok_key"); output_format = outputs[i]; - g_hash_table_iter_init(&iter, fmtargs); - while (g_hash_table_iter_next(&iter, &key, &value)) { - /* only supporting one parameter per output module - * for now, and only its value */ - output_format_param = g_strdup(value); - break; - } break; } - if (!output_format) { - g_critical("Invalid output format %s.", opt_output_format); - return 1; - } + if (!output_format) + g_critical("Invalid output format '%s'.", opt_output_format); + o = sr_output_new(output_format, fmtargs, sdi); g_hash_table_destroy(fmtargs); - return 0; + return o; } void datafeed_in(const struct sr_dev_inst *sdi, @@ -168,21 +155,8 @@ void datafeed_in(const struct sr_dev_inst *sdi, switch (packet->type) { case SR_DF_HEADER: - g_debug("cli: Received SR_DF_HEADER"); - /* Initialize the output module. */ - if (!(o = g_try_malloc(sizeof(struct sr_output)))) { - g_critical("Output module malloc failed."); - exit(1); - } - o->format = output_format; - o->sdi = (struct sr_dev_inst *)sdi; - o->param = output_format_param; - if (o->format->init) { - if (o->format->init(o) != SR_OK) { - g_critical("Output format initialization failed."); - exit(1); - } - } + g_debug("cli: Received SR_DF_HEADER."); + o = setup_output_format(sdi); /* Prepare non-stdout output. */ outfile = stdout; @@ -221,14 +195,14 @@ void datafeed_in(const struct sr_dev_inst *sdi, break; case SR_DF_META: - g_debug("cli: received SR_DF_META"); + g_debug("cli: Received SR_DF_META."); meta = packet->payload; for (l = meta->config; l; l = l->next) { src = l->data; switch (src->key) { case SR_CONF_SAMPLERATE: samplerate = g_variant_get_uint64(src->data); - g_debug("cli: got samplerate %"PRIu64" Hz", samplerate); + g_debug("cli: Got samplerate %"PRIu64" Hz.", samplerate); #ifdef HAVE_SRD if (opt_pds) { if (srd_session_metadata_set(srd_sess, SRD_CONF_SAMPLERATE, @@ -240,7 +214,7 @@ void datafeed_in(const struct sr_dev_inst *sdi, break; case SR_CONF_SAMPLE_INTERVAL: samplerate = g_variant_get_uint64(src->data); - g_debug("cli: got sample interval %"PRIu64" ms", samplerate); + g_debug("cli: Got sample interval %"PRIu64" ms.", samplerate); break; default: /* Unknown metadata is not an error. */ @@ -250,13 +224,14 @@ void datafeed_in(const struct sr_dev_inst *sdi, break; case SR_DF_TRIGGER: - g_debug("cli: received SR_DF_TRIGGER"); + g_debug("cli: Received SR_DF_TRIGGER."); triggered = 1; break; case SR_DF_LOGIC: logic = packet->payload; - g_message("cli: received SR_DF_LOGIC, %"PRIu64" bytes", logic->length); + g_message("cli: Received SR_DF_LOGIC (%"PRIu64" bytes, unitsize = %d).", + logic->length, logic->unitsize); if (logic->length == 0) break; @@ -304,7 +279,7 @@ void datafeed_in(const struct sr_dev_inst *sdi, case SR_DF_ANALOG: analog = packet->payload; - g_message("cli: received SR_DF_ANALOG, %d samples", analog->num_samples); + g_message("cli: Received SR_DF_ANALOG (%d samples).", analog->num_samples); if (analog->num_samples == 0) break; @@ -315,19 +290,19 @@ void datafeed_in(const struct sr_dev_inst *sdi, break; case SR_DF_FRAME_BEGIN: - g_debug("cli: received SR_DF_FRAME_BEGIN"); + g_debug("cli: Received SR_DF_FRAME_BEGIN."); break; case SR_DF_FRAME_END: - g_debug("cli: received SR_DF_FRAME_END"); + g_debug("cli: Received SR_DF_FRAME_END."); break; default: break; } - if (o && o->format->receive) { - if (o->format->receive(o, sdi, packet, &out) == SR_OK && out) { + if (o && outfile && !opt_pds) { + if (sr_output_send(o, packet, &out) == SR_OK && out) { fwrite(out->str, 1, out->len, outfile); fflush(outfile); g_string_free(out, TRUE); @@ -337,11 +312,10 @@ void datafeed_in(const struct sr_dev_inst *sdi, /* SR_DF_END needs to be handled after the output module's receive() * is called, so it can properly clean up that module. */ if (packet->type == SR_DF_END) { - g_debug("cli: Received SR_DF_END"); + g_debug("cli: Received SR_DF_END."); - if (o->format->cleanup) - o->format->cleanup(o); - g_free(o); + if (o) + sr_output_free(o); o = NULL; if (outfile && outfile != stdout) @@ -398,7 +372,7 @@ int opt_to_gvar(char *key, char *value, struct sr_config *src) break; src->data = g_variant_new_int32(tmp_u64); break; - case SR_T_CHAR: + case SR_T_STRING: src->data = g_variant_new_string(value); break; case SR_T_BOOL: @@ -483,8 +457,6 @@ void run_session(void) GVariant *gvar; struct sr_dev_inst *sdi; uint64_t min_samples, max_samples; - int max_channels, i; - char **triggerlist; devices = device_scan(); if (!devices) { @@ -526,18 +498,10 @@ void run_session(void) } if (opt_triggers) { - if (!(triggerlist = sr_parse_triggerstring(sdi, opt_triggers))) { + if (!parse_triggerstring(sdi, opt_triggers)) { sr_session_destroy(); return; } - max_channels = g_slist_length(sdi->channels); - for (i = 0; i < max_channels; i++) { - if (triggerlist[i]) { - sr_dev_trigger_set(sdi, i, triggerlist[i]); - g_free(triggerlist[i]); - } - } - g_free(triggerlist); } if (opt_continuous) {