X-Git-Url: https://sigrok.org/gitweb/?p=sigrok-cli.git;a=blobdiff_plain;f=parsers.c;h=794e4b56c3e73d36dbb0b8ed9fa342fa2f2df982;hp=65a265389f2d0dba79772b8e3cc3e19810bf12cf;hb=8c8056b5a08ae49b9e58f05d3c26462bfa0cc8aa;hpb=63bb454cc1cec4a3cfdb7bcf5cb7ea37ea50e93a diff --git a/parsers.c b/parsers.c index 65a2653..794e4b5 100644 --- a/parsers.c +++ b/parsers.c @@ -51,7 +51,7 @@ char **parse_probestring(int max_probes, const char *probestring) b = strtol(range[0], NULL, 10); e = strtol(range[1], NULL, 10); - if (b < 1 || e > max_probes || b >= e) { + if (b < 0 || e >= max_probes || b >= e) { g_critical("Invalid probe range '%s'.", tokens[i]); error = TRUE; break; @@ -59,24 +59,24 @@ char **parse_probestring(int max_probes, const char *probestring) while (b <= e) { snprintf(str, 7, "%d", b); - probelist[b - 1] = g_strdup(str); + probelist[b] = g_strdup(str); b++; } } else { tmp = strtol(tokens[i], NULL, 10); - if (tmp < 1 || tmp > max_probes) { + if (tmp < 0 || tmp >= max_probes) { g_critical("Invalid probe %d.", tmp); error = TRUE; break; } if ((name = strchr(tokens[i], '='))) { - probelist[tmp - 1] = g_strdup(++name); - if (strlen(probelist[tmp - 1]) > SR_MAX_PROBENAME_LEN) - probelist[tmp - 1][SR_MAX_PROBENAME_LEN] = 0; + probelist[tmp] = g_strdup(++name); + if (strlen(probelist[tmp]) > SR_MAX_PROBENAME_LEN) + probelist[tmp][SR_MAX_PROBENAME_LEN] = 0; } else { snprintf(str, 7, "%d", tmp); - probelist[tmp - 1] = g_strdup(str); + probelist[tmp] = g_strdup(str); } } } @@ -126,66 +126,6 @@ GHashTable *parse_generic_arg(const char *arg, gboolean sep_first) return hash; } -struct sr_dev *parse_devstring(const char *devstring) -{ - struct sr_dev *dev, *d; - struct sr_dev_driver **drivers; - GSList *devs, *l; - int i, num_devs, dev_num, dev_cnt; - char *tmp; - - if (!devstring) - return NULL; - - dev = NULL; - dev_num = strtol(devstring, &tmp, 10); - if (tmp != devstring) { - /* argument is numeric, meaning a device ID. Make all drivers - * scan for devices. - */ - num_devs = num_real_devs(); - if (dev_num < 0 || dev_num >= num_devs) - return NULL; - - dev_cnt = 0; - devs = sr_dev_list(); - for (l = devs; l; l = l->next) { - d = l->data; - if (sr_dev_has_hwcap(d, SR_HWCAP_DEMO_DEV)) - continue; - if (dev_cnt == dev_num) { - if (dev_num == dev_cnt) { - dev = d; - break; - } - } - dev_cnt++; - } - } else { - /* select device by driver -- only initialize that driver, - * no need to let them all scan - */ - dev = NULL; - drivers = sr_driver_list(); - for (i = 0; drivers[i]; i++) { - if (strcmp(drivers[i]->name, devstring)) - continue; - num_devs = sr_driver_init(drivers[i]); - if (num_devs == 1) { - devs = sr_dev_list(); - dev = devs->data; - } else if (num_devs > 1) { - printf("driver '%s' found %d devices, select by ID instead.\n", - devstring, num_devs); - } - /* fall through: selected driver found no devices */ - break; - } - } - - return dev; -} - char *strcanon(const char *str) { int p0, p1;