]> sigrok.org Git - sigrok-cli.git/blobdiff - sigrok-cli.c
cli: more flexible generic arg parser
[sigrok-cli.git] / sigrok-cli.c
index a9f15285e8faa64028904924fb8da6176801bc7d..e31df93c0295a91624c673d39a39da330046e4f4 100644 (file)
@@ -30,7 +30,7 @@
 #include <errno.h>
 #include <glib.h>
 #include <glib/gstdio.h>
-#include <sigrok.h>
+#include <libsigrok/libsigrok.h>
 #include "sigrok-cli.h"
 #include "config.h"
 
@@ -43,7 +43,6 @@ static uint64_t limit_frames = 0;
 static struct sr_output_format *output_format = NULL;
 static int default_output_format = FALSE;
 static char *output_format_param = NULL;
-static char *input_format_param = NULL;
 static GHashTable *pd_ann_visible = NULL;
 
 static gboolean opt_version = FALSE;
@@ -204,11 +203,12 @@ static void show_dev_list(void)
 static void show_dev_detail(void)
 {
        struct sr_dev *dev;
-       struct sr_hwcap_option *hwo;
+       const struct sr_hwcap_option *hwo;
        const struct sr_samplerates *samplerates;
        struct sr_rational *rationals;
        uint64_t *integers;
-       int cap, *hwcaps, i;
+       const int *hwcaps;
+       int cap, i;
        char *s, *title;
        const char *charopts, **stropts;
 
@@ -435,10 +435,9 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
        struct sr_datafeed_analog *analog;
        struct sr_datafeed_meta_analog *meta_analog;
        static int num_enabled_analog_probes = 0;
-       int num_enabled_probes, sample_size, data_offset, ret, i, j;
+       int num_enabled_probes, sample_size, ret, i;
        uint64_t output_len, filter_out_len;
        uint8_t *output_buf, *filter_out;
-       float asample;
 
        /* If the first packet to come in isn't a header, don't even try. */
        if (packet->type != SR_DF_HEADER && o == NULL)
@@ -472,7 +471,7 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
                }
                if (o->format->event) {
                        o->format->event(o, SR_DF_END, &output_buf, &output_len);
-                       if (output_len) {
+                       if (output_buf) {
                                if (outfile)
                                        fwrite(output_buf, 1, output_len, outfile);
                                g_free(output_buf);
@@ -485,7 +484,7 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
                if (opt_continuous)
                        g_warning("Device stopped after %" PRIu64 " samples.",
                               received_samples);
-               sr_session_halt();
+               sr_session_stop();
                if (outfile && outfile != stdout)
                        fclose(outfile);
                g_free(o);
@@ -576,13 +575,14 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
                if (opt_pds) {
                        if (srd_session_send(received_samples, (uint8_t*)filter_out,
                                        filter_out_len) != SRD_OK)
-                               sr_session_halt();
+                               sr_session_stop();
                } else {
                        output_len = 0;
                        if (o->format->data && packet->type == o->format->df_type)
                                o->format->data(o, filter_out, filter_out_len, &output_buf, &output_len);
-                       if (output_len) {
+                       if (output_buf) {
                                fwrite(output_buf, 1, output_len, outfile);
+                               fflush(outfile);
                                g_free(output_buf);
                        }
                }
@@ -621,9 +621,6 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
                                outfile = g_fopen(opt_output_file, "wb");
                        }
                }
-//             if (opt_pds)
-//                     srd_session_start(num_enabled_probes, unitsize,
-//                                     meta_logic->samplerate);
                break;
 
        case SR_DF_ANALOG:
@@ -635,33 +632,44 @@ static void datafeed_in(struct sr_dev *dev, struct sr_datafeed_packet *packet)
                if (limit_samples && received_samples >= limit_samples)
                        break;
 
-               data_offset = 0;
-               for (i = 0; i < analog->num_samples; i++) {
-                       for (j = 0; j < num_enabled_analog_probes; j++) {
-                               asample = analog->data[data_offset++];
-                               printf("%s: %f\n", analog_probelist[j]->name, asample);
+               if (o->format->data && packet->type == o->format->df_type) {
+                       o->format->data(o, (const uint8_t *)analog->data,
+                                       analog->num_samples * sizeof(float),
+                                       &output_buf, &output_len);
+                       if (output_buf) {
+                               fwrite(output_buf, 1, output_len, outfile);
+                               fflush(outfile);
+                               g_free(output_buf);
                        }
-//                     asample1 = asample2 = 0.0;
-//                     asample1 = analog->data[data_offset++];
-//                     asample2 = analog->data[i * num_analog_probes + 1];
-//                     printf("%d\t%f\t%f\n", received_samples+i+1, asample1, asample2);
                }
 
-//             output_len = 0;
-//             if (o->format->data && packet->type == o->format->df_type)
-//                     o->format->data(o, filter_out, filter_out_len, &output_buf, &output_len);
-
                received_samples += analog->num_samples;
                break;
 
        case SR_DF_FRAME_BEGIN:
-               /* TODO */
-               printf("BEGIN\n");
+               g_debug("cli: received SR_DF_FRAME_BEGIN");
+               if (o->format->event) {
+                       o->format->event(o, SR_DF_FRAME_BEGIN, &output_buf,
+                                        &output_len);
+                       if (output_buf) {
+                               fwrite(output_buf, 1, output_len, outfile);
+                               fflush(outfile);
+                               g_free(output_buf);
+                       }
+               }
                break;
 
        case SR_DF_FRAME_END:
-               /* TODO */
-               printf("END\n");
+               g_debug("cli: received SR_DF_FRAME_END");
+               if (o->format->event) {
+                       o->format->event(o, SR_DF_FRAME_END, &output_buf,
+                                        &output_len);
+                       if (output_buf) {
+                               fwrite(output_buf, 1, output_len, outfile);
+                               fflush(outfile);
+                               g_free(output_buf);
+                       }
+               }
                break;
 
        default:
@@ -692,7 +700,7 @@ static int register_pds(struct sr_dev *dev, const char *pdstring)
        pd_opthash = NULL;
        pdtokens = g_strsplit(pdstring, ",", 0);
        for (pdtok = pdtokens; *pdtok; pdtok++) {
-               if (!(pd_opthash = parse_generic_arg(*pdtok))) {
+               if (!(pd_opthash = parse_generic_arg(*pdtok, TRUE))) {
                        g_critical("Invalid protocol decoder option '%s'.", *pdtok);
                        goto err_out;
                }
@@ -744,7 +752,7 @@ int setup_pd_stack(void)
 {
        struct srd_decoder_inst *di_from, *di_to;
        int ret, i;
-       char **pds;
+       char **pds, **ids;
 
        /* Set up the protocol decoder stack. */
        pds = g_strsplit(opt_pds, ",", 0);
@@ -760,17 +768,26 @@ int setup_pd_stack(void)
                        }
                }
 
-               if (!(di_from = srd_inst_find_by_id(pds[0]))) {
+               /* First PD goes at the bottom of the stack. */
+               ids = g_strsplit(pds[0], ":", 0);
+               if (!(di_from = srd_inst_find_by_id(ids[0]))) {
+                       g_strfreev(ids);
                        g_critical("Cannot stack protocol decoder '%s': "
                                        "instance not found.", pds[0]);
                        return 1;
                }
+               g_strfreev(ids);
+
+               /* Every subsequent PD goes on top. */
                for (i = 1; pds[i]; i++) {
-                       if (!(di_to = srd_inst_find_by_id(pds[i]))) {
+                       ids = g_strsplit(pds[i], ":", 0);
+                       if (!(di_to = srd_inst_find_by_id(ids[0]))) {
+                               g_strfreev(ids);
                                g_critical("Cannot stack protocol decoder '%s': "
                                                "instance not found.", pds[i]);
                                return 1;
                        }
+                       g_strfreev(ids);
                        if ((ret = srd_inst_stack(di_from, di_to)) != SRD_OK)
                                return 1;
 
@@ -850,7 +867,8 @@ int setup_output_format(void)
                 */
                default_output_format = TRUE;
        }
-       fmtargs = parse_generic_arg(opt_output_format);
+
+       fmtargs = parse_generic_arg(opt_output_format, TRUE);
        fmtspec = g_hash_table_lookup(fmtargs, "sigrok_key");
        if (!fmtspec) {
                g_critical("Invalid output format.");
@@ -908,6 +926,7 @@ void show_pd_annotations(struct srd_proto_data *pdata, void *cb_data)
        for (i = 0; annotations[i]; i++)
                printf("\"%s\" ", annotations[i]);
        printf("\n");
+       fflush(stdout);
 }
 
 static int select_probes(struct sr_dev *dev)
@@ -971,7 +990,7 @@ static struct sr_input_format *determine_input_file_format(
        /* If the user specified -I / --input-format, use that one. */
        if (opt) {
                for (i = 0; inputs[i]; i++) {
-                       if (strcasecmp(inputs[i]->id, opt_input_format))
+                       if (strcasecmp(inputs[i]->id, opt))
                                continue;
                        g_debug("Using user-specified input file format '%s'.",
                                        inputs[i]->id);
@@ -980,7 +999,7 @@ static struct sr_input_format *determine_input_file_format(
 
                /* The user specified an unknown input format, return NULL. */
                g_critical("Error: specified input file format '%s' is "
-                       "unknown.", opt_input_format);
+                       "unknown.", opt);
                return NULL;
        }
 
@@ -1004,14 +1023,25 @@ static struct sr_input_format *determine_input_file_format(
 
 static void load_input_file_format(void)
 {
+       GHashTable *fmtargs = NULL;
        struct stat st;
        struct sr_input *in;
        struct sr_input_format *input_format;
+       char *fmtspec = NULL;
+
+       if (opt_input_format) {
+               fmtargs = parse_generic_arg(opt_input_format);
+               fmtspec = g_hash_table_lookup(fmtargs, "sigrok_key");
+       }
 
        if (!(input_format = determine_input_file_format(opt_input_file,
-                                                  opt_input_format)))
+                                                  fmtspec))) {
                /* The exact cause was already logged. */
                return;
+       }
+;
+       if (fmtargs)
+               g_hash_table_remove(fmtargs, "sigrok_key");
 
        if (stat(opt_input_file, &st) == -1) {
                g_critical("Failed to load %s: %s", opt_input_file,
@@ -1025,7 +1055,7 @@ static void load_input_file_format(void)
                exit(1);
        }
        in->format = input_format;
-       in->param = input_format_param;
+       in->param = fmtargs;
        if (in->format->init) {
                if (in->format->init(in) != SR_OK) {
                        g_critical("Input format init failed.");
@@ -1050,6 +1080,9 @@ static void load_input_file_format(void)
                        g_critical("Failed to save session.");
        }
        sr_session_destroy();
+
+       if (fmtargs)
+               g_hash_table_destroy(fmtargs);
 }
 
 static void load_input_file(void)