From 289c1bdc7e113c56f4829550ae894458bfab10a3 Mon Sep 17 00:00:00 2001 From: Soeren Apel Date: Mon, 10 Jul 2017 19:14:35 +0200 Subject: [PATCH] DecodeSignal: Don't set name when creating the signal The thought behind this was to have no unnamed signals because this may make debugging harder. However, giving the signal a long name and shortening it when decoders are added isn't working well. The reason is that the width of the header area can be expanded programmatically but we don't shrink it because we don't want to hide things the user may want to see. This behavior in turn leads to the header width expanding when a signal labeled "Empty decoder signal" is added, only to see this very signal be renamed to e.g. "SPI" immediately afterwards. As we don't shrink the header width, the header is now too wide. --- pv/data/decodesignal.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/pv/data/decodesignal.cpp b/pv/data/decodesignal.cpp index 8cbf230d..daa52ed6 100644 --- a/pv/data/decodesignal.cpp +++ b/pv/data/decodesignal.cpp @@ -62,8 +62,6 @@ DecodeSignal::DecodeSignal(pv::Session &session) : { connect(&session_, SIGNAL(capture_state_changed(int)), this, SLOT(on_capture_state_changed(int))); - - set_name(tr("Empty decoder signal")); } DecodeSignal::~DecodeSignal() -- 2.30.2