]> sigrok.org Git - pulseview.git/log
7 years agoAdd "new session" and "new view" toolbar buttons
Soeren Apel [Thu, 1 Sep 2016 19:11:18 +0000 (21:11 +0200)]
Add "new session" and "new view" toolbar buttons

Those are temporary and will eventually replaced by
a proper UI.

7 years agoMainWindow: Enable dock nesting
Soeren Apel [Thu, 1 Sep 2016 06:46:04 +0000 (08:46 +0200)]
MainWindow: Enable dock nesting

7 years agoSave/restore view states and signal settings
Soeren Apel [Wed, 31 Aug 2016 06:19:02 +0000 (08:19 +0200)]
Save/restore view states and signal settings

7 years agoSession: Implement .sr file save/restore
Soeren Apel [Mon, 29 Aug 2016 19:41:17 +0000 (21:41 +0200)]
Session: Implement .sr file save/restore

7 years agoFix crash when saving session with open files
Soeren Apel [Mon, 29 Aug 2016 16:10:09 +0000 (18:10 +0200)]
Fix crash when saving session with open files

7 years agoLet SignalBase store/restore its internal data
Soeren Apel [Mon, 29 Aug 2016 16:08:11 +0000 (18:08 +0200)]
Let SignalBase store/restore its internal data

7 years agoSession: Save/restore channel info and top-level decoder
Soeren Apel [Sun, 28 Aug 2016 20:03:50 +0000 (22:03 +0200)]
Session: Save/restore channel info and top-level decoder

7 years agoSignalBase: Add internal name
Soeren Apel [Sun, 28 Aug 2016 15:44:42 +0000 (17:44 +0200)]
SignalBase: Add internal name

7 years agoMainWindow/MainBar: Fix signals
Soeren Apel [Sun, 28 Aug 2016 14:54:58 +0000 (16:54 +0200)]
MainWindow/MainBar: Fix signals

Before, QMetaObject::connectSlotsByName(this) was used to connect
the signals to the slots automagically. This is no longer feasible
for the MainBar as there are slots that can't be auto-assigned and
the MainWindow doesn't have any signals at the moment.

7 years agoSession/MainBar: Fix device change handling
Soeren Apel [Sat, 27 Aug 2016 20:23:28 +0000 (22:23 +0200)]
Session/MainBar: Fix device change handling

7 years agoSession: Fix include order
Soeren Apel [Sat, 27 Aug 2016 19:58:48 +0000 (21:58 +0200)]
Session: Fix include order

7 years agoImplement multi-session handling
Soeren Apel [Sat, 27 Aug 2016 19:55:57 +0000 (21:55 +0200)]
Implement multi-session handling

This includes letting sessions restore their internal state on
their own and that there are unique names associated with each
session that the GUI can use when there is no data.

7 years agoMake the first view own the toolbar instead of the main window
Soeren Apel [Fri, 26 Aug 2016 20:29:40 +0000 (22:29 +0200)]
Make the first view own the toolbar instead of the main window

Handling multiple sessions requires that every session can be
controlled individually. This means that either

a) there could be one toolbar that adjusts dynamically to the
session whose view currently has focus


b) every session has its own toolbar.

I opted for b) because it's more intuitive and more straightforward
to implement. So now every session has a main view (the first one
created) and a main bar that sits in the same dock widget.

7 years agoMainWindow: Remove menu bar
Soeren Apel [Mon, 22 Aug 2016 15:32:34 +0000 (17:32 +0200)]
MainWindow: Remove menu bar

7 years agoMainWindow: Prevent Qt from restoring the dock widgets
Soeren Apel [Thu, 18 Aug 2016 18:02:18 +0000 (20:02 +0200)]
MainWindow: Prevent Qt from restoring the dock widgets

7 years agoRemove context menu for central MainWindow widget
Soeren Apel [Wed, 17 Aug 2016 06:25:03 +0000 (08:25 +0200)]
Remove context menu for central MainWindow widget

7 years agoFix signal connection for view::Signal and SignalBase enabled state
Soeren Apel [Tue, 16 Aug 2016 19:34:30 +0000 (21:34 +0200)]
Fix signal connection for view::Signal and SignalBase enabled state

7 years agoMove view-independent data from view::DecodeTrace to SignalBase
Soeren Apel [Tue, 16 Aug 2016 19:32:56 +0000 (21:32 +0200)]
Move view-independent data from view::DecodeTrace to SignalBase

7 years agoMove signals to views and make Session handle multiple views
Soeren Apel [Tue, 16 Aug 2016 19:31:59 +0000 (21:31 +0200)]
Move signals to views and make Session handle multiple views

7 years agoUse SignalBase instead of LogicSignal for decoders
Soeren Apel [Tue, 16 Aug 2016 19:30:46 +0000 (21:30 +0200)]
Use SignalBase instead of LogicSignal for decoders

7 years agoRemove data_ also for LogicSignal and use SignalBase data instead
Soeren Apel [Tue, 16 Aug 2016 19:14:55 +0000 (21:14 +0200)]
Remove data_ also for LogicSignal and use SignalBase data instead

7 years agoMove signal data to SignalBase and adjust view::AnalogSignal
Soeren Apel [Tue, 16 Aug 2016 19:13:25 +0000 (21:13 +0200)]
Move signal data to SignalBase and adjust view::AnalogSignal

The signal data belongs to the signal base (M) and not
the view's AnalogSignal (V). Hence we need to move it.

7 years agoRename Trace::channel_ to Trace::base_, including dependencies
Soeren Apel [Tue, 16 Aug 2016 19:10:40 +0000 (21:10 +0200)]
Rename Trace::channel_ to Trace::base_, including dependencies

7 years agoIntroduce pv::data::SignalBase
Soeren Apel [Tue, 16 Aug 2016 19:09:58 +0000 (21:09 +0200)]
Introduce pv::data::SignalBase

7 years agoFix #814 by using PNG application logo instead of SVG
Soeren Apel [Tue, 16 Aug 2016 19:00:16 +0000 (21:00 +0200)]
Fix #814 by using PNG application logo instead of SVG

7 years agoMake view windows non-closeable
Soeren Apel [Tue, 16 Aug 2016 18:46:56 +0000 (20:46 +0200)]
Make view windows non-closeable

7 years agoImplement MainWindow::add_view()
Soeren Apel [Tue, 16 Aug 2016 16:11:41 +0000 (18:11 +0200)]
Implement MainWindow::add_view()

7 years agoViewWidget: Define ViewTypes
Soeren Apel [Thu, 5 May 2016 19:23:19 +0000 (21:23 +0200)]
ViewWidget: Define ViewTypes

7 years agoIntroduce MainWindow::get_active_view()
Soeren Apel [Sat, 16 Apr 2016 21:49:07 +0000 (23:49 +0200)]
Introduce MainWindow::get_active_view()

7 years agoUse a QDockWidget to contain the view
Soeren Apel [Sat, 16 Apr 2016 20:51:25 +0000 (22:51 +0200)]
Use a QDockWidget to contain the view

7 years agoView: Move assertion after assignment
Soeren Apel [Wed, 20 Jul 2016 06:52:50 +0000 (08:52 +0200)]
View: Move assertion after assignment

7 years agoDevice: add support for list of discrete values for probe factor
Aurelien Jacobs [Sat, 25 Jun 2016 19:44:46 +0000 (21:44 +0200)]
Device: add support for list of discrete values for probe factor

7 years agoConnect dialog: Fix up UI and allow for VXI
Soeren Apel [Thu, 16 Jun 2016 17:56:54 +0000 (19:56 +0200)]
Connect dialog: Fix up UI and allow for VXI

7 years agoConnect dialog: Fix constructor initialization order
Soeren Apel [Thu, 9 Jun 2016 03:04:57 +0000 (05:04 +0200)]
Connect dialog: Fix constructor initialization order

7 years agoConnect dialog: Add support for connecting to raw-tcp devices
whitequark [Thu, 9 Jun 2016 03:02:52 +0000 (05:02 +0200)]
Connect dialog: Add support for connecting to raw-tcp devices

This fixes bug #769.

7 years agoRevert "cmake: use pkg-config ldflags directly instead of spliting libs and dirs"
Uwe Hermann [Fri, 24 Jun 2016 21:17:51 +0000 (23:17 +0200)]
Revert "cmake: use pkg-config ldflags directly instead of spliting libs and dirs"

This reverts commit bb4dede4c8bd711628566d3eb2136442f7205a41.

The -Wl,--whole-archive in libsigrok that lead to this change no longer
exists, so this change can be reverted (since it also causes issues with
"make test").

This fixes bug #808.

7 years agoFix #805 by resetting selected device on failure
Soeren Apel [Wed, 22 Jun 2016 16:02:34 +0000 (18:02 +0200)]
Fix #805 by resetting selected device on failure

It can happen that devices can be selected but not used
(permissions problems, connection issues, driver issues, etc.),
so in those cases we want to fail gracefully instead of
The reason for the segfault is the device selector button
isn't reset in case the device couldn't be opened, causing
the rest of the application to try and work with a device
instance that is actually invalid.

Resetting the device selector when the device failed to
open not only fixes this but also makes the UI more
consistent with the internal state.

7 years agoFix warning for unused Session::sample_thread_proc() parameter
Soeren Apel [Sun, 29 May 2016 15:30:49 +0000 (17:30 +0200)]
Fix warning for unused Session::sample_thread_proc() parameter

7 years agoSession: Improve session robustness
Soeren Apel [Sun, 29 May 2016 15:21:13 +0000 (17:21 +0200)]
Session: Improve session robustness

Don't try to start an acquisition if the device is undefined.

7 years agocmake: add check for explicit linking against libatomic
Samuel Martin [Thu, 26 May 2016 21:46:40 +0000 (23:46 +0200)]
cmake: add check for explicit linking against libatomic

To use atomics functions, some toolchains requires to explicitly add
-latomic to the linker flags (because they are not provided by libc,
but libatomic).

This change adds a helper function trying to build/link a test program
using atomics, then calls it to:
* first check if atomics are directly available in the libc;
* if not and libatomic has been found, then run the same test with
  "-latomic" added to the linker flags.
The pulseview link library list is updated according to the results of
these tests.

This issue was triggered by the Buildroot farms:

1- CMAKE_REQUIRED_* variables are only used in check functions. They
   are not automatically forwarded to/handled by the target commands
   (such as target_link_library), because the check functions are
   implemented as macro in CMake code, whereas many target commands
   are native.
2- Because of note #1, CMAKE_REQUIRED_LIBRARIES (or its value) must be
   explicitly passed to the target_link_library command when this is
3- In this implementation, LIBATOMIC_LIBRARY is only set when it is
   needed; so, unconditionally appending it to PULSEVIEW_LINK_LIBS
   will produce the expected behavior.

This fixes bug #810.

Signed-off-by: Samuel Martin <redacted>
7 years agocmake: use pkg-config ldflags directly instead of spliting libs and dirs
Aurelien Jacobs [Thu, 19 May 2016 22:23:11 +0000 (00:23 +0200)]
cmake: use pkg-config ldflags directly instead of spliting libs and dirs

This allows picking some necessary linker flags such as

7 years agoTrace: Make popup forms compatible with OSX
Elias Oenal [Thu, 19 May 2016 18:34:45 +0000 (20:34 +0200)]
Trace: Make popup forms compatible with OSX

Qt behaves differently on OSX regarding widget lifetime it seems,
causing the addition of a stacked decoder to crash PV.

According to Elias, the object popup_form_ gets destroyed, yet
it still has the parent popup_ which in turn will destroy it
again at the end of its life. Either removing the parent, or the
preliminary destruction, fixes the crash.

7 years agoSession: Keep track of signal data locally
Soeren Apel [Thu, 19 May 2016 18:29:37 +0000 (20:29 +0200)]
Session: Keep track of signal data locally

Currently, the Session class doesn't hold pointers to the signal
data itself but instead fetches the data on demand using the list
of signals it has. As the Session is providing the model in the
MVC paradigm, it owns the data and thus should keep track of it
directly. The signals are (in an ideal world) mere views on that
data, so querying them for the signal data isn't good style.

7 years agoInputFile: Use new reset() function to allow re-reading file
Soeren Apel [Mon, 2 May 2016 20:22:39 +0000 (22:22 +0200)]
InputFile: Use new reset() function to allow re-reading file

Commit 519d0ccbe67d005a9c442795ce3b8255e78ca46d tried to solve
the problem of being unable to re-read an opened file by clicking
the "run" button. However, the solution is insufficient.
PV expects the session device to be updated after the open()
call. If it is not, the device settings popup will show the
settings of the previously used device.

This patch fixes this and also makes use of the new reset()
method to allow re-reading of the file contents. The method
is necessary because otherwise we have to destroy the input
module and create a new instance. This however also means
setting a new session device, which is highly undesirable.
So reset() it is.

7 years agoDecoderStack: Force a viewport update more frequently
Soeren Apel [Tue, 3 May 2016 19:49:00 +0000 (21:49 +0200)]
DecoderStack: Force a viewport update more frequently

Updating the viewport every 65kib of input data causes
the decode trace to make really big leaps, leaving the
user with the feeling of a not-so-snappy user interface.
We can easily change this by updating the trace every 1kib
since the decoder and the UI thread are separate and the
decode trace drawing is much faster since when the limit
was originally set.

7 years agoFix #792 by making sure we don't request samples that don't exist
Soeren Apel [Tue, 3 May 2016 06:53:24 +0000 (08:53 +0200)]
Fix #792 by making sure we don't request samples that don't exist

7 years agoConnect dialog: Make button caption more clear
Soeren Apel [Tue, 26 Apr 2016 06:30:02 +0000 (08:30 +0200)]
Connect dialog: Make button caption more clear

Users are expecting *any* device to be found when pressing
the "Scan for Devices" button. As that is not what it's doing,
we need to clarify what it does.

7 years agoDecodeTrace: Let the view know when we need more space
Soeren Apel [Wed, 20 Apr 2016 16:27:29 +0000 (18:27 +0200)]
DecodeTrace: Let the view know when we need more space

7 years agoDecodeTrace: Make sure first row's label width can be calculated
Soeren Apel [Wed, 20 Apr 2016 16:15:12 +0000 (18:15 +0200)]
DecodeTrace: Make sure first row's label width can be calculated

Without a pen set, p.boundingRect() returns 0. All other rows
have their label text width calculated with a pen, which makes
p.boundingRect() work as intended. Fix this by setting a pen
before the first row is processed.

7 years agoView: Remove unnecessary methods
Soeren Apel [Mon, 18 Apr 2016 19:44:48 +0000 (21:44 +0200)]
View: Remove unnecessary methods

7 years agoFix #771 by using black with alpha instead of an opaque grey
Soeren Apel [Mon, 18 Apr 2016 06:25:36 +0000 (08:25 +0200)]
Fix #771 by using black with alpha instead of an opaque grey

7 years agoFix #777 by using a workaround for assumed glibmm bug
Soeren Apel [Sun, 17 Apr 2016 13:29:09 +0000 (15:29 +0200)]
Fix #777 by using a workaround for assumed glibmm bug

7 years agoFix #705 by preventing the use of invalid instances
Soeren Apel [Sun, 17 Apr 2016 13:28:51 +0000 (15:28 +0200)]
Fix #705 by preventing the use of invalid instances

As QCache owns the object instances it manages, inserting
an object into the cache transfers ownership automatically.
This means we can't use an instance after it has been
inserted into the cache as this results in a double free
situation as we'd end up calling the destructor on the same
object instance as the cache.

7 years agoAnalogSignal: Make sure the trace is redrawn when changing vdiv count
Soeren Apel [Wed, 13 Apr 2016 18:17:53 +0000 (20:17 +0200)]
AnalogSignal: Make sure the trace is redrawn when changing vdiv count

7 years agoTrace/AnalogSignal: Improve contrast and precision of the trace lines
Soeren Apel [Wed, 13 Apr 2016 17:45:22 +0000 (19:45 +0200)]
Trace/AnalogSignal: Improve contrast and precision of the trace lines

7 years agoView: Make sure unused groups are freed
Soeren Apel [Wed, 13 Apr 2016 06:29:17 +0000 (08:29 +0200)]
View: Make sure unused groups are freed

7 years agoSession: Make sure all data is deleted before changing devices
Soeren Apel [Mon, 11 Apr 2016 06:45:36 +0000 (08:45 +0200)]
Session: Make sure all data is deleted before changing devices

7 years agoInputFile: Don't try to create device twice
Soeren Apel [Fri, 8 Apr 2016 21:32:54 +0000 (23:32 +0200)]
InputFile: Don't try to create device twice

The InputFile currently only keeps track of the
need for a device instance local to run().
This means that when calling run() a second time
(e.g. by clicking the "Run" button after loading
a file), the function will try to create the
device instance and add it to the session.
This fails as the first created instance is
still assigned to the session and thus the
session will reject adding another device.

Furthermore, simply clearing the session
devices isn't enough for proper operation.
The issue is that once a file's content has
been sent to an input module, the module is
not going to accept another file. It needs
to be reset to its initial state. To do this,
we create the input module instance every time
we want to read the file.

7 years agoDecodeTrace: Make an empty decode trace appear symmetrical
Soeren Apel [Fri, 8 Apr 2016 16:32:41 +0000 (18:32 +0200)]
DecodeTrace: Make an empty decode trace appear symmetrical

7 years agoDecodeTrace: Replace magic number by proper calculation
Soeren Apel [Fri, 8 Apr 2016 16:25:58 +0000 (18:25 +0200)]
DecodeTrace: Replace magic number by proper calculation

7 years agotest/CMakeLists.txt: Add missing #include file.
Uwe Hermann [Fri, 8 Apr 2016 09:49:22 +0000 (11:49 +0200)]
test/CMakeLists.txt: Add missing #include file.

7 years agoAnalogSignal: Implement info text for V/div display
Soeren Apel [Thu, 7 Apr 2016 20:03:40 +0000 (22:03 +0200)]
AnalogSignal: Implement info text for V/div display

7 years agoAnalogSignal: Implement resolution selector in dialog
Soeren Apel [Thu, 7 Apr 2016 20:03:30 +0000 (22:03 +0200)]
AnalogSignal: Implement resolution selector in dialog

7 years agoAnalogSignal: Use Q_OBJECT and implement vdiv selector in dialog
Soeren Apel [Thu, 7 Apr 2016 20:03:17 +0000 (22:03 +0200)]
AnalogSignal: Use Q_OBJECT and implement vdiv selector in dialog

7 years agoAnalogSignal: Use correct scaling factor for the grid to work
Soeren Apel [Thu, 7 Apr 2016 20:03:05 +0000 (22:03 +0200)]
AnalogSignal: Use correct scaling factor for the grid to work

7 years agoAnalogSignal: Implement vertical grid
Soeren Apel [Thu, 7 Apr 2016 20:02:50 +0000 (22:02 +0200)]
AnalogSignal: Implement vertical grid

7 years agoView: Handle pre-existing trace groups correctly
Soeren Apel [Thu, 7 Apr 2016 20:02:04 +0000 (22:02 +0200)]
View: Handle pre-existing trace groups correctly

7 years agoView: Restore the original signals_changed() positioning code
Soeren Apel [Thu, 7 Apr 2016 20:01:31 +0000 (22:01 +0200)]
View: Restore the original signals_changed() positioning code

7 years agoView: Remove empty trace groups in signals_changed()
Soeren Apel [Sun, 3 Apr 2016 19:15:00 +0000 (21:15 +0200)]
View: Remove empty trace groups in signals_changed()

7 years agoView: Provide a clear setup path for the initial v_offset value
Soeren Apel [Sun, 3 Apr 2016 18:37:53 +0000 (20:37 +0200)]
View: Provide a clear setup path for the initial v_offset value

- View::update_scroll():
  The range for the vertical scrollbar is only updated if there
  are traces in the view.

- View::set_scroll_default():
  This new function adjusts the vertical offset of the view so
  that all traces are visible. Needs to be executed once after a
  new device was selected.

- View::signals_changed():
  We want to be able to clear stale items in-between devices, so
  we no longer want to simply return when no device is selected.
  This means we need to handle a missing device more gracefully.

  Also, we now reset the vertical scroll bar when no device is
  selected and call set_scroll_default() when needed.

7 years agoView: Make signals_changed() more predictable
Soeren Apel [Sun, 3 Apr 2016 18:35:57 +0000 (20:35 +0200)]
View: Make signals_changed() more predictable

Newly created trace groups have their traces restacked
immediately to make sure we can rely on the group's v_extents.

We no longer unconditionally add trace groups that could
actually be empty.

The code that adds the new top-level items is more
straightforward now.

7 years agoTraceTreeItemOwner: Change behavior for empty containers
Soeren Apel [Sun, 3 Apr 2016 18:34:50 +0000 (20:34 +0200)]
TraceTreeItemOwner: Change behavior for empty containers

An empty TraceTreeItemOwner's v_extents are no longer
[INT_MAX, INT_MIN] but [0, 0] instead. As new items were added
relative to the view's own v_extents, items were added at
positions close to the over-/underflow margin. This messed up
the scrollbar among other things. Returning [0, 0] instead
allows for better handling of such cases.

7 years agoSession: Don't crash when session.device_ is empty
Soeren Apel [Sun, 3 Apr 2016 18:34:01 +0000 (20:34 +0200)]
Session: Don't crash when session.device_ is empty

7 years agoSession: Improve signal handling during device selection
Soeren Apel [Sun, 3 Apr 2016 18:33:19 +0000 (20:33 +0200)]
Session: Improve signal handling during device selection

Changing devices now forces an update of the view's signal handling.
This will allow clearing the view properly in-between devices.

7 years agoStoreSession: Add analog saving support
Soeren Apel [Sun, 13 Mar 2016 16:46:27 +0000 (17:46 +0100)]
StoreSession: Add analog saving support

7 years agoUse natural sort order for DecodeTrace channel selector drop-down
Soeren Apel [Sun, 13 Mar 2016 16:46:14 +0000 (17:46 +0100)]
Use natural sort order for DecodeTrace channel selector drop-down

7 years agofix 'Exception: not applicable' when connecting to hantek-dso
ntruchsess [Fri, 11 Mar 2016 21:52:47 +0000 (22:52 +0100)]
fix 'Exception: not applicable' when connecting to hantek-dso

7 years agoFix various typos in code comments.
Uwe Hermann [Wed, 24 Feb 2016 18:44:40 +0000 (19:44 +0100)]
Fix various typos in code comments.

7 years agoAndroidManifest.xml: Bump PV version to 0.4.0.
Uwe Hermann [Wed, 17 Feb 2016 21:08:17 +0000 (22:08 +0100)]
AndroidManifest.xml: Bump PV version to 0.4.0.

7 years agoUse the 'default' keyword where applicable. This patch
Soeren Apel [Tue, 16 Feb 2016 20:15:03 +0000 (21:15 +0100)]
Use the 'default' keyword where applicable. This patch
 was initially created using clang-tidy:

  clang-tidy -checks="-*,moderize-use-default" -fix

However, the resulting patch only wanted to alter the
definitions in the .cpp file. I think it makes more
sense to remove the definitions completely and just
add "= default" to the declarations in the header file.

7 years agoDecodeTrace: Optimize loop (see also da50281d)
Soeren Apel [Tue, 16 Feb 2016 20:14:41 +0000 (21:14 +0100)]
DecodeTrace: Optimize loop (see also da50281d)

7 years agoWhitespace fix
Soeren Apel [Tue, 16 Feb 2016 20:14:12 +0000 (21:14 +0100)]
Whitespace fix

7 years agoPrefer Qt string multi-arg form over arg chaining.
Uwe Hermann [Sat, 6 Feb 2016 21:07:30 +0000 (22:07 +0100)]
Prefer Qt string multi-arg form over arg chaining.

This has performance/memory advantages and avoids some potential bugs
and/or security problems.

7 years agoStandardize on 'event' as name for all Qt events.
Uwe Hermann [Wed, 10 Feb 2016 20:45:37 +0000 (21:45 +0100)]
Standardize on 'event' as name for all Qt events.

Use 'event' consistently across the whole code-base as variable name
for Qt events (previously 'e' or 'evt' was also used).

7 years agoFix inconsistent declaration parameter names.
Uwe Hermann [Wed, 10 Feb 2016 20:55:49 +0000 (21:55 +0100)]
Fix inconsistent declaration parameter names.

This patch was generated using clang-tidy:

  clang-tidy -checks="-*,readability-inconsistent-declaration-parameter-name" -fix

(with some manual fixups of false-positives)

7 years agoUse range-based for loops more often.
Uwe Hermann [Mon, 8 Feb 2016 20:02:37 +0000 (21:02 +0100)]
Use range-based for loops more often.

This patch was generated using clang-tidy:

  clang-tidy -checks="-*,modernize-loop-convert" -fix

7 years agoUse nullptr in some more places.
Uwe Hermann [Mon, 8 Feb 2016 20:17:34 +0000 (21:17 +0100)]
Use nullptr in some more places.

This patch was generated using clang-tidy:

  clang-tidy -checks="-*,modernize-use-nullptr" -fix

7 years agoCMakeLists.txt: Bump PulseView version to 0.4.0.
Uwe Hermann [Wed, 10 Feb 2016 23:17:36 +0000 (00:17 +0100)]
CMakeLists.txt: Bump PulseView version to 0.4.0.

0.4.0 will be the next major release. Bump now, so that
there is no confusion of tarball 0.3.0 and 0.4.0-git snapshots.

7 years agoFix #181 by changing the global decode lock into an SRD lock
Soeren Apel [Tue, 9 Feb 2016 13:48:31 +0000 (14:48 +0100)]
Fix #181 by changing the global decode lock into an SRD lock

The global decode was insufficient insofar as it didn't
prevent a newly started decode thread from interjecting its
own decode operations. When this happens, something goes
haywire somewhere and Python crashes.

Until the underlying cause is fixed, this global SRD lock
forces one decoder thread to finish before another one can

While this is a bit inconvenient for wanting to decode as
the acquisition is going on, it currently is the only
working option.

7 years agoDecoderStack: Make decoder sessions terminate after running
Soeren Apel [Tue, 9 Feb 2016 10:58:36 +0000 (11:58 +0100)]
DecoderStack: Make decoder sessions terminate after running

Currently, SRD sessions aren't terminating after all data
has been decoded, leaving the decode thread in a state
where it's waiting for more data.
This would be okay if an acquisition was still ongoing but
when the acquisition has been stopped, there will never be
more data. When a new acquisition is started, the previous
decode sessions will be terminated and then new ones will
be started. This is the reason why this behavior wasn't
an issue up until now.

However, the fix for #181 requires that the decode thread
terminates or else the global SRD lock will never be

7 years agoMainWindow: Try to use any available device aside from demo
Soeren Apel [Sat, 6 Feb 2016 17:07:05 +0000 (18:07 +0100)]
MainWindow: Try to use any available device aside from demo

Currently, PV will only try to use the previously used device.
However, when first running PV, it will default to demo as
there is no previously used device. In this case, we still
want to use whatever device we can get our hands on so that
the user can start using PV immediately.

7 years agoDecodeTrace: Remove unnecessary parameters
Soeren Apel [Thu, 4 Feb 2016 21:39:35 +0000 (22:39 +0100)]
DecodeTrace: Remove unnecessary parameters

7 years agoDecodeTrace: Let annotation labels be pushed aside by the row title
Soeren Apel [Thu, 4 Feb 2016 21:39:07 +0000 (22:39 +0100)]
DecodeTrace: Let annotation labels be pushed aside by the row title

7 years agoDecodeTrace: Try to keep annotation labels within the view
Soeren Apel [Thu, 4 Feb 2016 21:38:34 +0000 (22:38 +0100)]
DecodeTrace: Try to keep annotation labels within the view

Up until now, annotation labels were always drawn centered,
even if the annotation was very wide and mostly off-screen.
This resulted in annotation labels being out of view, even
if there would be enough space to draw it within the view.
This patch fixes this.

7 years agoFix 745 by improving the draw_annotations() block drawing algo
Soeren Apel [Thu, 4 Feb 2016 21:37:54 +0000 (22:37 +0100)]
Fix 745 by improving the draw_annotations() block drawing algo

7 years agoFix clang warning: shifting a negative signed value is undefined
Soeren Apel [Sun, 31 Jan 2016 17:22:17 +0000 (18:22 +0100)]
Fix clang warning: shifting a negative signed value is undefined

7 years agoFix #737 by adding the override specifier where needed
Soeren Apel [Sun, 31 Jan 2016 17:18:47 +0000 (18:18 +0100)]
Fix #737 by adding the override specifier where needed

7 years agoFix unit tests and prevent warnings
Soeren Apel [Sun, 31 Jan 2016 17:06:07 +0000 (18:06 +0100)]
Fix unit tests and prevent warnings

7 years agoFix #733: Open import files using binary mode
Soeren Apel [Sun, 31 Jan 2016 14:10:10 +0000 (15:10 +0100)]
Fix #733: Open import files using binary mode

7 years agoView: Honor ENABLE_DECODE compiler switch
Soeren Apel [Sun, 31 Jan 2016 13:12:44 +0000 (14:12 +0100)]
View: Honor ENABLE_DECODE compiler switch