3 years agoFix random clazy warnings
Soeren Apel [Sun, 21 Oct 2018 19:47:42 +0000 (21:47 +0200)]
Fix random clazy warnings

Some of them are invalid, though, so we suppress them for
future clazy runs.

3 years agoFix clazy warnings regarding range-for references
Soeren Apel [Sun, 21 Oct 2018 19:22:01 +0000 (21:22 +0200)]
Fix clazy warnings regarding range-for references

The warnings that are fixed are of this type:
warning: Missing reference in range-for with non trivial type (std::__cxx11::string) [-Wclazy-range-loop]

3 years agoFix #1035 by checking for exceptions when accessing config
Soeren Apel [Sun, 21 Oct 2018 16:07:25 +0000 (18:07 +0200)]
Fix #1035 by checking for exceptions when accessing config

Also fixes #651 because it makes Device::read_config()

3 years agoFix for "fill logic signal high areas" feature
Soeren Apel [Sun, 21 Oct 2018 11:07:41 +0000 (13:07 +0200)]
Fix for "fill logic signal high areas" feature

At certain zoom levels, the algorithm wrongly fills areas where
the signal is low. This patch fixes this.

3 years agoFix #1222 by adding a tooltip for when there isn't enough space
Soeren Apel [Fri, 19 Oct 2018 21:36:13 +0000 (23:36 +0200)]
Fix #1222 by adding a tooltip for when there isn't enough space

Also fixes #870 by always using 12 digits for precision

3 years agoAdd generic "Create marker here" context menu entry
Soeren Apel [Tue, 16 Oct 2018 22:39:54 +0000 (00:39 +0200)]
Add generic "Create marker here" context menu entry

3 years agoREADME: List icon/theme licenses explicitly.
Uwe Hermann [Tue, 16 Oct 2018 21:31:49 +0000 (23:31 +0200)]
README: List icon/theme licenses explicitly.

3 years agoLogging: Adjust UI colors to suit both dark and bright themes
Soeren Apel [Tue, 16 Oct 2018 19:15:58 +0000 (21:15 +0200)]
Logging: Adjust UI colors to suit both dark and bright themes

3 years agoChannels: Make channel enable/disable options symmetric
Soeren Apel [Tue, 16 Oct 2018 19:01:35 +0000 (21:01 +0200)]
Channels: Make channel enable/disable options symmetric

3 years agoSpeed up MipMap downsampling in logicsegment
Jon Burgess [Sat, 13 Oct 2018 14:11:54 +0000 (15:11 +0100)]
Speed up MipMap downsampling in logicsegment

Make use of the segment chunk size to process samples
in contiguous blocks when possible.

Provide routines for downsampling with sample sizes
of 1, 2, 4 & 8 bytes which the compiler can optimize.

These changes halve the time taken to display the
23MB ws2812b_neopixel24_4mhz_verylong.sr from
40 seconds to 18 seconds.

3 years agoExpose length of valid data in segment chunk
Jon Burgess [Sat, 13 Oct 2018 21:26:25 +0000 (22:26 +0100)]
Expose length of valid data in segment chunk

3 years agoFix memory leak in DecoderMenu
Jon Burgess [Sun, 14 Oct 2018 22:52:24 +0000 (23:52 +0100)]
Fix memory leak in DecoderMenu

==214004== 1,536 (16 direct, 1,520 indirect) bytes in 1 blocks are definitely lost in loss record 6,288 of 6,442
==214004==    at 0x4C2EE0B: malloc (vg_replace_malloc.c:299)
==214004==    by 0x67D8435: g_malloc (in /usr/lib64/libglib-2.0.so.0.5600.3)
==214004==    by 0x67F0056: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.5600.3)
==214004==    by 0x67F14FA: g_slist_copy_deep (in /usr/lib64/libglib-2.0.so.0.5600.3)
==214004==    by 0x5584FC: pv::widgets::DecoderMenu::DecoderMenu(QWidget*, bool) (decodermenu.cpp:33)

3 years agoImplement fixes proposed by clang-tidy
Soeren Apel [Sun, 14 Oct 2018 20:56:08 +0000 (22:56 +0200)]
Implement fixes proposed by clang-tidy

3 years agoAdd themes and implement theme support
Soeren Apel [Sun, 14 Oct 2018 20:27:33 +0000 (22:27 +0200)]
Add themes and implement theme support

3 years agoMake "fill logic signal high areas" feature more robust
Soeren Apel [Sun, 14 Oct 2018 14:04:05 +0000 (16:04 +0200)]
Make "fill logic signal high areas" feature more robust

3 years agodevice.cpp: SR_CONF_AVG_SAMPLES: Add support for list of values.
Uwe Hermann [Sat, 13 Oct 2018 22:24:42 +0000 (00:24 +0200)]
device.cpp: SR_CONF_AVG_SAMPLES: Add support for list of values.

3 years agoTrace: Force trace replaint when a setting changes
Soeren Apel [Sat, 13 Oct 2018 19:42:48 +0000 (21:42 +0200)]
Trace: Force trace replaint when a setting changes

3 years agoUse QMenu->popup() instead of QMenu->exec() everywhere
Soeren Apel [Sat, 13 Oct 2018 19:35:09 +0000 (21:35 +0200)]
Use QMenu->popup() instead of QMenu->exec() everywhere

3 years agoGlobalSettings: Enable mouse hover marker by default
Soeren Apel [Sat, 13 Oct 2018 19:18:28 +0000 (21:18 +0200)]
GlobalSettings: Enable mouse hover marker by default

3 years agoImplement "fill logic signal high areas" feature
Soeren Apel [Sat, 13 Oct 2018 19:13:24 +0000 (21:13 +0200)]
Implement "fill logic signal high areas" feature

3 years agoSegment: Implement temporary workaround for #1284
Soeren Apel [Sat, 13 Oct 2018 12:04:33 +0000 (14:04 +0200)]
Segment: Implement temporary workaround for #1284

3 years agoRuler: Add "toggle mouse hover marker" to context menu
Soeren Apel [Wed, 10 Oct 2018 18:13:57 +0000 (20:13 +0200)]
Ruler: Add "toggle mouse hover marker" to context menu

3 years agoRuler: Add context menu with "Create marker here" entry
Soeren Apel [Wed, 10 Oct 2018 16:08:40 +0000 (18:08 +0200)]
Ruler: Add context menu with "Create marker here" entry

3 years agoSegments: Fix iterator access to underlying value
Soeren Apel [Tue, 9 Oct 2018 06:10:39 +0000 (08:10 +0200)]
Segments: Fix iterator access to underlying value

Before this change, it->value was accessed even when the
iterator went past the end of the underlying buffer.

3 years agoLogicSegment: Check upper bound when performing edge search
Soeren Apel [Mon, 8 Oct 2018 21:54:17 +0000 (23:54 +0200)]
LogicSegment: Check upper bound when performing edge search

3 years agomanual: Reword and update some stuff
Soeren Apel [Sat, 6 Oct 2018 07:43:37 +0000 (09:43 +0200)]
manual: Reword and update some stuff

3 years agoView: Refine snapping algorithm
Soeren Apel [Fri, 5 Oct 2018 21:52:12 +0000 (23:52 +0200)]
View: Refine snapping algorithm

We now also choose the best match depending on edge density.

3 years agoView: Fix snap-to-edge when using all signals
Soeren Apel [Fri, 5 Oct 2018 16:56:11 +0000 (18:56 +0200)]
View: Fix snap-to-edge when using all signals

3 years agoRename --no-scan to --dont-scan
Soeren Apel [Wed, 3 Oct 2018 20:04:30 +0000 (22:04 +0200)]
Rename --no-scan to --dont-scan

3 years agoFix #1292/1294 by snapping to any edge when not hovering over a signal
Soeren Apel [Wed, 3 Oct 2018 19:52:00 +0000 (21:52 +0200)]
Fix #1292/1294 by snapping to any edge when not hovering over a signal

1292: TimeItem instances now snap to any edge when not hovering over a
      signal, including the ruler itself. Hence, there is always an area
      where one can hover without selecting a signal, even if the entire
      view is full of signals.
      Cursors also show the desired behavior: the left edge snaps while
      the right does not. Hence, the width is kept constant. If the user
      wants to snap the right edge to a signal edge, this can be achieved
      by dragging the right edge separately.

1294: TimeItem instances now snap to any edge - before, they were snapping
      only to edges when hovering over a signal.

3 years agoView: Make TimeItem derivatives snap to edges when ruler-dragged
Soeren Apel [Mon, 1 Oct 2018 07:21:59 +0000 (09:21 +0200)]
View: Make TimeItem derivatives snap to edges when ruler-dragged

Without this change, the snap-to-edge feature doesn't work
when TimeItem derivatives are dragged in the ruler.

3 years agomanual: Add a short Mac OS X install text.
Uwe Hermann [Wed, 3 Oct 2018 19:24:24 +0000 (21:24 +0200)]
manual: Add a short Mac OS X install text.

3 years agomanual: Various minor fixes.
Uwe Hermann [Wed, 3 Oct 2018 18:47:22 +0000 (20:47 +0200)]
manual: Various minor fixes.

3 years agoFix unit tests
Soeren Apel [Sat, 29 Sep 2018 15:15:58 +0000 (17:15 +0200)]
Fix unit tests

3 years agoApplication::print_version_info(): Minor output whitespace fixes.
Uwe Hermann [Sat, 29 Sep 2018 11:47:23 +0000 (13:47 +0200)]
Application::print_version_info(): Minor output whitespace fixes.

3 years agoFix #1213 by improving the version information handling
Soeren Apel [Fri, 28 Sep 2018 21:59:18 +0000 (23:59 +0200)]
Fix #1213 by improving the version information handling

3 years agoAdd setting for the snap-to-edge distance
Soeren Apel [Wed, 26 Sep 2018 21:41:53 +0000 (23:41 +0200)]
Add setting for the snap-to-edge distance

3 years agoFix #684 by implementing snap-to-edge for TimeItem-based classes
Soeren Apel [Wed, 26 Sep 2018 20:50:24 +0000 (22:50 +0200)]
Fix #684 by implementing snap-to-edge for TimeItem-based classes

3 years agoImplement LogicSegment::get_surrounding_edges() and use it
Soeren Apel [Mon, 2 Jul 2018 17:57:10 +0000 (19:57 +0200)]
Implement LogicSegment::get_surrounding_edges() and use it

4 years agoManual: Describe sticky scrolling
Soeren Apel [Sat, 22 Sep 2018 20:29:38 +0000 (22:29 +0200)]
Manual: Describe sticky scrolling

4 years agoLogging: avoid "cb was NULL" warning message during logging shutdown
Gerhard Sittig [Tue, 18 Sep 2018 16:34:42 +0000 (18:34 +0200)]
Logging: avoid "cb was NULL" warning message during logging shutdown

Commit 4b9234088f56 introduced the fetch and restore of the libraries'
default log routines in addition to the registration of a Pulseview
application's log routine. Some code paths in main() could result in
unexpected "cb was NULL" messages on stderr, when logging::init() did
not execute but the destructor tried to restore a handler which was not
fetched before. Silence the error message.

4 years agoDecodeTrace: Rename get_sample_range() to get_view_sample_range()
Soeren Apel [Thu, 13 Sep 2018 18:19:14 +0000 (20:19 +0200)]
DecodeTrace: Rename get_sample_range() to get_view_sample_range()

4 years agoInclude suggested changes by clang-tidy
Soeren Apel [Thu, 13 Sep 2018 18:10:01 +0000 (20:10 +0200)]
Include suggested changes by clang-tidy

4 years agoFix #1270 by replacing insignificant characters before comparing
Soeren Apel [Thu, 6 Sep 2018 07:25:13 +0000 (09:25 +0200)]
Fix #1270 by replacing insignificant characters before comparing

4 years agomanual/generate: Always generate a PDF manual as well by default.
Uwe Hermann [Thu, 6 Sep 2018 07:50:57 +0000 (09:50 +0200)]
manual/generate: Always generate a PDF manual as well by default.

4 years agodevice.cpp: Add SR_CONF_AVG_SAMPLES.
Uwe Hermann [Wed, 5 Sep 2018 19:46:11 +0000 (21:46 +0200)]
device.cpp: Add SR_CONF_AVG_SAMPLES.

4 years agodevice.cpp: Add SR_CONF_AVERAGING.
Uwe Hermann [Wed, 5 Sep 2018 18:45:39 +0000 (20:45 +0200)]
device.cpp: Add SR_CONF_AVERAGING.

4 years agoLogging: Write messages from qDebug() and friends also to stdout
Soeren Apel [Wed, 5 Sep 2018 08:22:23 +0000 (10:22 +0200)]
Logging: Write messages from qDebug() and friends also to stdout

4 years agoBinding: Add help icons for entries with descriptions
Soeren Apel [Tue, 4 Sep 2018 20:39:57 +0000 (22:39 +0200)]
Binding: Add help icons for entries with descriptions

4 years agoManual: Initial revision
Soeren Apel [Tue, 4 Sep 2018 07:09:34 +0000 (09:09 +0200)]
Manual: Initial revision

4 years agoSettings: Fix description text
Soeren Apel [Sun, 2 Sep 2018 19:36:23 +0000 (21:36 +0200)]
Settings: Fix description text

When %q is used, we don't just encapsulate annotation texts in
quotation marks, we encapsulate all fields.

4 years agoDecodeSignal: Unpause reliably
Soeren Apel [Sun, 2 Sep 2018 19:34:50 +0000 (21:34 +0200)]
DecodeSignal: Unpause reliably

4 years agomanpage: Drop obsolete -s|--log-to-stdout docs.
Uwe Hermann [Thu, 30 Aug 2018 20:15:19 +0000 (22:15 +0200)]
manpage: Drop obsolete -s|--log-to-stdout docs.

4 years agoAndroid: implement chained log callbacks (buffer and terminal output)
Gerhard Sittig [Mon, 20 Aug 2018 16:57:25 +0000 (18:57 +0200)]
Android: implement chained log callbacks (buffer and terminal output)

Query the libraries' default log handlers before registering the
application's own handler. Queue log messages in the application's
internal buffer _and_ hand them to the default handlers which send
the text to stdout as well.

4 years agoLogging: obsolete -s, log to internal buffer as well as stdout
Gerhard Sittig [Wed, 15 Aug 2018 21:48:52 +0000 (23:48 +0200)]
Logging: obsolete -s, log to internal buffer as well as stdout

Query the sr and srd libraries' current log routines before registering
PV's own log callback which queues messages in an internal buffer. This
allows duplication of messages to the internal buffer _and_ stdout, and
thus obsoletes the -s option.

4 years agopulseview.qrc: Add missing files.
Uwe Hermann [Tue, 28 Aug 2018 06:29:30 +0000 (08:29 +0200)]
pulseview.qrc: Add missing files.

4 years agoImplement decode pausing/resuming
Soeren Apel [Wed, 22 Aug 2018 07:33:48 +0000 (09:33 +0200)]
Implement decode pausing/resuming

4 years agoFix two warnings
Soeren Apel [Tue, 21 Aug 2018 19:04:22 +0000 (21:04 +0200)]
Fix two warnings

4 years agoFix item dragging
Soeren Apel [Mon, 20 Aug 2018 19:19:18 +0000 (21:19 +0200)]
Fix item dragging

4 years agoReplace (double)0 by 0.0
Soeren Apel [Mon, 20 Aug 2018 14:01:48 +0000 (16:01 +0200)]
Replace (double)0 by 0.0

4 years agoAnalogSignal: Set initial value for the "value at cursor" variable
Soeren Apel [Mon, 20 Aug 2018 13:57:33 +0000 (15:57 +0200)]
AnalogSignal: Set initial value for the "value at cursor" variable

Without this, the analog traces show random values after startup
until the mouse cursor enters the application window and the cursor
position updates.

4 years agoFix #1259 by not silently ignoring file read errors
Soeren Apel [Wed, 15 Aug 2018 07:28:35 +0000 (09:28 +0200)]
Fix #1259 by not silently ignoring file read errors

4 years agoEnum: Use slider instead of combo box for contiguous ranges
Soeren Apel [Tue, 14 Aug 2018 08:01:34 +0000 (10:01 +0200)]
Enum: Use slider instead of combo box for contiguous ranges

4 years agoMainBar: Disallow negative sample rates
Soeren Apel [Fri, 10 Aug 2018 21:35:38 +0000 (23:35 +0200)]
MainBar: Disallow negative sample rates

4 years agoMainBar: Disable custom samplerate by default
Soeren Apel [Fri, 10 Aug 2018 21:31:49 +0000 (23:31 +0200)]
MainBar: Disable custom samplerate by default

Without this, the edit may be left in editable mode once the
external clock was enabled and disabled again.

4 years agoMainBar: Fix warning message introduced by bc4b9ccfc78d9d0
Soeren Apel [Fri, 10 Aug 2018 21:28:22 +0000 (23:28 +0200)]
MainBar: Fix warning message introduced by bc4b9ccfc78d9d0

"sr: hwdriver: Option 'external_clock' not available for this device instance."
Avoid this message by checking if the EXTERNAL_CLOCK property is actually
supplied by the driver.

4 years agoDecodeTrace: Implement annotation export for cursor range
Soeren Apel [Fri, 10 Aug 2018 18:08:36 +0000 (20:08 +0200)]
DecodeTrace: Implement annotation export for cursor range

4 years agoFix regression introduced by 2980ff2da269c9ed
Soeren Apel [Fri, 10 Aug 2018 15:51:48 +0000 (17:51 +0200)]
Fix regression introduced by 2980ff2da269c9ed

The regression was that when clicking+dragging on a trace in the
trace view area, the individual trace was moving, not the view area
itself. This was unintended.

4 years agoSegment: Catch by reference
Soeren Apel [Tue, 7 Aug 2018 18:09:22 +0000 (20:09 +0200)]
Segment: Catch by reference

4 years agoImplement annotation export for all rows
Soeren Apel [Mon, 6 Aug 2018 19:25:59 +0000 (21:25 +0200)]
Implement annotation export for all rows

Needed parts are:
1) Annotations must have a reference to the row they belong to
2) DecodeSignal must offer a method to return annotations for all rows
3) Annotations must become comparable to allow for sorting
4) DecodeTrace must handle the different annotation export cases

4 years agoMake annotation export customizable
Soeren Apel [Sun, 5 Aug 2018 20:15:07 +0000 (22:15 +0200)]
Make annotation export customizable

4 years agoImplement annotation export from the DecodeTrace context menu
Soeren Apel [Sun, 5 Aug 2018 16:18:22 +0000 (18:18 +0200)]
Implement annotation export from the DecodeTrace context menu

4 years agoRename create_context_menu() to create_header_context_menu()
Soeren Apel [Thu, 2 Aug 2018 07:08:57 +0000 (09:08 +0200)]
Rename create_context_menu() to create_header_context_menu()

4 years agoAllow for a context menu in the view area
Soeren Apel [Thu, 2 Aug 2018 06:56:51 +0000 (08:56 +0200)]
Allow for a context menu in the view area

4 years agoFix #1204 by making sure the lazy event handler is fired
Soeren Apel [Wed, 25 Jul 2018 11:19:56 +0000 (13:19 +0200)]
Fix #1204 by making sure the lazy event handler is fired

The QTimer reference says about QTimer::start():

> Starts or restarts the timer with the timeout specified in interval.
> If the timer is already running, it will be stopped and restarted.
> If singleShot is true, the timer will be activated only once.

This suggests that the timer is reset when start() is called even
when it is in single shot mode. However, this is actually not the case
and start() doesn't appear to be doing anything if it has already
been started. While this works in most cases, it causes issues when
the timer is supposed to be reset and timeout at the specified time
since view items are still in flux.

Adding a stop() before the start() fixes this.

4 years agoabout: Layout change to use space more efficiently.
Uwe Hermann [Sun, 19 Aug 2018 16:40:43 +0000 (18:40 +0200)]
about: Layout change to use space more efficiently.

4 years agoabout: Merge all version info into one section.
Uwe Hermann [Sun, 19 Aug 2018 15:46:18 +0000 (17:46 +0200)]
about: Merge all version info into one section.

4 years agoabout: move Pulseview version information into the text box
Gerhard Sittig [Sat, 18 Aug 2018 15:47:03 +0000 (17:47 +0200)]
about: move Pulseview version information into the text box

Move the application's version information out of the caption and into
the text box. So that it resides with the libraries' version information,
and is accessible via clipboard for reports.

This addresses part of bug #1213, and fixes all of #1264.

4 years agoCMakeLists.txt: Set DISABLE_WERROR to TRUE by default.
Uwe Hermann [Sun, 19 Aug 2018 15:36:04 +0000 (17:36 +0200)]
CMakeLists.txt: Set DISABLE_WERROR to TRUE by default.

There's various compile problems that can result from building with
-Werror on by default, which are outside of our control (e.g. that need
to be fixed in external libraries), for example #1144 or 1145.

4 years agoHardwareDevice: Only show non-empty device name components.
Uwe Hermann [Tue, 24 Jul 2018 20:07:25 +0000 (22:07 +0200)]
HardwareDevice: Only show non-empty device name components.

Fields such as vendor, version, serial number etc. are not always
provided by drivers. Avoid printing them, since it causes stray
whitespace to be added to the displayed strings.

4 years agoHardwareDevice: Make serial number display a bit clearer.
Uwe Hermann [Tue, 24 Jul 2018 19:35:26 +0000 (21:35 +0200)]
HardwareDevice: Make serial number display a bit clearer.

4 years agoFix the build - catch exceptions by reference
Brian Starkey [Sat, 21 Jul 2018 17:08:45 +0000 (18:08 +0100)]
Fix the build - catch exceptions by reference

Fix the following build errors seen with gcc 8.1.1:

 error: catching polymorphic type ‘class std::out_of_range’ by value
 error: catching polymorphic type ‘class boost::archive::archive_exception’ by value

Signed-off-by: Brian Starkey <stark3y@gmail.com>
4 years agoFix #1146 by replacing the check box by a combo box
Soeren Apel [Fri, 20 Jul 2018 17:47:58 +0000 (19:47 +0200)]
Fix #1146 by replacing the check box by a combo box

4 years agoRemove non-functional remains of the scale drag handle
Soeren Apel [Thu, 19 Jul 2018 17:00:31 +0000 (19:00 +0200)]
Remove non-functional remains of the scale drag handle

4 years agoChannel popup: Don't disable channels when clicking the enable buttons
Soeren Apel [Tue, 17 Jul 2018 20:09:51 +0000 (22:09 +0200)]
Channel popup: Don't disable channels when clicking the enable buttons

4 years agoView: Don't set scroll defaults more than once
Soeren Apel [Tue, 17 Jul 2018 16:45:12 +0000 (18:45 +0200)]
View: Don't set scroll defaults more than once

4 years agoMake sure PD row colors remain constant by adding a row index
Soeren Apel [Mon, 16 Jul 2018 16:27:54 +0000 (18:27 +0200)]
Make sure PD row colors remain constant by adding a row index

Without this change, PD row colors depend on the visible rows,
not a constant ID. This means that rows that collapse change the
colors of all rows coming after them.

4 years agoAccept user-entered sample rates when external clock is enabled
Soeren Apel [Thu, 12 Jul 2018 17:32:33 +0000 (19:32 +0200)]
Accept user-entered sample rates when external clock is enabled

4 years agoProperly handle decoder errors
Soeren Apel [Mon, 9 Jul 2018 19:41:30 +0000 (21:41 +0200)]
Properly handle decoder errors

4 years agoDecodeSignal: Add and use inclusive/exclusive sample count variant
Soeren Apel [Fri, 18 May 2018 20:16:00 +0000 (22:16 +0200)]
DecodeSignal: Add and use inclusive/exclusive sample count variant

This is needed because the annotation cache must be operating on the
number of decoded samples WITHOUT the ones being currently processed,
otherwise it'll refuse to refresh the cache, even if more annotations
arrive - it uses the sample count to determine the cache state.

However, the bar showing the undecoded area must operate on the number
of samples WITH the ones being currently processed so that annotations
aren't overlapping with it.

Adding the parameter to DecodeSignal::get_decoded_sample_count() allows
for both.

This relates to e06cf18db72.

4 years agoConnect dialog: Let the device list occupy only the minimum space needed
Soeren Apel [Tue, 3 Jul 2018 16:24:40 +0000 (18:24 +0200)]
Connect dialog: Let the device list occupy only the minimum space needed

4 years agoLogicSignal: Don't paint hover marker if channel is disabled
Soeren Apel [Thu, 21 Jun 2018 18:23:08 +0000 (20:23 +0200)]
LogicSignal: Don't paint hover marker if channel is disabled

4 years agoFix #975 by overallocating memory to leave spare for PV to use
Soeren Apel [Wed, 30 May 2018 21:56:29 +0000 (23:56 +0200)]
Fix #975 by overallocating memory to leave spare for PV to use

4 years agocmake: help users by pointing out libsigrok build depencendies
Gerhard Sittig [Tue, 3 Jul 2018 14:46:57 +0000 (16:46 +0200)]
cmake: help users by pointing out libsigrok build depencendies

It appears that users have trouble to relate failed PulseView builds to
missing dependencies during libsigrok configuration. Although the error
occurs early and is stated in the build output, it only gets noticed
late and users forgot about the earlier step, or never bothered to check.

Explicitly test for the availability of the C++ bindings, and print a
message that points to libsigrok's(!) configuration phase. Another
check for the full set of libraries will fail in fatal ways as before.

An unfortunate implementation detail of the cmake check leaves all parts
of the lookup result empty when either(!) of the tested libs is missing.
So we cannot tell with certainty which test failed when the test result
is negative while a list of libraries was passed to the test. That's why
the "soft" individual test with QUIET and without REQUIRED is the least
intrusive adjustment to existing CMake rules, where other locations
depend on the PKGDEPS_* variables.

This change addresses bug #1199.

4 years agocmake: nit, use the message(STATUS) keyword
Gerhard Sittig [Sun, 6 May 2018 09:29:57 +0000 (11:29 +0200)]
cmake: nit, use the message(STATUS) keyword

4 years agomain.cpp: straighten the getopt/optind adjustment before openfiles
Gerhard Sittig [Wed, 6 Jun 2018 16:50:26 +0000 (18:50 +0200)]
main.cpp: straighten the getopt/optind adjustment before openfiles

The pulseview(1) application accepts input file specs either as argument
to the -i option, or as positional arguments after the command line options.

Simplify the logic which collects remaining non-option command line words
after getopt(3) is done. As a byproduct the application code no longer
manipulates a variable that is owned by an external library.

4 years agoanalogsignal.cpp: Fix std::isnan() related compile issue on some systems
Gerhard Sittig [Sun, 17 Jun 2018 16:45:47 +0000 (18:45 +0200)]
analogsignal.cpp: Fix std::isnan() related compile issue on some systems

Re-do for recent source what commit f9abacf20c85 did to solve bug #531.
Explicitly use std::isnan() in checks. Avoid the 'using' directive since
not all platforms that are supported by sigrok do support it.

  pv/views/trace/analogsignal.cpp:54:12: error: 'isnan' is already declared in this scope

4 years agoFix comment
Soeren Apel [Thu, 14 Jun 2018 19:42:13 +0000 (21:42 +0200)]
Fix comment

4 years agoFix up change handler registration
Soeren Apel [Thu, 14 Jun 2018 19:05:07 +0000 (21:05 +0200)]
Fix up change handler registration

Before, the mismatched registration/deregistration lead to
crashes. Example:

Load file, load another file into the same session,
change any setting -> crash because first change notifier is
called but invalid

4 years agoPrevent log length to be set to 0
Soeren Apel [Thu, 14 Jun 2018 15:41:02 +0000 (17:41 +0200)]
Prevent log length to be set to 0

Doing so prevents PV from starting up, so disallow it