pulseview.git
2 years agoDecodeSignal: Rename some items
Soeren Apel [Thu, 23 Nov 2017 17:30:26 +0000 (18:30 +0100)]
DecodeSignal: Rename some items

2 years agoBegin PD multisegment support
Soeren Apel [Tue, 21 Nov 2017 21:07:09 +0000 (22:07 +0100)]
Begin PD multisegment support

2 years agoMove current_segment_ to Trace
Soeren Apel [Tue, 21 Nov 2017 21:07:09 +0000 (22:07 +0100)]
Move current_segment_ to Trace

2 years agoFlesh out segment display mode handling
Soeren Apel [Mon, 20 Nov 2017 21:50:53 +0000 (22:50 +0100)]
Flesh out segment display mode handling

2 years agoImplement segment display mode handling and update notifications
Soeren Apel [Tue, 7 Nov 2017 09:56:25 +0000 (10:56 +0100)]
Implement segment display mode handling and update notifications

2 years agoDon't set SR_CONF_LIMIT_FRAMES to 1
Soeren Apel [Fri, 15 Dec 2017 22:56:39 +0000 (23:56 +0100)]
Don't set SR_CONF_LIMIT_FRAMES to 1

2 years agoMake it pass desktop-file-validate
probonopd [Fri, 24 Nov 2017 20:56:17 +0000 (20:56 +0000)]
Make it pass desktop-file-validate

https://travis-ci.org/AppImage/appimage.github.io/builds/306921880#L695

2 years agoDecodeSignal: Make sure bit IDs are always up-to-date
Soeren Apel [Tue, 12 Dec 2017 22:31:35 +0000 (23:31 +0100)]
DecodeSignal: Make sure bit IDs are always up-to-date

https://www.youtube.com/watch?v=mw6Bd6Hv168 shows what
happens when this isn't done.

2 years agoSession: Fix mismatched delete operator.
Philipp Marek [Sat, 18 Nov 2017 12:53:24 +0000 (13:53 +0100)]
Session: Fix mismatched delete operator.

Mismatched free() / delete / delete []
   at 0x4C2D31B: operator delete(void*) (vg_replace_malloc.c:576)
   by 0x1C76D0: operator() (unique_ptr.h:78)
   by 0x1C76D0: ~unique_ptr (unique_ptr.h:268)
   by 0x1C76D0: pv::data::AnalogSegment::append_interleaved_samples(float const*, unsigned long, unsigned long) (analogsegment.cpp:78)
...
Address 0x1d123f70 is 0 bytes inside a block of size 312 alloc'd
   at 0x4C2C97F: operator new[](unsigned long) (vg_replace_malloc.c:423)
   by 0x1C765E: pv::data::AnalogSegment::append_interleaved_samples(float const*, unsigned long, unsigned long) (analogsegment.cpp:78)
   by 0x1AFDD5: pv::Session::feed_in_analog(std::shared_ptr<sigrok::Analog>) (session.cpp:1142)

2 years ago.gitignore: Don't care about the doxygen-generated files.
Philipp Marek [Sat, 18 Nov 2017 12:53:12 +0000 (13:53 +0100)]
.gitignore: Don't care about the doxygen-generated files.

2 years agoSession: Fix mismatched delete operator.
Philipp Marek [Fri, 17 Nov 2017 10:17:36 +0000 (11:17 +0100)]
Session: Fix mismatched delete operator.

Valgrind reported this here:

Mismatched free() / delete / delete []
   at 0x4C2D31B: operator delete(void*) (vg_replace_malloc.c:576)
   by 0x1C76D0: operator() (unique_ptr.h:78)
   by 0x1C76D0: ~unique_ptr (unique_ptr.h:268)
   by 0x1C76D0: pv::data::AnalogSegment::append_interleaved_samples(float const*, unsigned long, unsigned long) (analogsegment.cpp:78)
   by 0x1AFDD5: pv::Session::feed_in_analog(std::shared_ptr<sigrok::Analog>) (session.cpp:1142)
   by 0x1B043C: pv::Session::data_feed_in(std::shared_ptr<sigrok::Device>, std::shared_ptr<sigrok::Packet>) (session.cpp:1187)
...
 Address 0x1cbf6b90 is 0 bytes inside a block of size 940 alloc'd
   at 0x4C2C97F: operator new[](unsigned long) (vg_replace_malloc.c:423)
   by 0x1C765E: pv::data::AnalogSegment::append_interleaved_samples(float const*, unsigned long, unsigned long) (analogsegment.cpp:78)
   by 0x1AFDD5: pv::Session::feed_in_analog(std::shared_ptr<sigrok::Analog>) (session.cpp:1142)

2 years agoRework new segment notification mechanism
Soeren Apel [Sun, 29 Oct 2017 22:38:06 +0000 (23:38 +0100)]
Rework new segment notification mechanism

2 years agoAppend new segments to the end, not the beginning of the list
Soeren Apel [Fri, 27 Oct 2017 16:44:51 +0000 (18:44 +0200)]
Append new segments to the end, not the beginning of the list

2 years agoSession: Query the device's sample rate when needed, not sooner
Soeren Apel [Mon, 9 Oct 2017 15:47:19 +0000 (17:47 +0200)]
Session: Query the device's sample rate when needed, not sooner

2 years agoDecodeSignal: Remove outdated code and comment
Soeren Apel [Sat, 23 Sep 2017 06:33:16 +0000 (08:33 +0200)]
DecodeSignal: Remove outdated code and comment

2 years agoSignalBase: Make sure PDs are restarted when conv options change
Soeren Apel [Fri, 22 Sep 2017 16:25:06 +0000 (18:25 +0200)]
SignalBase: Make sure PDs are restarted when conv options change

2 years agoTraceView: Properly handle the header resizing events
Soeren Apel [Fri, 22 Sep 2017 06:27:56 +0000 (08:27 +0200)]
TraceView: Properly handle the header resizing events

2 years agoTraceView: Make header resize state determination reliable
Soeren Apel [Fri, 22 Sep 2017 06:24:17 +0000 (08:24 +0200)]
TraceView: Make header resize state determination reliable

2 years agoView: Move comment to where it belongs
Soeren Apel [Tue, 19 Sep 2017 05:50:50 +0000 (07:50 +0200)]
View: Move comment to where it belongs

2 years agoAdjust trace view header width when signal names change
Soeren Apel [Tue, 19 Sep 2017 05:48:36 +0000 (07:48 +0200)]
Adjust trace view header width when signal names change

This change is primarily needed because before, newly
created decode signals had a name assigned to them at time
of the constructor call. This changed, and now the name
is empty upon creation, breaking the previously working
header size adjustment.

2 years agoDecodeTrace: Reset cached trace properties when decoder stack resets
Soeren Apel [Sat, 9 Sep 2017 07:01:07 +0000 (09:01 +0200)]
DecodeTrace: Reset cached trace properties when decoder stack resets

2 years agoDecodeSignal: Break up annotation storage to allow multiple segments
Soeren Apel [Sat, 9 Sep 2017 06:42:36 +0000 (08:42 +0200)]
DecodeSignal: Break up annotation storage to allow multiple segments

2 years agoImplement showing only the selected segment
Soeren Apel [Thu, 31 Aug 2017 06:24:53 +0000 (08:24 +0200)]
Implement showing only the selected segment

2 years agoAdd segment selector UI + helpers
Soeren Apel [Sun, 10 Sep 2017 19:26:59 +0000 (21:26 +0200)]
Add segment selector UI + helpers

2 years agorowdata: Use emplace_back() for Annotation objects.
Uwe Hermann [Wed, 2 Aug 2017 06:14:31 +0000 (08:14 +0200)]
rowdata: Use emplace_back() for Annotation objects.

This should eliminate one unnecessary allocation per annotation.

2 years agoRename DecodeSignal::segment_ to logic_mux_segment_ for clarity
Soeren Apel [Fri, 1 Sep 2017 06:21:10 +0000 (08:21 +0200)]
Rename DecodeSignal::segment_ to logic_mux_segment_ for clarity

2 years agoFix #1024 by changing decode channel assigment to PDs
Soeren Apel [Fri, 8 Sep 2017 16:14:47 +0000 (18:14 +0200)]
Fix #1024 by changing decode channel assigment to PDs

When assigning the decoder stack channels to the libsrd
instance's channels, channels that had no signal assigned
to them were still assigned anyway. This patch fixes this bug.

After doing this, another subtle bug became apparent:
The mapping between channels and bits in the data stream sent
to the PD was done via DecodeChannel->id. This is however
insufficient as the channels of the decoder stack have
IDs that may or may not match the ID needed for the data
stream. Example:

A PD has 4 channels: A, B, C and D. In PV, those channels
have the IDs 0, 1, 2 and 3. If the user only assigns A and D,
Decoder::create_decoder_inst() will use the IDs 0 and 3 as
the bit positions of those signals in the data stream sent
to libsrd. This is obviously wrong.

Hence, we now use a separate bit_id for this purpose.

2 years agoAnalogSignal: Prevent threshold bg from spilling beyond extents
Soeren Apel [Mon, 21 Aug 2017 17:58:49 +0000 (19:58 +0200)]
AnalogSignal: Prevent threshold bg from spilling beyond extents

2 years agoImplement "show conversion thresholds as dots" mode
Soeren Apel [Sat, 19 Aug 2017 21:58:36 +0000 (23:58 +0200)]
Implement "show conversion thresholds as dots" mode

2 years agoConvert threshold display setting to a multi-value choice
Soeren Apel [Sun, 20 Aug 2017 14:18:50 +0000 (16:18 +0200)]
Convert threshold display setting to a multi-value choice

2 years agoAnalogSignal: Make threshold neutral area darker
Soeren Apel [Thu, 17 Aug 2017 06:30:29 +0000 (08:30 +0200)]
AnalogSignal: Make threshold neutral area darker

2 years agoSession: Rework frame handling
Soeren Apel [Mon, 14 Aug 2017 15:52:43 +0000 (17:52 +0200)]
Session: Rework frame handling

2 years agoAnalogSignal: Use setting change handler for threshold display
Soeren Apel [Tue, 8 Aug 2017 17:40:11 +0000 (19:40 +0200)]
AnalogSignal: Use setting change handler for threshold display

2 years agoAnalogSignal: Draw analog thresholds differently
Soeren Apel [Mon, 7 Aug 2017 19:41:11 +0000 (21:41 +0200)]
AnalogSignal: Draw analog thresholds differently

Instead of using a patterned region on top of the trace,
show the thresholds by using different background colors
for the individual areas: green/grey/red.

2 years agoView: Update ruler after restoring session
Soeren Apel [Sat, 5 Aug 2017 20:38:45 +0000 (22:38 +0200)]
View: Update ruler after restoring session

If we don't do this, the ruler is out-of-sync with the rest
of the view until the session is loaded and goes into stopped
state. At that point, the ruler is updated, which is too late.

2 years agoSignalBase: Default to dynamic conversion preset, not custom values
Soeren Apel [Wed, 2 Aug 2017 16:42:34 +0000 (18:42 +0200)]
SignalBase: Default to dynamic conversion preset, not custom values

The reason for this change is that when you initially select a
conversion from the channel config popup dialog, the threshold
will be set to "0.0V" or "0.0V/0.0V", respectively.
This is of course not what we want and the root cause is that
when no preset is selected, NoPreset is assumed instead of
DynamicPreset. This patch changes this.

2 years agoUse min/max notification for autoranging of analog signals
Soeren Apel [Wed, 2 Aug 2017 16:23:32 +0000 (18:23 +0200)]
Use min/max notification for autoranging of analog signals

2 years agoMove delayed conversion starter to SignalBase
Soeren Apel [Wed, 2 Aug 2017 07:15:18 +0000 (09:15 +0200)]
Move delayed conversion starter to SignalBase

This way, we can use the same mechanism for changing
min/max as well, preventing multiple successive starts
of the conversion algorithm.
Preventing this is necessary because it makes the UI
stop updating for a significant amount of time, which
we obviously don't want.

2 years agoRemove SignalBase::A2LChannel
Soeren Apel [Tue, 1 Aug 2017 19:38:15 +0000 (21:38 +0200)]
Remove SignalBase::A2LChannel

2 years agoUse identifiers for fixed conversion preset values
Soeren Apel [Tue, 1 Aug 2017 19:35:15 +0000 (21:35 +0200)]
Use identifiers for fixed conversion preset values

2 years agoRestart min-max-based conversion if min or max change
Soeren Apel [Tue, 1 Aug 2017 18:58:46 +0000 (20:58 +0200)]
Restart min-max-based conversion if min or max change

2 years agoFix some random clang-tidy warnings.
Uwe Hermann [Tue, 1 Aug 2017 20:19:56 +0000 (22:19 +0200)]
Fix some random clang-tidy warnings.

2 years agoTrace view: Make the zero line for analog traces thicker
Soeren Apel [Mon, 31 Jul 2017 22:09:06 +0000 (00:09 +0200)]
Trace view: Make the zero line for analog traces thicker

This is to make it stand out more and make it easily
distinguishable.

2 years agoImplement graphical display of A2L thresholds
Soeren Apel [Mon, 31 Jul 2017 20:31:54 +0000 (22:31 +0200)]
Implement graphical display of A2L thresholds

2 years agoTypo fix: treshold -> threshold
Soeren Apel [Sat, 29 Jul 2017 17:44:59 +0000 (19:44 +0200)]
Typo fix: treshold -> threshold

2 years agoAnalogSignal: Reword "traces to show" option
Soeren Apel [Sat, 29 Jul 2017 17:41:31 +0000 (19:41 +0200)]
AnalogSignal: Reword "traces to show" option

2 years agoAnalogSignal: Use pv::data::SignalBase namespace
Soeren Apel [Sat, 29 Jul 2017 17:33:47 +0000 (19:33 +0200)]
AnalogSignal: Use pv::data::SignalBase namespace

2 years agoImplement A2L presets and custom threshold handling
Soeren Apel [Mon, 31 Jul 2017 20:31:20 +0000 (22:31 +0200)]
Implement A2L presets and custom threshold handling

2 years agoUse getter for the conversion type instead of a local copy
Soeren Apel [Tue, 25 Jul 2017 14:09:08 +0000 (16:09 +0200)]
Use getter for the conversion type instead of a local copy

Don't ask me why I used a local copy in the first place,
even I can't figure it out :)

2 years agoSignalBase: Minor doxygen comments
Soeren Apel [Mon, 24 Jul 2017 06:57:51 +0000 (08:57 +0200)]
SignalBase: Minor doxygen comments

2 years agoTrace View: Add doxygen comments to some classes
Soeren Apel [Sun, 23 Jul 2017 20:17:16 +0000 (22:17 +0200)]
Trace View: Add doxygen comments to some classes

2 years agoImprove hover point signaling
Soeren Apel [Sun, 23 Jul 2017 07:35:25 +0000 (09:35 +0200)]
Improve hover point signaling

Two issues here:
1) it's bad style to have an event handler for an event
that was triggered in the same class
2) supplying the current hover point along with the event
is a sensible thing to do

2 years agoRemove signal scale handle
Soeren Apel [Thu, 20 Jul 2017 06:45:06 +0000 (08:45 +0200)]
Remove signal scale handle

It will be replaced by a different mechanism.

2 years agoTriggerMarker: Don't return "valid" drag point coordinates
Soeren Apel [Tue, 18 Jul 2017 18:40:33 +0000 (20:40 +0200)]
TriggerMarker: Don't return "valid" drag point coordinates

2 years agoRename ViewItem::point() to ViewItem::drag_point() for clarity
Soeren Apel [Tue, 18 Jul 2017 15:51:01 +0000 (17:51 +0200)]
Rename ViewItem::point() to ViewItem::drag_point() for clarity

2 years agoINSTALL/CMakeLists.txt: Bump libsigrokdecode requirement to >= 0.6.0.
Uwe Hermann [Fri, 21 Jul 2017 05:08:06 +0000 (07:08 +0200)]
INSTALL/CMakeLists.txt: Bump libsigrokdecode requirement to >= 0.6.0.

PulseView now relies on e.g. the fact that multiple libsigrokdecode
calls from different threads don't cause issues (which has not been the
case prior to libsigrokdecode 0.6.0).

2 years agoCMakeLists.txt: Bump libsigrokcxx requirement to 0.6.0.
Uwe Hermann [Fri, 21 Jul 2017 05:07:10 +0000 (07:07 +0200)]
CMakeLists.txt: Bump libsigrokcxx requirement to 0.6.0.

This was already documented in INSTALL, but the check wasn't updated.

2 years agoFix the build with ENABLE_DECODE=n.
Uwe Hermann [Wed, 19 Jul 2017 18:55:59 +0000 (20:55 +0200)]
Fix the build with ENABLE_DECODE=n.

  pv/dialogs/settings.cpp: In member function ‘QWidget* pv::dialogs::Settings::get_decoder_settings_form(QWidget*) const’:
  pv/dialogs/settings.cpp:218:1: error: no return statement in function returning non-void [-Werror=return-type]

2 years agoLogicSignal: Make trace height adjustable
Soeren Apel [Sun, 16 Jul 2017 20:09:19 +0000 (22:09 +0200)]
LogicSignal: Make trace height adjustable

2 years agoIntroduce "logic trace height" setting
Soeren Apel [Sun, 16 Jul 2017 19:29:26 +0000 (21:29 +0200)]
Introduce "logic trace height" setting

2 years agoAnalogSignal: Make div height adjustable
Soeren Apel [Sun, 16 Jul 2017 20:10:16 +0000 (22:10 +0200)]
AnalogSignal: Make div height adjustable

2 years agoIntroduce "default div height" setting
Soeren Apel [Sun, 16 Jul 2017 17:14:16 +0000 (19:14 +0200)]
Introduce "default div height" setting

2 years agoDecodeTrace: Resize trace when hiding/deleting a stacked PD
Soeren Apel [Fri, 14 Jul 2017 16:24:32 +0000 (18:24 +0200)]
DecodeTrace: Resize trace when hiding/deleting a stacked PD

The trace height depends on DecodeTrace::max_visible_rows_,
which needs to be updated when a stacked PD is hidden or
deleted. In order to do this, we reset max_visible_rows_ to
0 and then request a repaint.

2 years agoDecodeTrace: Fix trace resizing when new annotation classes appear
Soeren Apel [Fri, 14 Jul 2017 06:46:21 +0000 (08:46 +0200)]
DecodeTrace: Fix trace resizing when new annotation classes appear

2 years agoMake restack_items() available to all TraceTreeItemOwners
Soeren Apel [Fri, 14 Jul 2017 06:40:04 +0000 (08:40 +0200)]
Make restack_items() available to all TraceTreeItemOwners

Currently, TTIO:restack_items() is empty and only the
TraceGroup actually implements it. For this reason, decode
traces (and analog traces) are correctly pushing other traces
around when their size changes.
Top-level traces that are not part of a group however aren't
handled properly, simply overlapping when they grow.

This patch makes the code available to all TTIO-derived
classes, allowing all owners (including View itself) to
properly handle this event.

2 years agoDecodeTrace: Don't show tooltips destined for the header area
Soeren Apel [Wed, 12 Jul 2017 07:05:39 +0000 (09:05 +0200)]
DecodeTrace: Don't show tooltips destined for the header area

2 years agoDecodeSignal: Don't set name when creating the signal
Soeren Apel [Mon, 10 Jul 2017 17:14:35 +0000 (19:14 +0200)]
DecodeSignal: Don't set name when creating the signal

The thought behind this was to have no unnamed signals because
this may make debugging harder. However, giving the signal a
long name and shortening it when decoders are added isn't working
well. The reason is that the width of the header area can be
expanded programmatically but we don't shrink it because we
don't want to hide things the user may want to see.
This behavior in turn leads to the header width expanding when
a signal labeled "Empty decoder signal" is added, only to see
this very signal be renamed to e.g. "SPI" immediately afterwards.
As we don't shrink the header width, the header is now too wide.

2 years agoDecodeSignal: Fix flawed PD stack restoration
Soeren Apel [Thu, 6 Jul 2017 20:27:46 +0000 (22:27 +0200)]
DecodeSignal: Fix flawed PD stack restoration

Before, the libsigrokdecode sessions would be started without
having any channels assigned to it, which of course should be
avoided.

2 years agoFix assertions
Soeren Apel [Thu, 6 Jul 2017 19:55:01 +0000 (21:55 +0200)]
Fix assertions

2 years agoFix unit tests
Soeren Apel [Thu, 6 Jul 2017 19:19:04 +0000 (21:19 +0200)]
Fix unit tests

2 years agoApply some clang-tidy fixes.
Uwe Hermann [Thu, 6 Jul 2017 06:56:39 +0000 (08:56 +0200)]
Apply some clang-tidy fixes.

This patch was generated using clang-tidy:

  clang-tidy -checks="-*,..." -fix

The following set of checks was enabled:

  modernize-use-nullptr,modernize-deprecated-headers,modernize-make-shared,
  modernize-redundant-void-arg,modernize-use-bool-literals,
  modernize-use-emplace,modernize-use-equals-default,
  google-readability-namespace-comments,misc-unused-using-decls

Add NOLINT to have clang-tidy (among other tools) ignore some lines
that are not meant to be changed.

2 years agoDecodeSignal: Auto-assign only the channels of newly added decoders
Soeren Apel [Wed, 5 Jul 2017 16:16:18 +0000 (18:16 +0200)]
DecodeSignal: Auto-assign only the channels of newly added decoders

Before, the channels of all decoders in the stack were auto-assigned,
potentially messing up the configuration the user chose.

2 years agoSignalBase: Adjust Schmitt-trigger thresholds
Soeren Apel [Thu, 29 Jun 2017 17:16:18 +0000 (19:16 +0200)]
SignalBase: Adjust Schmitt-trigger thresholds

Currently, the thresholds are determined by the minimum
and maximum values of a signal. From those, we derive the
high and low thresholds by using a 10% margin to min/max.

However, this approach doesn't work very well when the
measurement includes reset conditions or similar, causing
spikes that raise the min/max significantly.

Example:
sigrok-dumps/i2c/eeprom_24xx/microchip_24lc64/sainsmart_dds120_powerup_scl_sda_analog.sr

This patch changes the thresholds margins to 35%. However,
they are expressed differently: (max-min)/2 is used as the
center line, from which 15% of the amplitude (max-min) is
used as the margin. This way seems a little more intuitive
for me since the percentage given (15) is directly proportional
to the hysteresis.

2 years agoDecodeSignal: Improve robustness
Soeren Apel [Sat, 1 Jul 2017 21:37:55 +0000 (23:37 +0200)]
DecodeSignal: Improve robustness

2 years agoMake sigrok::Context semi-global and use libsigrok A2L methods
Soeren Apel [Sat, 1 Jul 2017 22:48:31 +0000 (00:48 +0200)]
Make sigrok::Context semi-global and use libsigrok A2L methods

2 years agoMake get_raw_samples() use provided mem instead of allocating
Soeren Apel [Sat, 1 Jul 2017 20:24:06 +0000 (22:24 +0200)]
Make get_raw_samples() use provided mem instead of allocating

Until now, Segment::get_raw_samples() was allocating the required
amount of memory and returned it to the caller to use. This way,
there was always enough memory allocated for the data that was
written to that memory location.

However, in SignalBase::conversion_thread_proc() we want to use
one memory location multiple times because we will create several
layers of libsigrok wrapper objects around it. This only works
if Segment::get_raw_samples() uses a given memory location instead
of allocating it by itself.

2 years agoDecodeSignal: Remove global SRD mutex
Soeren Apel [Sat, 1 Jul 2017 21:48:13 +0000 (23:48 +0200)]
DecodeSignal: Remove global SRD mutex

libsigrokdecode commit 514b2edc54efda9c6698456748c4256bb901eddd
makes it thread-safe, so PV can now access it whenever it wants,
not needing to care about concurrent access.

2 years agoFix #831 by saving/restoring PD options
Soeren Apel [Mon, 26 Jun 2017 20:49:28 +0000 (22:49 +0200)]
Fix #831 by saving/restoring PD options

2 years agoFix #888 by incrementing i only once per iteration
Soeren Apel [Fri, 23 Jun 2017 20:14:44 +0000 (22:14 +0200)]
Fix #888 by incrementing i only once per iteration

2 years agoFix #831 by saving/restoring the PD channel mapping
Soeren Apel [Tue, 27 Jun 2017 06:34:29 +0000 (08:34 +0200)]
Fix #831 by saving/restoring the PD channel mapping

2 years agoFix #832 by saving/restoring the decoder stack without settings
Soeren Apel [Tue, 27 Jun 2017 06:33:08 +0000 (08:33 +0200)]
Fix #832 by saving/restoring the decoder stack without settings

2 years agoSession: Break up add_decoder()
Soeren Apel [Tue, 20 Jun 2017 20:38:51 +0000 (22:38 +0200)]
Session: Break up add_decoder()

2 years agoRename "always zoom-to-fit" to "zoom-to-fit during acquisition"
Soeren Apel [Mon, 19 Jun 2017 19:31:23 +0000 (21:31 +0200)]
Rename "always zoom-to-fit" to "zoom-to-fit during acquisition"

2 years agoFix #236 by introducing "zoom-to-fit when acquisition stops" option
Soeren Apel [Wed, 5 Jul 2017 20:28:12 +0000 (22:28 +0200)]
Fix #236 by introducing "zoom-to-fit when acquisition stops" option

2 years agoGlobalSettings: Enable "show sampling points" by default
Soeren Apel [Sun, 18 Jun 2017 18:50:56 +0000 (20:50 +0200)]
GlobalSettings: Enable "show sampling points" by default

2 years agoDecode: Improve signaling
Soeren Apel [Tue, 27 Jun 2017 16:32:30 +0000 (18:32 +0200)]
Decode: Improve signaling

Three issues that were fixed by this:
1) The SignalBase did notify PDs when its conversion changed
and new sample data was generated but this was dismissed as
the samples_cleared() signal was never fired nor used by the
PD stack.

2) The decode_finished() signal was added so that the decode
trace can immediately paint the trace once the PD is done.
Before, a repaint was only triggered when annotations came in,
resulting in a noticeable "unresolved period" visible if the
last stretch of signal didn't contain any annotations as the
trace wasn't repainted quickly enough.

3) The decode trace indirectly looks at the signal's
samples_decoded_ member when drawing the "unresolved period"
bar. Hence we should update this member before triggering the
repaint via new_annotations().

2 years agoFix #981 by adding non-device signals upon view creation
Soeren Apel [Wed, 14 Jun 2017 19:53:58 +0000 (21:53 +0200)]
Fix #981 by adding non-device signals upon view creation

2 years agoDecodeSignal: Don't assume channels always have logic data
Soeren Apel [Wed, 14 Jun 2017 21:37:18 +0000 (23:37 +0200)]
DecodeSignal: Don't assume channels always have logic data

It could be that a signal was assigned to a decoder when it
had a conversion enabled, then the conversion was removed.
This means the signal may no longer provide logic data but
as it's still assigned to the decoder, it will try to access
the logic data and... boom.

2 years agoDecodeSignal: Provide conversion data container sooner
Soeren Apel [Tue, 23 May 2017 16:41:20 +0000 (18:41 +0200)]
DecodeSignal: Provide conversion data container sooner

Before, the converted_data_ container was only created
once we had sample data coming in. This meant that it
wasn't possible to assign a converted signal to a decoder.

With this change, the data container is created even
when there is no data to fill it with, allowing logic_data()
to return a valid result and in turn allowing the user
to assign the signal to a decoder.

2 years agoDecodeSignal: Adjust the DecodeChunkLength
Soeren Apel [Sun, 21 May 2017 22:24:10 +0000 (00:24 +0200)]
DecodeSignal: Adjust the DecodeChunkLength

The initial 4096 was too low, though it did make the UI
quite responsive. In 9cc264 it was increased to 10*1024*1024
to speed up decoding but that makes the UI stall very badly
under certain circumstances (e.g. when changing the baud rate
for UART by entering digits).
The reason is that every time a decoder property is changed,
the decode is restarted. Restarting the decode means that
the currently running processes need to shut down, so
they're told to do so and the GUI thread waits for them
to finish.
However, the srd_session_send() call is blocking, meaning
that libsrd will happily block the PV GUI thread until it's
done processing the current chunk of data.

For this reason, DecodeChunkLength can't be too high and
256*1024 looks like a reasonable compromise for now.

2 years agoDecodeTrace/DecodeSignal: Rework trace drawing interval
Soeren Apel [Tue, 4 Jul 2017 19:23:30 +0000 (21:23 +0200)]
DecodeTrace/DecodeSignal: Rework trace drawing interval

Before, we'd redraw the decode trace every n annotations that
came in. However, that causes a lot of unnecessary redraws
when we're zoomed out relatively far and makes the UI less
responsive in return.

Instead, use a one-shot timer with a fixed delay to redraw
the trace after data has been processed. This way, there is
an upper bound to how often we redraw the trace while at the
same time providing a fixed interval at which we update,
regardless of how many annotations came in, making the
trace fill up continuously.

With that in place, we can also remove annotation_count_
and inc_annotation_count().

2 years agoDecodeSignal: Fix restarting the decode after reloading file
Soeren Apel [Sun, 21 May 2017 17:59:59 +0000 (19:59 +0200)]
DecodeSignal: Fix restarting the decode after reloading file

2 years agoDecodeSignal: Improve auto_assign_signals() matching
Soeren Apel [Tue, 13 Jun 2017 21:28:02 +0000 (23:28 +0200)]
DecodeSignal: Improve auto_assign_signals() matching

Before, signals named "SCL analog" and "SDA analog"
wouldn't be assigned to an I2C decoder.

2 years agoDecodeSignal: Rework samplerate handling
Soeren Apel [Wed, 17 May 2017 06:31:07 +0000 (08:31 +0200)]
DecodeSignal: Rework samplerate handling

Before, running an acquisition, then changing the
samplerate and then running the acquisition again
would result in the wrong (i.e. previous) samplerate
to be used for SRD. This patch fixes this.

2 years agoDecodeSignal: Use signals for new data notification, not session
Soeren Apel [Sun, 7 May 2017 15:51:14 +0000 (17:51 +0200)]
DecodeSignal: Use signals for new data notification, not session

2 years agoDecodeSignal: Change srd session handling
Soeren Apel [Thu, 11 May 2017 07:15:55 +0000 (09:15 +0200)]
DecodeSignal: Change srd session handling

Before, we would hold onto the global srd mutex until all data
was processed and then destroy the srd session, making it
necessary to re-create the srd session (and thus run all data
through the PD again) when new data comes in.

This patch changes this so that we keep the srd session around
when we wait for input data, allowing us to re-use the existing
session when new data comes in. Also, this enables us to
release the global srd mutex when waiting, which wasn't
possible before.

2 years agoImplement logic data muxer thread
Soeren Apel [Wed, 14 Jun 2017 22:10:09 +0000 (00:10 +0200)]
Implement logic data muxer thread

Multiple changes in one commit due to complexity:
1) data::decode::Decoder: Make use of the DecodeChannel struct for
channel assigments

2) DecodeSignal: Store DecodeChannel list in vector, not map

3) DecodeSignal: Remove unused get_data()

4) Remove boost::optional usage

5) Use DecodeSignal::segment_ as the container for muxed
logic data

6) Implement the DecodeSignal::logic_mux_proc thread and its
helper method mux_logic_samples()

7) Update DecodeSignal::decode_proc() to interface with the
logic muxer thread

8) Remove no longer needed DecodeSignal::wait_for_data()

2 years agoSignalBase: Make ConversionBlockSize a class constant
Soeren Apel [Fri, 5 May 2017 20:09:42 +0000 (22:09 +0200)]
SignalBase: Make ConversionBlockSize a class constant

2 years agoMerge DecoderStack into DecodeSignal
Soeren Apel [Wed, 14 Jun 2017 06:30:43 +0000 (08:30 +0200)]
Merge DecoderStack into DecodeSignal

Several changes make up this commit, which unfortunately
can't be separated:

1) Move decoder stack management from DecoderStack to
DecodeSignal, thereby making DecoderStack unnecessary

2) Change the decoder stack from std::list to an
std::vector for direct decoder access

3) Introduce logic_mux_thread which will take care
of muxing the individual SignalBases' logic data into
(cached) logic data that libsigrokdecode expects.
This is necessary as we can no longer do simple bit
mapping within a single logic data segment's logic
data as we now may feed from multiple logic data
segments at once

4) Refactored the creation of decode traces, making
it more streamlined and flexible while simplifying
the class interface

5) Refactored the auto-assignment of channels

6) Refactored is_decode_signal()

7) Reworked decode signal save/restore, allowing
proper handling and with the decoder stack now
being part of the signal, easier save/restore of
the stack and its settings

2 years agoRework decode sample count getters
Soeren Apel [Fri, 14 Apr 2017 11:10:14 +0000 (13:10 +0200)]
Rework decode sample count getters