pulseview.git
22 months agomanual: Add a short Mac OS X install text.
Uwe Hermann [Wed, 3 Oct 2018 19:24:24 +0000 (21:24 +0200)]
manual: Add a short Mac OS X install text.

22 months agomanual: Various minor fixes.
Uwe Hermann [Wed, 3 Oct 2018 18:47:22 +0000 (20:47 +0200)]
manual: Various minor fixes.

22 months agoFix unit tests
Soeren Apel [Sat, 29 Sep 2018 15:15:58 +0000 (17:15 +0200)]
Fix unit tests

22 months agoApplication::print_version_info(): Minor output whitespace fixes.
Uwe Hermann [Sat, 29 Sep 2018 11:47:23 +0000 (13:47 +0200)]
Application::print_version_info(): Minor output whitespace fixes.

22 months agoFix #1213 by improving the version information handling
Soeren Apel [Fri, 28 Sep 2018 21:59:18 +0000 (23:59 +0200)]
Fix #1213 by improving the version information handling

22 months agoAdd setting for the snap-to-edge distance
Soeren Apel [Wed, 26 Sep 2018 21:41:53 +0000 (23:41 +0200)]
Add setting for the snap-to-edge distance

22 months agoFix #684 by implementing snap-to-edge for TimeItem-based classes
Soeren Apel [Wed, 26 Sep 2018 20:50:24 +0000 (22:50 +0200)]
Fix #684 by implementing snap-to-edge for TimeItem-based classes

22 months agoImplement LogicSegment::get_surrounding_edges() and use it
Soeren Apel [Mon, 2 Jul 2018 17:57:10 +0000 (19:57 +0200)]
Implement LogicSegment::get_surrounding_edges() and use it

22 months agoManual: Describe sticky scrolling
Soeren Apel [Sat, 22 Sep 2018 20:29:38 +0000 (22:29 +0200)]
Manual: Describe sticky scrolling

22 months agoLogging: avoid "cb was NULL" warning message during logging shutdown
Gerhard Sittig [Tue, 18 Sep 2018 16:34:42 +0000 (18:34 +0200)]
Logging: avoid "cb was NULL" warning message during logging shutdown

Commit 4b9234088f56 introduced the fetch and restore of the libraries'
default log routines in addition to the registration of a Pulseview
application's log routine. Some code paths in main() could result in
unexpected "cb was NULL" messages on stderr, when logging::init() did
not execute but the destructor tried to restore a handler which was not
fetched before. Silence the error message.

22 months agoDecodeTrace: Rename get_sample_range() to get_view_sample_range()
Soeren Apel [Thu, 13 Sep 2018 18:19:14 +0000 (20:19 +0200)]
DecodeTrace: Rename get_sample_range() to get_view_sample_range()

22 months agoInclude suggested changes by clang-tidy
Soeren Apel [Thu, 13 Sep 2018 18:10:01 +0000 (20:10 +0200)]
Include suggested changes by clang-tidy

22 months agoFix #1270 by replacing insignificant characters before comparing
Soeren Apel [Thu, 6 Sep 2018 07:25:13 +0000 (09:25 +0200)]
Fix #1270 by replacing insignificant characters before comparing

22 months agomanual/generate: Always generate a PDF manual as well by default.
Uwe Hermann [Thu, 6 Sep 2018 07:50:57 +0000 (09:50 +0200)]
manual/generate: Always generate a PDF manual as well by default.

22 months agodevice.cpp: Add SR_CONF_AVG_SAMPLES.
Uwe Hermann [Wed, 5 Sep 2018 19:46:11 +0000 (21:46 +0200)]
device.cpp: Add SR_CONF_AVG_SAMPLES.

22 months agodevice.cpp: Add SR_CONF_AVERAGING.
Uwe Hermann [Wed, 5 Sep 2018 18:45:39 +0000 (20:45 +0200)]
device.cpp: Add SR_CONF_AVERAGING.

22 months agoLogging: Write messages from qDebug() and friends also to stdout
Soeren Apel [Wed, 5 Sep 2018 08:22:23 +0000 (10:22 +0200)]
Logging: Write messages from qDebug() and friends also to stdout

22 months agoBinding: Add help icons for entries with descriptions
Soeren Apel [Tue, 4 Sep 2018 20:39:57 +0000 (22:39 +0200)]
Binding: Add help icons for entries with descriptions

22 months agoManual: Initial revision
Soeren Apel [Tue, 4 Sep 2018 07:09:34 +0000 (09:09 +0200)]
Manual: Initial revision

23 months agoSettings: Fix description text
Soeren Apel [Sun, 2 Sep 2018 19:36:23 +0000 (21:36 +0200)]
Settings: Fix description text

When %q is used, we don't just encapsulate annotation texts in
quotation marks, we encapsulate all fields.

23 months agoDecodeSignal: Unpause reliably
Soeren Apel [Sun, 2 Sep 2018 19:34:50 +0000 (21:34 +0200)]
DecodeSignal: Unpause reliably

23 months agomanpage: Drop obsolete -s|--log-to-stdout docs.
Uwe Hermann [Thu, 30 Aug 2018 20:15:19 +0000 (22:15 +0200)]
manpage: Drop obsolete -s|--log-to-stdout docs.

23 months agoAndroid: implement chained log callbacks (buffer and terminal output)
Gerhard Sittig [Mon, 20 Aug 2018 16:57:25 +0000 (18:57 +0200)]
Android: implement chained log callbacks (buffer and terminal output)

Query the libraries' default log handlers before registering the
application's own handler. Queue log messages in the application's
internal buffer _and_ hand them to the default handlers which send
the text to stdout as well.

23 months agoLogging: obsolete -s, log to internal buffer as well as stdout
Gerhard Sittig [Wed, 15 Aug 2018 21:48:52 +0000 (23:48 +0200)]
Logging: obsolete -s, log to internal buffer as well as stdout

Query the sr and srd libraries' current log routines before registering
PV's own log callback which queues messages in an internal buffer. This
allows duplication of messages to the internal buffer _and_ stdout, and
thus obsoletes the -s option.

23 months agopulseview.qrc: Add missing files.
Uwe Hermann [Tue, 28 Aug 2018 06:29:30 +0000 (08:29 +0200)]
pulseview.qrc: Add missing files.

23 months agoImplement decode pausing/resuming
Soeren Apel [Wed, 22 Aug 2018 07:33:48 +0000 (09:33 +0200)]
Implement decode pausing/resuming

23 months agoFix two warnings
Soeren Apel [Tue, 21 Aug 2018 19:04:22 +0000 (21:04 +0200)]
Fix two warnings

23 months agoFix item dragging
Soeren Apel [Mon, 20 Aug 2018 19:19:18 +0000 (21:19 +0200)]
Fix item dragging

23 months agoReplace (double)0 by 0.0
Soeren Apel [Mon, 20 Aug 2018 14:01:48 +0000 (16:01 +0200)]
Replace (double)0 by 0.0

23 months agoAnalogSignal: Set initial value for the "value at cursor" variable
Soeren Apel [Mon, 20 Aug 2018 13:57:33 +0000 (15:57 +0200)]
AnalogSignal: Set initial value for the "value at cursor" variable

Without this, the analog traces show random values after startup
until the mouse cursor enters the application window and the cursor
position updates.

23 months agoFix #1259 by not silently ignoring file read errors
Soeren Apel [Wed, 15 Aug 2018 07:28:35 +0000 (09:28 +0200)]
Fix #1259 by not silently ignoring file read errors

23 months agoEnum: Use slider instead of combo box for contiguous ranges
Soeren Apel [Tue, 14 Aug 2018 08:01:34 +0000 (10:01 +0200)]
Enum: Use slider instead of combo box for contiguous ranges

23 months agoMainBar: Disallow negative sample rates
Soeren Apel [Fri, 10 Aug 2018 21:35:38 +0000 (23:35 +0200)]
MainBar: Disallow negative sample rates

23 months agoMainBar: Disable custom samplerate by default
Soeren Apel [Fri, 10 Aug 2018 21:31:49 +0000 (23:31 +0200)]
MainBar: Disable custom samplerate by default

Without this, the edit may be left in editable mode once the
external clock was enabled and disabled again.

23 months agoMainBar: Fix warning message introduced by bc4b9ccfc78d9d0
Soeren Apel [Fri, 10 Aug 2018 21:28:22 +0000 (23:28 +0200)]
MainBar: Fix warning message introduced by bc4b9ccfc78d9d0

"sr: hwdriver: Option 'external_clock' not available for this device instance."
Avoid this message by checking if the EXTERNAL_CLOCK property is actually
supplied by the driver.

23 months agoDecodeTrace: Implement annotation export for cursor range
Soeren Apel [Fri, 10 Aug 2018 18:08:36 +0000 (20:08 +0200)]
DecodeTrace: Implement annotation export for cursor range

23 months agoFix regression introduced by 2980ff2da269c9ed
Soeren Apel [Fri, 10 Aug 2018 15:51:48 +0000 (17:51 +0200)]
Fix regression introduced by 2980ff2da269c9ed

The regression was that when clicking+dragging on a trace in the
trace view area, the individual trace was moving, not the view area
itself. This was unintended.

23 months agoSegment: Catch by reference
Soeren Apel [Tue, 7 Aug 2018 18:09:22 +0000 (20:09 +0200)]
Segment: Catch by reference

23 months agoImplement annotation export for all rows
Soeren Apel [Mon, 6 Aug 2018 19:25:59 +0000 (21:25 +0200)]
Implement annotation export for all rows

Needed parts are:
1) Annotations must have a reference to the row they belong to
2) DecodeSignal must offer a method to return annotations for all rows
3) Annotations must become comparable to allow for sorting
4) DecodeTrace must handle the different annotation export cases

23 months agoMake annotation export customizable
Soeren Apel [Sun, 5 Aug 2018 20:15:07 +0000 (22:15 +0200)]
Make annotation export customizable

23 months agoImplement annotation export from the DecodeTrace context menu
Soeren Apel [Sun, 5 Aug 2018 16:18:22 +0000 (18:18 +0200)]
Implement annotation export from the DecodeTrace context menu

23 months agoRename create_context_menu() to create_header_context_menu()
Soeren Apel [Thu, 2 Aug 2018 07:08:57 +0000 (09:08 +0200)]
Rename create_context_menu() to create_header_context_menu()

23 months agoAllow for a context menu in the view area
Soeren Apel [Thu, 2 Aug 2018 06:56:51 +0000 (08:56 +0200)]
Allow for a context menu in the view area

23 months agoFix #1204 by making sure the lazy event handler is fired
Soeren Apel [Wed, 25 Jul 2018 11:19:56 +0000 (13:19 +0200)]
Fix #1204 by making sure the lazy event handler is fired

The QTimer reference says about QTimer::start():

> Starts or restarts the timer with the timeout specified in interval.
> If the timer is already running, it will be stopped and restarted.
> If singleShot is true, the timer will be activated only once.

This suggests that the timer is reset when start() is called even
when it is in single shot mode. However, this is actually not the case
and start() doesn't appear to be doing anything if it has already
been started. While this works in most cases, it causes issues when
the timer is supposed to be reset and timeout at the specified time
since view items are still in flux.

Adding a stop() before the start() fixes this.

23 months agoabout: Layout change to use space more efficiently.
Uwe Hermann [Sun, 19 Aug 2018 16:40:43 +0000 (18:40 +0200)]
about: Layout change to use space more efficiently.

23 months agoabout: Merge all version info into one section.
Uwe Hermann [Sun, 19 Aug 2018 15:46:18 +0000 (17:46 +0200)]
about: Merge all version info into one section.

23 months agoabout: move Pulseview version information into the text box
Gerhard Sittig [Sat, 18 Aug 2018 15:47:03 +0000 (17:47 +0200)]
about: move Pulseview version information into the text box

Move the application's version information out of the caption and into
the text box. So that it resides with the libraries' version information,
and is accessible via clipboard for reports.

This addresses part of bug #1213, and fixes all of #1264.

23 months agoCMakeLists.txt: Set DISABLE_WERROR to TRUE by default.
Uwe Hermann [Sun, 19 Aug 2018 15:36:04 +0000 (17:36 +0200)]
CMakeLists.txt: Set DISABLE_WERROR to TRUE by default.

There's various compile problems that can result from building with
-Werror on by default, which are outside of our control (e.g. that need
to be fixed in external libraries), for example #1144 or 1145.

2 years agoHardwareDevice: Only show non-empty device name components.
Uwe Hermann [Tue, 24 Jul 2018 20:07:25 +0000 (22:07 +0200)]
HardwareDevice: Only show non-empty device name components.

Fields such as vendor, version, serial number etc. are not always
provided by drivers. Avoid printing them, since it causes stray
whitespace to be added to the displayed strings.

2 years agoHardwareDevice: Make serial number display a bit clearer.
Uwe Hermann [Tue, 24 Jul 2018 19:35:26 +0000 (21:35 +0200)]
HardwareDevice: Make serial number display a bit clearer.

2 years agoFix the build - catch exceptions by reference
Brian Starkey [Sat, 21 Jul 2018 17:08:45 +0000 (18:08 +0100)]
Fix the build - catch exceptions by reference

Fix the following build errors seen with gcc 8.1.1:

 error: catching polymorphic type ‘class std::out_of_range’ by value
 error: catching polymorphic type ‘class boost::archive::archive_exception’ by value

Signed-off-by: Brian Starkey <stark3y@gmail.com>
2 years agoFix #1146 by replacing the check box by a combo box
Soeren Apel [Fri, 20 Jul 2018 17:47:58 +0000 (19:47 +0200)]
Fix #1146 by replacing the check box by a combo box

2 years agoRemove non-functional remains of the scale drag handle
Soeren Apel [Thu, 19 Jul 2018 17:00:31 +0000 (19:00 +0200)]
Remove non-functional remains of the scale drag handle

2 years agoChannel popup: Don't disable channels when clicking the enable buttons
Soeren Apel [Tue, 17 Jul 2018 20:09:51 +0000 (22:09 +0200)]
Channel popup: Don't disable channels when clicking the enable buttons

2 years agoView: Don't set scroll defaults more than once
Soeren Apel [Tue, 17 Jul 2018 16:45:12 +0000 (18:45 +0200)]
View: Don't set scroll defaults more than once

2 years agoMake sure PD row colors remain constant by adding a row index
Soeren Apel [Mon, 16 Jul 2018 16:27:54 +0000 (18:27 +0200)]
Make sure PD row colors remain constant by adding a row index

Without this change, PD row colors depend on the visible rows,
not a constant ID. This means that rows that collapse change the
colors of all rows coming after them.

2 years agoAccept user-entered sample rates when external clock is enabled
Soeren Apel [Thu, 12 Jul 2018 17:32:33 +0000 (19:32 +0200)]
Accept user-entered sample rates when external clock is enabled

2 years agoProperly handle decoder errors
Soeren Apel [Mon, 9 Jul 2018 19:41:30 +0000 (21:41 +0200)]
Properly handle decoder errors

2 years agoDecodeSignal: Add and use inclusive/exclusive sample count variant
Soeren Apel [Fri, 18 May 2018 20:16:00 +0000 (22:16 +0200)]
DecodeSignal: Add and use inclusive/exclusive sample count variant

This is needed because the annotation cache must be operating on the
number of decoded samples WITHOUT the ones being currently processed,
otherwise it'll refuse to refresh the cache, even if more annotations
arrive - it uses the sample count to determine the cache state.

However, the bar showing the undecoded area must operate on the number
of samples WITH the ones being currently processed so that annotations
aren't overlapping with it.

Adding the parameter to DecodeSignal::get_decoded_sample_count() allows
for both.

This relates to e06cf18db72.

2 years agoConnect dialog: Let the device list occupy only the minimum space needed
Soeren Apel [Tue, 3 Jul 2018 16:24:40 +0000 (18:24 +0200)]
Connect dialog: Let the device list occupy only the minimum space needed

2 years agoLogicSignal: Don't paint hover marker if channel is disabled
Soeren Apel [Thu, 21 Jun 2018 18:23:08 +0000 (20:23 +0200)]
LogicSignal: Don't paint hover marker if channel is disabled

2 years agoFix #975 by overallocating memory to leave spare for PV to use
Soeren Apel [Wed, 30 May 2018 21:56:29 +0000 (23:56 +0200)]
Fix #975 by overallocating memory to leave spare for PV to use

2 years agocmake: help users by pointing out libsigrok build depencendies
Gerhard Sittig [Tue, 3 Jul 2018 14:46:57 +0000 (16:46 +0200)]
cmake: help users by pointing out libsigrok build depencendies

It appears that users have trouble to relate failed PulseView builds to
missing dependencies during libsigrok configuration. Although the error
occurs early and is stated in the build output, it only gets noticed
late and users forgot about the earlier step, or never bothered to check.

Explicitly test for the availability of the C++ bindings, and print a
message that points to libsigrok's(!) configuration phase. Another
check for the full set of libraries will fail in fatal ways as before.

An unfortunate implementation detail of the cmake check leaves all parts
of the lookup result empty when either(!) of the tested libs is missing.
So we cannot tell with certainty which test failed when the test result
is negative while a list of libraries was passed to the test. That's why
the "soft" individual test with QUIET and without REQUIRED is the least
intrusive adjustment to existing CMake rules, where other locations
depend on the PKGDEPS_* variables.

This change addresses bug #1199.

2 years agocmake: nit, use the message(STATUS) keyword
Gerhard Sittig [Sun, 6 May 2018 09:29:57 +0000 (11:29 +0200)]
cmake: nit, use the message(STATUS) keyword

2 years agomain.cpp: straighten the getopt/optind adjustment before openfiles
Gerhard Sittig [Wed, 6 Jun 2018 16:50:26 +0000 (18:50 +0200)]
main.cpp: straighten the getopt/optind adjustment before openfiles

The pulseview(1) application accepts input file specs either as argument
to the -i option, or as positional arguments after the command line options.

Simplify the logic which collects remaining non-option command line words
after getopt(3) is done. As a byproduct the application code no longer
manipulates a variable that is owned by an external library.

2 years agoanalogsignal.cpp: Fix std::isnan() related compile issue on some systems
Gerhard Sittig [Sun, 17 Jun 2018 16:45:47 +0000 (18:45 +0200)]
analogsignal.cpp: Fix std::isnan() related compile issue on some systems

Re-do for recent source what commit f9abacf20c85 did to solve bug #531.
Explicitly use std::isnan() in checks. Avoid the 'using' directive since
not all platforms that are supported by sigrok do support it.

  pv/views/trace/analogsignal.cpp:54:12: error: 'isnan' is already declared in this scope

2 years agoFix comment
Soeren Apel [Thu, 14 Jun 2018 19:42:13 +0000 (21:42 +0200)]
Fix comment

2 years agoFix up change handler registration
Soeren Apel [Thu, 14 Jun 2018 19:05:07 +0000 (21:05 +0200)]
Fix up change handler registration

Before, the mismatched registration/deregistration lead to
crashes. Example:

Load file, load another file into the same session,
change any setting -> crash because first change notifier is
called but invalid

2 years agoPrevent log length to be set to 0
Soeren Apel [Thu, 14 Jun 2018 15:41:02 +0000 (17:41 +0200)]
Prevent log length to be set to 0

Doing so prevents PV from starting up, so disallow it

2 years agoAnalogSignal: Display value under cursor
Soeren Apel [Thu, 14 Jun 2018 15:38:06 +0000 (17:38 +0200)]
AnalogSignal: Display value under cursor

2 years agoFix #979 by querying trigger types only once and storing them
Soeren Apel [Sun, 10 Jun 2018 06:54:46 +0000 (08:54 +0200)]
Fix #979 by querying trigger types only once and storing them

2 years agoFix #1226 by removing a misplaced trigger marker clear
Soeren Apel [Sun, 10 Jun 2018 06:18:05 +0000 (08:18 +0200)]
Fix #1226 by removing a misplaced trigger marker clear

2 years agoDisable unit tests by default
Soeren Apel [Fri, 8 Jun 2018 07:09:09 +0000 (09:09 +0200)]
Disable unit tests by default

The rationale for this change is that except for developers, pretty
much everyone who builds from source does so because they want to
use the latest changes. However, only developers care about the results
of the unit tests, so this doubles the build time for users without
any real benefit.

Even worse, the unit tests are known to fail on several hosts for
reasons that are within the realm of the unit tests themselves, not
because of broken code. This confuses users and even prevents them
from installing PV for no good reason.

Since the unit tests do still run on Jenkins, there's little to no
coverage gap in my opinion.

2 years agoFix #770 by adding a vertical hover line and a setting for it
Soeren Apel [Tue, 5 Jun 2018 21:11:03 +0000 (23:11 +0200)]
Fix #770 by adding a vertical hover line and a setting for it

2 years agoFix #1040 by allowing multiple files to be loaded from command line
Soeren Apel [Tue, 5 Jun 2018 16:49:12 +0000 (18:49 +0200)]
Fix #1040 by allowing multiple files to be loaded from command line

2 years agoFix #1166 by using the correct array size
Soeren Apel [Tue, 5 Jun 2018 14:57:31 +0000 (16:57 +0200)]
Fix #1166 by using the correct array size

2 years agoSession: Handle failing sigrok::Device::read_config() calls
Soeren Apel [Mon, 4 Jun 2018 16:33:43 +0000 (18:33 +0200)]
Session: Handle failing sigrok::Device::read_config() calls

2 years agodevice.cpp: Add SR_CONF_EXTERNAL_CLOCK_SOURCE.
Uwe Hermann [Tue, 5 Jun 2018 22:25:41 +0000 (00:25 +0200)]
device.cpp: Add SR_CONF_EXTERNAL_CLOCK_SOURCE.

2 years agodevice.cpp: Add missing SR_CONF_DATA_SOURCE entry.
Uwe Hermann [Sun, 3 Jun 2018 17:39:12 +0000 (19:39 +0200)]
device.cpp: Add missing SR_CONF_DATA_SOURCE entry.

2 years agoFix #1198 by removing the 1:1 zoom button
Soeren Apel [Sat, 2 Jun 2018 21:30:57 +0000 (23:30 +0200)]
Fix #1198 by removing the 1:1 zoom button

2 years agoFix #807 by disabling trigger widgets when session is not stopped
Soeren Apel [Sat, 2 Jun 2018 20:12:36 +0000 (22:12 +0200)]
Fix #807 by disabling trigger widgets when session is not stopped

2 years agoUpdate cursor action's state whenever the cursor state changes
Soeren Apel [Sat, 2 Jun 2018 19:52:24 +0000 (21:52 +0200)]
Update cursor action's state whenever the cursor state changes

2 years agoFix #1212 by not resetting the cursors pointer
Brian Starkey [Fri, 1 Jun 2018 17:33:08 +0000 (18:33 +0100)]
Fix #1212 by not resetting the cursors pointer

Calling cursors_.reset() effectively drops the CursorPair, meaning they
can never be used. Remove that.

2 years agoFix #540 by introducing a method to reset the view state
Soeren Apel [Wed, 30 May 2018 21:16:57 +0000 (23:16 +0200)]
Fix #540 by introducing a method to reset the view state

2 years agoFix #956 by adding the missing final sample to the range
Soeren Apel [Wed, 30 May 2018 15:55:32 +0000 (17:55 +0200)]
Fix #956 by adding the missing final sample to the range

2 years agoFix #1201 by letting more accurate matches replace previous ones
Soeren Apel [Sun, 27 May 2018 08:00:42 +0000 (10:00 +0200)]
Fix #1201 by letting more accurate matches replace previous ones

2 years agoFix #1182 by only considering enabled channels
Soeren Apel [Sun, 27 May 2018 06:49:17 +0000 (08:49 +0200)]
Fix #1182 by only considering enabled channels

2 years agoFix #1203 by catching the boost exception thrown on error
Soeren Apel [Sat, 26 May 2018 18:49:37 +0000 (20:49 +0200)]
Fix #1203 by catching the boost exception thrown on error

2 years agoAdd imported files to the session save/restore mechanism
Soeren Apel [Fri, 25 May 2018 14:07:24 +0000 (16:07 +0200)]
Add imported files to the session save/restore mechanism

This commit also makes the file loading more robust by improving
the handling of cases where files can't be loaded.

2 years agoStoreProgress: Add missing log output
Soeren Apel [Wed, 23 May 2018 19:44:19 +0000 (21:44 +0200)]
StoreProgress: Add missing log output

2 years agoSession: Allow an SR_DF_META packet to override the samplerate
Soeren Apel [Tue, 22 May 2018 07:24:13 +0000 (09:24 +0200)]
Session: Allow an SR_DF_META packet to override the samplerate

Otherwise, the sample rate determined by the read_config() call
in Session::sample_thread_proc() will be kept even if it's wrong
and the driver wants to submit the correct one.

2 years agotracegroup.cpp: Fix a potential unintended integer division.
Uwe Hermann [Mon, 21 May 2018 14:38:13 +0000 (16:38 +0200)]
tracegroup.cpp: Fix a potential unintended integer division.

Reported by Coverity (CID 279773):

  Result is not floating-point (UNINTENDED_INTEGER_DIVISION)
    integer_division: Dividing integer expressions -5 and 2, and then
    converting the integer quotient to type double. Any remainder, or
    fractional part of the quotient, is ignored.

2 years agologicsegment.cpp: Constify a few variables.
Uwe Hermann [Mon, 21 May 2018 14:36:55 +0000 (16:36 +0200)]
logicsegment.cpp: Constify a few variables.

2 years agoLogicSegment::pow2_ceil(): Fix potentіal integer overflow.
Uwe Hermann [Mon, 21 May 2018 14:30:57 +0000 (16:30 +0200)]
LogicSegment::pow2_ceil(): Fix potentіal integer overflow.

Reported by Coverity (CID 50925):

  Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
    overflow_before_widen: Potentially overflowing expression 1 << power
    with type int (32 bits, signed) is evaluated using 32-bit arithmetic,
    and then used in a context that expects an expression of type
    uint64_t const (64 bits, unsigned).

2 years agocursorpair.cpp: Fix a clazy warning (-Wclazy-qstring-arg).
Uwe Hermann [Sat, 19 May 2018 20:28:16 +0000 (22:28 +0200)]
cursorpair.cpp: Fix a clazy warning (-Wclazy-qstring-arg).

  [...]/pv/views/trace/cursorpair.cpp:174:34: warning: Use multi-arg instead [-Wclazy-qstring-arg]
          return QString("%1 / %2").arg(s1).arg(s2);

2 years agodecodetrace.cpp: Drop unused "using std::all_of".
Uwe Hermann [Sat, 19 May 2018 20:26:51 +0000 (22:26 +0200)]
decodetrace.cpp: Drop unused "using std::all_of".

Reported by clang-tidy.

2 years agologicsegment.cpp: Suggest inlining of pack_sample()/unpack_sample().
Uwe Hermann [Sat, 19 May 2018 18:36:39 +0000 (20:36 +0200)]
logicsegment.cpp: Suggest inlining of pack_sample()/unpack_sample().

These functions were not inlined by default (tested with gcc 7.3.0).
They're in a hot code path, so inlining can help with performance here.

2 years agologicsegment.cpp: Add missing config.h #include.
Uwe Hermann [Sat, 19 May 2018 17:31:59 +0000 (19:31 +0200)]
logicsegment.cpp: Add missing config.h #include.

Without this #include, HAVE_UNALIGNED_LITTLE_ENDIAN_ACCESS was not
available and thus the faster path in LogicSegment::unpack_sample() and
LogicSegment::pack_sample() was never used.

2 years agoDecodeSignal: avoid specifying a zero samplerate to libsigrokdecode
Gerhard Sittig [Sat, 12 May 2018 06:31:52 +0000 (08:31 +0200)]
DecodeSignal: avoid specifying a zero samplerate to libsigrokdecode

When the sample rate is not known, avoid claiming the value would be
zero and calling setup routines in backend libraries. Although the call
is not strictly fatal, this simple check avoids potential log messages
at callee's for this unexpected condition.

2 years agosession: apply input format match to interactively loaded files, too
Gerhard Sittig [Mon, 14 May 2018 18:25:41 +0000 (20:25 +0200)]
session: apply input format match to interactively loaded files, too

Move the format match logic from load_init_file() to load_file(), so
that it transparently takes effect on each "opened" file. Users still
can choose to "import" files and specify options when required. In the
case of lookup miss, sigrok session is assumed as before.

This fixes the remainder of bug #1015.