From: Soeren Apel <redacted>
Date: Fri, 29 May 2020 19:24:34 +0000 (+0200)
Subject: Fix #1549 by notifying user of wrong input parameter names
X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=commitdiff_plain;h=e23d7aa0d9980c3c269cbddb4cfbb32350d7425c

Fix #1549 by notifying user of wrong input parameter names
---

diff --git a/pv/session.cpp b/pv/session.cpp
index 9ec8bd07..ea3fe07b 100644
--- a/pv/session.cpp
+++ b/pv/session.cpp
@@ -621,8 +621,12 @@ Session::input_format_options(vector<string> user_spec,
 		 * data type.
 		 */
 		auto found = fmt_opts.find(key);
-		if (found == fmt_opts.end())
+		if (found == fmt_opts.end()) {
+			qCritical() << "Supplied input option" << QString::fromStdString(key) <<
+				"is not a valid option for this input module, it will be ignored!";
 			continue;
+		}
+
 		shared_ptr<Option> opt = found->second;
 		result[key] = opt->parse_string(val);
 	}
@@ -647,7 +651,7 @@ void Session::load_init_file(const string &file_name,
 				return f.first == user_name; });
 		if (iter == formats.end()) {
 			MainWindow::show_session_error(tr("Error"),
-				tr("Unexpected input format: %s").arg(QString::fromStdString(format)));
+				tr("Unexpected input format: %1").arg(QString::fromStdString(format)));
 			return;
 		}
 		input_format = (*iter).second;