From: Soeren Apel Date: Fri, 8 Jun 2018 07:09:09 +0000 (+0200) Subject: Disable unit tests by default X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=commitdiff_plain;h=b2d9be03f533ec9800b9b35447ab4502807eada5 Disable unit tests by default The rationale for this change is that except for developers, pretty much everyone who builds from source does so because they want to use the latest changes. However, only developers care about the results of the unit tests, so this doubles the build time for users without any real benefit. Even worse, the unit tests are known to fail on several hosts for reasons that are within the realm of the unit tests themselves, not because of broken code. This confuses users and even prevents them from installing PV for no good reason. Since the unit tests do still run on Jenkins, there's little to no coverage gap in my opinion. --- diff --git a/CMakeLists.txt b/CMakeLists.txt index 252f9024..e7d0bf5f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -44,7 +44,7 @@ option(DISABLE_WERROR "Build without -Werror" FALSE) option(ENABLE_SIGNALS "Build with UNIX signals" TRUE) option(ENABLE_STACKTRACE "Enable stack trace when crashing" FALSE) option(ENABLE_DECODE "Build with libsigrokdecode" TRUE) -option(ENABLE_TESTS "Enable unit tests" TRUE) +option(ENABLE_TESTS "Enable unit tests" FALSE) option(STATIC_PKGDEPS_LIBS "Statically link to (pkg-config) libraries" FALSE) if(WIN32)