summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
inline | side by side (from parent 1:
f74015d)
This patch was generated using clang-tidy:
clang-tidy -checks="-*,modernize-loop-convert" -fix
- for (auto i = options_.begin(); i != options_.end(); i++)
- g_variant_unref((*i).second);
+ for (auto & option : options_)
+ g_variant_unref(option.second);
}
const srd_decoder* Decoder::decoder() const
}
const srd_decoder* Decoder::decoder() const
set< shared_ptr<pv::data::Logic> > Decoder::get_data()
{
set< shared_ptr<pv::data::Logic> > data;
set< shared_ptr<pv::data::Logic> > Decoder::get_data()
{
set< shared_ptr<pv::data::Logic> > data;
- for (auto i = channels_.cbegin(); i != channels_.cend(); i++) {
- shared_ptr<view::LogicSignal> signal((*i).second);
+ for (const auto & channel : channels_) {
+ shared_ptr<view::LogicSignal> signal(channel.second);
assert(signal);
data.insert(signal->logic_data());
}
assert(signal);
data.insert(signal->logic_data());
}
GHashTable *const opt_hash = g_hash_table_new_full(g_str_hash,
g_str_equal, g_free, (GDestroyNotify)g_variant_unref);
GHashTable *const opt_hash = g_hash_table_new_full(g_str_hash,
g_str_equal, g_free, (GDestroyNotify)g_variant_unref);
- for (auto i = options_.cbegin(); i != options_.cend(); i++)
- {
- GVariant *const value = (*i).second;
+ for (const auto & option : options_) {
+ GVariant *const value = option.second;
g_variant_ref(value);
g_hash_table_replace(opt_hash, (void*)g_strdup(
g_variant_ref(value);
g_hash_table_replace(opt_hash, (void*)g_strdup(
- (*i).first.c_str()), value);
+ option.first.c_str()), value);
}
srd_decoder_inst *const decoder_inst = srd_inst_new(
}
srd_decoder_inst *const decoder_inst = srd_inst_new(
GHashTable *const channels = g_hash_table_new_full(g_str_hash,
g_str_equal, g_free, (GDestroyNotify)g_variant_unref);
GHashTable *const channels = g_hash_table_new_full(g_str_hash,
g_str_equal, g_free, (GDestroyNotify)g_variant_unref);
- for (auto i = channels_.cbegin(); i != channels_.cend(); i++)
- {
- shared_ptr<view::LogicSignal> signal((*i).second);
+ for (const auto & channel : channels_) {
+ shared_ptr<view::LogicSignal> signal(channel.second);
GVariant *const gvar = g_variant_new_int32(
signal->channel()->index());
g_variant_ref_sink(gvar);
GVariant *const gvar = g_variant_new_int32(
signal->channel()->index());
g_variant_ref_sink(gvar);
- g_hash_table_insert(channels, (*i).first->id, gvar);
+ g_hash_table_insert(channels, channel.first->id, gvar);
}
srd_inst_channel_set_all(decoder_inst, channels);
}
srd_inst_channel_set_all(decoder_inst, channels);
vector<pv::data::decode::Annotation> &dest,
uint64_t start_sample, uint64_t end_sample) const
{
vector<pv::data::decode::Annotation> &dest,
uint64_t start_sample, uint64_t end_sample) const
{
- for (auto i = annotations_.cbegin(); i != annotations_.cend(); i++)
- if ((*i).end_sample() > start_sample &&
- (*i).start_sample() <= end_sample)
- dest.push_back(*i);
+ for (const auto & annotation : annotations_)
+ if (annotation.end_sample() > start_sample &&
+ annotation.start_sample() <= end_sample)
+ dest.push_back(annotation);
}
void RowData::push_annotation(const Annotation &a)
}
void RowData::push_annotation(const Annotation &a)
{
uint64_t max_sample_count = 0;
{
uint64_t max_sample_count = 0;
- for (auto i = rows_.cbegin(); i != rows_.end(); i++)
+ for (const auto & row : rows_)
max_sample_count = max(max_sample_count,
max_sample_count = max(max_sample_count,
- (*i).second.get_max_sample());
+ row.second.get_max_sample());
return max_sample_count;
}
return max_sample_count;
}
const vector<Row> rows(decoder_stack_->get_visible_rows());
visible_rows_.clear();
const vector<Row> rows(decoder_stack_->get_visible_rows());
visible_rows_.clear();
- for (size_t i = 0; i < rows.size(); i++) {
- const Row &row = rows[i];
+ for (auto i : rows) {
+ const Row &row = i;
// Cache the row title widths
int row_title_width;
// Cache the row title widths
int row_title_width;
- visible_rows_.push_back(rows[i]);
+ visible_rows_.push_back(i);