X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fwidgets%2Fpopup.cpp;h=141985eb556a2e1c87ca2e558f90acd9203d7330;hp=099c5499acafbb30ba119f8729879947ee45630b;hb=0715fb8c638b53ac25590841fcbf3a1da3546b68;hpb=b6a2899ab732a873543efda2dff77a9d940fb614

diff --git a/pv/widgets/popup.cpp b/pv/widgets/popup.cpp
index 099c5499..141985eb 100644
--- a/pv/widgets/popup.cpp
+++ b/pv/widgets/popup.cpp
@@ -23,10 +23,14 @@
 #include <assert.h>
 
 #include <QtGui>
+#include <QApplication>
+#include <QDesktopWidget>
+#include <QLineEdit>
 
 #include "popup.h"
 
-using namespace std;
+using std::max;
+using std::min;
 
 namespace pv {
 namespace widgets {
@@ -64,6 +68,73 @@ void Popup::set_position(const QPoint point, Position pos)
 
 }
 
+bool Popup::eventFilter(QObject *obj, QEvent *evt)
+{
+	QKeyEvent *keyEvent;
+
+	(void)obj;
+
+	if (evt->type() == QEvent::KeyPress) {
+		keyEvent = static_cast<QKeyEvent*>(evt);
+		if (keyEvent->key() == Qt::Key_Enter ||
+		    keyEvent->key() == Qt::Key_Return) {
+			this->close();
+			return true;
+		}
+	}
+
+	return false;
+}
+
+void Popup::show()
+{
+	QLineEdit* le;
+
+	QWidget::show();
+
+	// We want to close the popup when the Enter key was
+	// pressed and the first editable widget had focus.
+	if ((le = this->findChild<QLineEdit*>())) {
+
+		// For combo boxes we need to hook into the parent of
+		// the line edit (i.e. the QComboBox). For edit boxes
+		// we hook into the widget directly.
+		if (le->parent()->metaObject()->className() ==
+				this->metaObject()->className())
+			le->installEventFilter(this);
+		else
+			le->parent()->installEventFilter(this);
+	}
+}
+
+bool Popup::space_for_arrow() const
+{
+	// Check if there is room for the arrow
+	switch (_pos) {
+	case Right:
+		if (_point.x() > x())
+			return false;
+		return true;
+
+	case Bottom:
+		if (_point.y() > y())
+			return false;
+		return true;		
+
+	case Left:
+		if (_point.x() < (x() + width()))
+			return false;
+		return true;
+
+	case Top:
+		if (_point.y() < (y() + height()))
+			return false;
+		return true;
+	}
+
+	return true;
+}
+
 QPolygon Popup::arrow_polygon() const
 {
 	QPolygon poly;
@@ -144,13 +215,19 @@ QRegion Popup::bubble_region() const
 
 QRegion Popup::popup_region() const
 {
-	return arrow_region().united(bubble_region());
+	if (space_for_arrow())
+		return arrow_region().united(bubble_region());
+	else
+		return bubble_region();
 }
 
 void Popup::reposition_widget()
 {
 	QPoint o;
 
+	const QRect screen_rect = QApplication::desktop()->availableGeometry(
+		QApplication::desktop()->screenNumber(_point));
+
 	if (_pos == Right || _pos == Left)
 		o.ry() = -height() / 2;
 	else
@@ -161,7 +238,16 @@ void Popup::reposition_widget()
 	else if(_pos == Top)
 		o.ry() = -height();
 
-	move(_point + o);
+	o += _point;
+	move(max(min(o.x(), screen_rect.right() - width()),
+			screen_rect.left()),
+		max(min(o.y(), screen_rect.bottom() - height()),
+			screen_rect.top()));
+}
+
+void Popup::closeEvent(QCloseEvent*)
+{
+	closed();
 }
 
 void Popup::paintEvent(QPaintEvent*)
@@ -172,6 +258,7 @@ void Popup::paintEvent(QPaintEvent*)
 	const QColor outline_color(QApplication::palette().color(
 		QPalette::Dark));
 
+	// Draw the bubble
 	const QRegion b = bubble_region();
 	const QRegion bubble_outline = QRegion(rect()).subtracted(
 		b.translated(1, 0).intersected(b.translated(0, 1).intersected(
@@ -181,6 +268,10 @@ void Popup::paintEvent(QPaintEvent*)
 	painter.setBrush(QApplication::palette().brush(QPalette::Window));
 	painter.drawRect(rect());
 
+	// Draw the arrow
+	if (!space_for_arrow())
+		return;
+
 	const QPoint ArrowOffsets[] = {
 		QPoint(1, 0), QPoint(0, -1), QPoint(-1, 0), QPoint(0, 1)};