X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fviews%2Ftrace%2Flogicsignal.cpp;h=e536171667307c8e43a2a81876de90c3ca9f815c;hp=9913d6873ddfd28639c36d1348203c1a921f9ddd;hb=4e86ec7042631d4b54876cba89c01a73abaf7213;hpb=1573bf16ba50d1c023ad3a9ce596f0ab6eaeacff

diff --git a/pv/views/trace/logicsignal.cpp b/pv/views/trace/logicsignal.cpp
index 9913d687..e5361716 100644
--- a/pv/views/trace/logicsignal.cpp
+++ b/pv/views/trace/logicsignal.cpp
@@ -46,6 +46,7 @@ using std::max;
 using std::make_pair;
 using std::min;
 using std::none_of;
+using std::out_of_range;
 using std::pair;
 using std::shared_ptr;
 using std::vector;
@@ -101,7 +102,6 @@ LogicSignal::LogicSignal(
 	shared_ptr<devices::Device> device,
 	shared_ptr<data::SignalBase> base) :
 	Signal(session, base),
-	signal_height_(QFontMetrics(QApplication::font()).height() * 2),
 	device_(device),
 	trigger_none_(nullptr),
 	trigger_rising_(nullptr),
@@ -114,6 +114,9 @@ LogicSignal::LogicSignal(
 
 	base_->set_colour(SignalColours[base->index() % countof(SignalColours)]);
 
+	GlobalSettings gs;
+	signal_height_ = gs.value(GlobalSettings::Key_View_DefaultLogicHeight).toInt();
+
 	/* Populate this channel's trigger setting with whatever we
 	 * find in the current session trigger, if anything. */
 	trigger_match_ = nullptr;
@@ -134,6 +137,25 @@ shared_ptr<pv::data::Logic> LogicSignal::logic_data() const
 	return base_->logic_data();
 }
 
+void LogicSignal::save_settings(QSettings &settings) const
+{
+	settings.setValue("trace_height", signal_height_);
+}
+
+void LogicSignal::restore_settings(QSettings &settings)
+{
+	if (settings.contains("trace_height")) {
+		const int old_height = signal_height_;
+		signal_height_ = settings.value("trace_height").toInt();
+
+		if ((signal_height_ != old_height) && owner_) {
+			// Call order is important, otherwise the lazy event handler won't work
+			owner_->extents_changed(false, true);
+			owner_->row_item_appearance_changed(false, true);
+		}
+	}
+}
+
 pair<int, int> LogicSignal::v_extents() const
 {
 	const int signal_margin =
@@ -175,7 +197,13 @@ void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp)
 	if (segments.empty())
 		return;
 
-	const shared_ptr<pv::data::LogicSegment> &segment = segments.front();
+	shared_ptr<pv::data::LogicSegment> segment;
+	try {
+		segment = segments.at(current_segment_);
+	} catch (out_of_range) {
+		qDebug() << "Current logic segment out of range for signal" << base_->name();
+		return;
+	}
 
 	double samplerate = segment->samplerate();
 
@@ -439,6 +467,16 @@ void LogicSignal::populate_popup_form(QWidget *parent, QFormLayout *form)
 {
 	Signal::populate_popup_form(parent, form);
 
+	signal_height_sb_ = new QSpinBox(parent);
+	signal_height_sb_->setRange(5, 1000);
+	signal_height_sb_->setSingleStep(5);
+	signal_height_sb_->setSuffix(tr(" pixels"));
+	signal_height_sb_->setValue(signal_height_);
+	connect(signal_height_sb_, SIGNAL(valueChanged(int)),
+		this, SLOT(on_signal_height_changed(int)));
+	form->addRow(tr("Trace height"), signal_height_sb_);
+
+	// Trigger settings
 	const vector<int32_t> trig_types = get_trigger_types();
 
 	if (!trig_types.empty()) {
@@ -531,6 +569,17 @@ void LogicSignal::on_trigger()
 	modify_trigger();
 }
 
+void LogicSignal::on_signal_height_changed(int height)
+{
+	signal_height_ = height;
+
+	if (owner_) {
+		// Call order is important, otherwise the lazy event handler won't work
+		owner_->extents_changed(false, true);
+		owner_->row_item_appearance_changed(false, true);
+	}
+}
+
 } // namespace trace
 } // namespace views
 } // namespace pv