X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fviews%2Ftrace%2Fdecodetrace.cpp;h=509e77f6224b5dacbd9514d47f48b245f47a6c08;hp=e6b977ae01952ea1d22f377e8898b060c6fc3c1c;hb=eee3eab96253315b2a3dc04ffa7051a8ec963c32;hpb=53b652bdde928b42a116e60f5c07800d0bd0b873

diff --git a/pv/views/trace/decodetrace.cpp b/pv/views/trace/decodetrace.cpp
index e6b977ae..509e77f6 100644
--- a/pv/views/trace/decodetrace.cpp
+++ b/pv/views/trace/decodetrace.cpp
@@ -146,6 +146,8 @@ DecodeTrace::DecodeTrace(pv::Session &session,
 
 	connect(decode_signal_.get(), SIGNAL(new_annotations()),
 		this, SLOT(on_new_annotations()));
+	connect(decode_signal_.get(), SIGNAL(decode_reset()),
+		this, SLOT(on_decode_reset()));
 	connect(decode_signal_.get(), SIGNAL(decode_finished()),
 		this, SLOT(on_decode_finished()));
 	connect(decode_signal_.get(), SIGNAL(channels_updated()),
@@ -248,11 +250,13 @@ void DecodeTrace::paint_mid(QPainter &p, ViewItemPaintParams &pp)
 	// Draw the hatching
 	draw_unresolved_period(p, annotation_height, pp.left(), pp.right());
 
-	if ((int)visible_rows_.size() > max_visible_rows_)
-		owner_->extents_changed(false, true);
+	if ((int)visible_rows_.size() > max_visible_rows_) {
+		max_visible_rows_ = (int)visible_rows_.size();
 
-	// Update the maximum row count if needed
-	max_visible_rows_ = max(max_visible_rows_, (int)visible_rows_.size());
+		// Call order is important, otherwise the lazy event handler won't work
+		owner_->extents_changed(false, true);
+		owner_->row_item_appearance_changed(false, true);
+	}
 }
 
 void DecodeTrace::paint_fore(QPainter &p, ViewItemPaintParams &pp)
@@ -708,15 +712,13 @@ const QString DecodeTrace::get_annotation_at_point(const QPoint &point)
 		QString() : annotations[0].annotations().front();
 }
 
-void DecodeTrace::hover_point_changed()
+void DecodeTrace::hover_point_changed(const QPoint &hp)
 {
 	assert(owner_);
 
 	const View *const view = owner_->view();
 	assert(view);
 
-	QPoint hp = view->hover_point();
-
 	if (hp.x() == 0) {
 		QToolTip::hideText();
 		return;
@@ -744,13 +746,14 @@ void DecodeTrace::hover_point_changed()
 	// If it did, the tool tip would constantly hide and re-appear.
 	// We also push it up by one row so that it appears above the
 	// decode trace, not below.
-	hp.setX(hp.x() - (text_size.width() / 2) - padding);
+	QPoint p = hp;
+	p.setX(hp.x() - (text_size.width() / 2) - padding);
 
-	hp.setY(get_visual_y() - (row_height_ / 2) +
+	p.setY(get_visual_y() - (row_height_ / 2) +
 		(hover_row * row_height_) -
 		row_height_ - text_size.height() - padding);
 
-	QToolTip::showText(view->viewport()->mapToGlobal(hp), ann);
+	QToolTip::showText(view->viewport()->mapToGlobal(p), ann);
 }
 
 void DecodeTrace::create_decoder_form(int index,
@@ -888,6 +891,15 @@ void DecodeTrace::on_delayed_trace_update()
 		owner_->row_item_appearance_changed(false, true);
 }
 
+void DecodeTrace::on_decode_reset()
+{
+	visible_rows_.clear();
+	max_visible_rows_ = 0;
+
+	if (owner_)
+		owner_->row_item_appearance_changed(false, true);
+}
+
 void DecodeTrace::on_decode_finished()
 {
 	if (owner_)
@@ -948,6 +960,10 @@ void DecodeTrace::on_delete_decoder(int index)
 {
 	decode_signal_->remove_decoder(index);
 
+	// Force re-calculation of the trace height, see paint_mid()
+	max_visible_rows_ = 0;
+	owner_->extents_changed(false, true);
+
 	// Update the popup
 	create_popup_form();
 }
@@ -959,6 +975,12 @@ void DecodeTrace::on_show_hide_decoder(int index)
 	assert(index < (int)decoder_forms_.size());
 	decoder_forms_[index]->set_decoder_visible(state);
 
+	if (!state) {
+		// Force re-calculation of the trace height, see paint_mid()
+		max_visible_rows_ = 0;
+		owner_->extents_changed(false, true);
+	}
+
 	if (owner_)
 		owner_->row_item_appearance_changed(false, true);
 }