X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Fviewwidget.cpp;h=79326d2a10a06742a3a2639a6cbd88376d06a704;hp=a834f9c0d54eba1c236f18558cfe471bbb3f700a;hb=d9ea96280ab1128427143660ae375c30b19aa0cb;hpb=725568aca067f8024c6567a10973cd119483a5bd diff --git a/pv/view/viewwidget.cpp b/pv/view/viewwidget.cpp index a834f9c0..79326d2a 100644 --- a/pv/view/viewwidget.cpp +++ b/pv/view/viewwidget.cpp @@ -73,8 +73,7 @@ bool ViewWidget::accept_drag() const const bool any_time_items_selected = any_of(items.begin(), items.end(), [](const shared_ptr &i) { return i->selected(); }); - if (any_row_items_selected && !any_time_items_selected) - { + if (any_row_items_selected && !any_time_items_selected) { // Check all the drag items share a common owner TraceTreeItemOwner *item_owner = nullptr; for (shared_ptr r : trace_tree_items) @@ -86,9 +85,7 @@ bool ViewWidget::accept_drag() const } return true; - } - else if (any_time_items_selected && !any_row_items_selected) - { + } else if (any_time_items_selected && !any_row_items_selected) { return true; } @@ -212,8 +209,7 @@ void ViewWidget::mouse_left_release_event(QMouseEvent *event) if (item_dragging_) view_.restack_all_trace_tree_items(); - else - { + else { if (!ctrl_pressed) { for (shared_ptr i : items) if (mouse_down_item_ != i) @@ -227,9 +223,10 @@ void ViewWidget::mouse_left_release_event(QMouseEvent *event) item_dragging_ = false; } -bool ViewWidget::touch_event(QTouchEvent *e) +bool ViewWidget::touch_event(QTouchEvent *event) { - (void)e; + (void)event; + return false; } @@ -271,18 +268,16 @@ void ViewWidget::mouseReleaseEvent(QMouseEvent *event) mouse_down_item_ = nullptr; } -void ViewWidget::mouseMoveEvent(QMouseEvent *e) +void ViewWidget::mouseMoveEvent(QMouseEvent *event) { - assert(e); - mouse_point_ = e->pos(); - - if (!e->buttons()) - item_hover(get_mouse_over_item(e->pos())); - else if (e->buttons() & Qt::LeftButton) - { - if (!item_dragging_) - { - if ((e->pos() - mouse_down_point_).manhattanLength() < + assert(event); + mouse_point_ = event->pos(); + + if (!event->buttons()) + item_hover(get_mouse_over_item(event->pos())); + else if (event->buttons() & Qt::LeftButton) { + if (!item_dragging_) { + if ((event->pos() - mouse_down_point_).manhattanLength() < QApplication::startDragDistance()) return; @@ -293,7 +288,7 @@ void ViewWidget::mouseMoveEvent(QMouseEvent *e) } // Do the drag - drag_items(e->pos() - mouse_down_point_); + drag_items(event->pos() - mouse_down_point_); } }