X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Fviewwidget.cpp;h=38732046f11f896756a79536e0a94db79234e8ae;hp=9913b5cc1640550a5cf563849a1c0a361a3f5cb2;hb=75663e3ab6656ed9fc39050d8ac6752450b6a4ad;hpb=af503b104d890a357c736c678bb00296d889c090

diff --git a/pv/view/viewwidget.cpp b/pv/view/viewwidget.cpp
index 9913b5cc..38732046 100644
--- a/pv/view/viewwidget.cpp
+++ b/pv/view/viewwidget.cpp
@@ -48,7 +48,6 @@ void ViewWidget::clear_selection()
 	const auto items = this->items();
 	for (auto &i : items)
 		i->select(false);
-	update();
 }
 
 void ViewWidget::item_hover(const shared_ptr<ViewItem> &item)
@@ -64,8 +63,11 @@ void ViewWidget::item_clicked(const shared_ptr<ViewItem> &item)
 bool ViewWidget::accept_drag() const
 {
 	const vector< shared_ptr<TimeItem> > items(view_.time_items());
+	const vector< shared_ptr<TraceTreeItem> > trace_tree_items(
+		view_.list_by_type<TraceTreeItem>());
 
-	const bool any_row_items_selected = any_of(view_.begin(), view_.end(),
+	const bool any_row_items_selected = any_of(
+		trace_tree_items.begin(), trace_tree_items.end(),
 		[](const shared_ptr<TraceTreeItem> &r) { return r->selected(); });
 
 	const bool any_time_items_selected = any_of(items.begin(), items.end(),
@@ -75,7 +77,7 @@ bool ViewWidget::accept_drag() const
 	{
 		// Check all the drag items share a common owner
 		TraceTreeItemOwner *item_owner = nullptr;
-		for (shared_ptr<TraceTreeItem> r : view_)
+		for (shared_ptr<TraceTreeItem> r : trace_tree_items)
 			if (r->dragging()) {
 				if (!item_owner)
 					item_owner = r->owner();
@@ -106,7 +108,9 @@ void ViewWidget::drag_items(const QPoint &delta)
 
 	// Drag the row items
 	TraceTreeItemOwner *item_owner = nullptr;
-	for (std::shared_ptr<TraceTreeItem> r : view_)
+	const vector< shared_ptr<TraceTreeItem> > trace_tree_items(
+		view_.list_by_type<TraceTreeItem>());
+	for (shared_ptr<TraceTreeItem> r : trace_tree_items)
 		if (r->dragging()) {
 			item_owner = r->owner();
 			r->drag_by(delta);
@@ -118,7 +122,7 @@ void ViewWidget::drag_items(const QPoint &delta)
 	if (item_owner) {
 		item_dragged = true;
 		item_owner->restack_items();
-		for (const auto &r : *item_owner)
+		for (shared_ptr<TraceTreeItem> r : trace_tree_items)
 			r->animate_to_layout_v_offset();
 	}
 
@@ -182,7 +186,6 @@ void ViewWidget::mouse_left_press_event(QMouseEvent *event)
 		drag();
 
 	selection_changed();
-	update();
 }
 
 void ViewWidget::mouse_left_release_event(QMouseEvent *event)