X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Fview.cpp;h=9c4920f997f66585d8f75e2e62da15f2f587d531;hp=4e0fed063fca8c4d42e67c5bcb6cb58c23cee390;hb=51e77110d4316fd0106f8306f5e1f0523c5bf7d7;hpb=ccdd3ef548ce34f25c6c168598556a350831aa37

diff --git a/pv/view/view.cpp b/pv/view/view.cpp
index 4e0fed06..9c4920f9 100644
--- a/pv/view/view.cpp
+++ b/pv/view/view.cpp
@@ -1,5 +1,5 @@
 /*
- * This file is part of the sigrok project.
+ * This file is part of the PulseView project.
  *
  * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
  *
@@ -19,6 +19,7 @@
  */
 
 #include <assert.h>
+#include <limits.h>
 #include <math.h>
 
 #include <boost/foreach.hpp>
@@ -31,9 +32,9 @@
 #include "view.h"
 #include "viewport.h"
 
-#include "../../logicdata.h"
-#include "../../logicdatasnapshot.h"
-#include "../../sigsession.h"
+#include "../logicdata.h"
+#include "../logicdatasnapshot.h"
+#include "../sigsession.h"
 
 using namespace boost;
 using namespace std;
@@ -47,6 +48,8 @@ const double View::MinScale = 1e-15;
 const int View::LabelMarginWidth = 70;
 const int View::RulerHeight = 30;
 
+const int View::MaxScrollValue = INT_MAX / 2;
+
 const int View::SignalHeight = 50;
 
 View::View(SigSession &session, QWidget *parent) :
@@ -96,6 +99,19 @@ void View::zoom(double steps)
 	zoom(steps, (width() - LabelMarginWidth) / 2);
 }
 
+void View::zoom(double steps, int offset)
+{
+	const double cursor_offset = _offset + _scale * offset;
+	_scale *= pow(3.0/2.0, -steps);
+	_scale = max(min(_scale, MaxScale), MinScale);
+	_offset = cursor_offset - _scale * offset;
+
+	_ruler->update();
+	_viewport->update();
+	update_scroll();
+}
+
+
 void View::set_scale_offset(double scale, double offset)
 {
 	_scale = scale;
@@ -106,6 +122,16 @@ void View::set_scale_offset(double scale, double offset)
 	_viewport->update();
 }
 
+void View::get_scroll_layout(double &length, double &offset) const
+{
+	const shared_ptr<SignalData> sig_data = _session.get_data();
+	if(!sig_data)
+		return;
+
+	length = _data_length / (sig_data->get_samplerate() * _scale);
+	offset = _offset / _scale;
+}
+
 void View::update_scroll()
 {
 	assert(_viewport);
@@ -114,17 +140,19 @@ void View::update_scroll()
 
 	// Set the horizontal scroll bar
 	double length = 0, offset = 0;
-	const shared_ptr<SignalData> sig_data = _session.get_data();
-	if(sig_data) {
-		length = _data_length /
-			(sig_data->get_samplerate() * _scale);
-		offset = _offset / _scale;
-	}
+	get_scroll_layout(length, offset);
+	length = max(length - areaSize.width(), 0.0);
 
 	horizontalScrollBar()->setPageStep(areaSize.width());
-	horizontalScrollBar()->setRange(0,
-		max((int)(length - areaSize.width()), 0));
-	horizontalScrollBar()->setSliderPosition(offset);
+
+	if(length < MaxScrollValue) {
+		horizontalScrollBar()->setRange(0, length);
+		horizontalScrollBar()->setSliderPosition(offset);
+	} else {
+		horizontalScrollBar()->setRange(0, MaxScrollValue);
+		horizontalScrollBar()->setSliderPosition(
+			_offset * MaxScrollValue / (_scale * length));
+	}
 
 	// Set the vertical scrollbar
 	verticalScrollBar()->setPageStep(areaSize.height());
@@ -132,18 +160,6 @@ void View::update_scroll()
 		_viewport->get_total_height() - areaSize.height());
 }
 
-void View::zoom(double steps, int offset)
-{
-	const double cursor_offset = _offset + _scale * offset;
-	_scale *= pow(3.0/2.0, -steps);
-	_scale = max(min(_scale, MaxScale), MinScale);
-	_offset = cursor_offset - _scale * offset;
-
-	_ruler->update();
-	_viewport->update();
-	update_scroll();
-}
-
 bool View::viewportEvent(QEvent *e)
 {
 	switch(e->type()) {
@@ -171,7 +187,15 @@ void View::resizeEvent(QResizeEvent *e)
 
 void View::h_scroll_value_changed(int value)
 {
-	_offset = _scale * value;
+	const int range = horizontalScrollBar()->maximum();
+	if(range < MaxScrollValue)
+		_offset = _scale * value;
+	else {
+		double length = 0, offset;
+		get_scroll_layout(length, offset);
+		_offset = _scale * length * value / MaxScrollValue;
+	}
+
 	_ruler->update();
 	_viewport->update();
 }