X-Git-Url: https://sigrok.org/gitweb/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fview%2Fview.cpp;h=3df87e540b986b0e08b1242c9139950f65f12a5b;hp=dcf60327680cae507f2fea2c08097cbfb98b62a5;hb=b3f44329f5846bfb800ee53c15c65b2395d3ba0c;hpb=f25770e201ed07f056d04188b6cd09c81fd55fa4

diff --git a/pv/view/view.cpp b/pv/view/view.cpp
index dcf60327..3df87e54 100644
--- a/pv/view/view.cpp
+++ b/pv/view/view.cpp
@@ -1,5 +1,5 @@
 /*
- * This file is part of the sigrok project.
+ * This file is part of the PulseView project.
  *
  * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
  *
@@ -18,26 +18,63 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <assert.h>
-#include <limits.h>
-#include <math.h>
+#ifdef ENABLE_DECODE
+#include <libsigrokdecode/libsigrokdecode.h>
+#endif
 
-#include <boost/foreach.hpp>
+#include <extdef.h>
 
+#include <cassert>
+#include <climits>
+#include <cmath>
+#include <mutex>
+#include <unordered_set>
+
+#include <QApplication>
 #include <QEvent>
+#include <QFontMetrics>
+#include <QMouseEvent>
 #include <QScrollBar>
 
-#include "header.h"
-#include "ruler.h"
-#include "view.h"
-#include "viewport.h"
-
-#include "../../logicdata.h"
-#include "../../logicdatasnapshot.h"
-#include "../../sigsession.h"
-
-using namespace boost;
-using namespace std;
+#include <libsigrok/libsigrok.hpp>
+
+#include "cursorheader.hpp"
+#include "decodetrace.hpp"
+#include "header.hpp"
+#include "logicsignal.hpp"
+#include "ruler.hpp"
+#include "signal.hpp"
+#include "tracegroup.hpp"
+#include "view.hpp"
+#include "viewport.hpp"
+
+#include "pv/session.hpp"
+#include "pv/data/logic.hpp"
+#include "pv/data/logicsegment.hpp"
+#include "pv/util.hpp"
+
+using boost::shared_lock;
+using boost::shared_mutex;
+
+using pv::data::SignalData;
+using pv::data::Segment;
+using pv::util::format_time;
+
+using std::back_inserter;
+using std::deque;
+using std::dynamic_pointer_cast;
+using std::list;
+using std::lock_guard;
+using std::max;
+using std::make_pair;
+using std::min;
+using std::pair;
+using std::set;
+using std::shared_ptr;
+using std::unordered_map;
+using std::unordered_set;
+using std::vector;
+using std::weak_ptr;
 
 namespace pv {
 namespace view {
@@ -45,119 +82,504 @@ namespace view {
 const double View::MaxScale = 1e9;
 const double View::MinScale = 1e-15;
 
-const int View::LabelMarginWidth = 70;
-const int View::RulerHeight = 30;
-
 const int View::MaxScrollValue = INT_MAX / 2;
 
-const int View::SignalHeight = 50;
+const int View::ScaleUnits[3] = {1, 2, 5};
+
+const QColor View::CursorAreaColour(220, 231, 243);
+
+const QSizeF View::LabelPadding(4, 0);
 
-View::View(SigSession &session, QWidget *parent) :
+View::View(Session &session, QWidget *parent) :
 	QAbstractScrollArea(parent),
-	_session(session),
-	_viewport(new Viewport(*this)),
-	_ruler(new Ruler(*this)),
-	_header(new Header(*this)),
-	_data_length(0),
-	_scale(1e-6),
-	_offset(0),
-	_v_offset(0)
+	session_(session),
+	viewport_(new Viewport(*this)),
+	ruler_(new Ruler(*this)),
+	cursorheader_(new CursorHeader(*this)),
+	header_(new Header(*this)),
+	scale_(1e-6),
+	offset_(0),
+	v_offset_(0),
+	updating_scroll_(false),
+	tick_period_(0.0),
+	tick_prefix_(0),
+	show_cursors_(false),
+	cursors_(new CursorPair(*this)),
+	hover_point_(-1, -1)
 {
 	connect(horizontalScrollBar(), SIGNAL(valueChanged(int)),
 		this, SLOT(h_scroll_value_changed(int)));
 	connect(verticalScrollBar(), SIGNAL(valueChanged(int)),
 		this, SLOT(v_scroll_value_changed(int)));
-	connect(&_session, SIGNAL(data_updated()),
+
+	connect(&session_, SIGNAL(signals_changed()),
+		this, SLOT(signals_changed()));
+	connect(&session_, SIGNAL(capture_state_changed(int)),
+		this, SLOT(data_updated()));
+	connect(&session_, SIGNAL(data_received()),
+		this, SLOT(data_updated()));
+	connect(&session_, SIGNAL(frame_ended()),
 		this, SLOT(data_updated()));
 
-	setViewportMargins(LabelMarginWidth, RulerHeight, 0, 0);
-	setViewport(_viewport);
+	connect(cursors_->first().get(), SIGNAL(time_changed()),
+		this, SLOT(marker_time_changed()));
+	connect(cursors_->second().get(), SIGNAL(time_changed()),
+		this, SLOT(marker_time_changed()));
+
+	connect(header_, SIGNAL(signals_moved()),
+		this, SLOT(on_signals_moved()));
+
+	connect(header_, SIGNAL(selection_changed()),
+		cursorheader_, SLOT(clear_selection()));
+	connect(cursorheader_, SIGNAL(selection_changed()),
+		header_, SLOT(clear_selection()));
+
+	connect(header_, SIGNAL(selection_changed()),
+		this, SIGNAL(selection_changed()));
+	connect(cursorheader_, SIGNAL(selection_changed()),
+		this, SIGNAL(selection_changed()));
+
+	connect(this, SIGNAL(hover_point_changed()),
+		this, SLOT(on_hover_point_changed()));
+
+	connect(&lazy_event_handler_, SIGNAL(timeout()),
+		this, SLOT(process_sticky_events()));
+	lazy_event_handler_.setSingleShot(true);
+
+	setViewport(viewport_);
+
+	viewport_->installEventFilter(this);
+	ruler_->installEventFilter(this);
+	cursorheader_->installEventFilter(this);
+	header_->installEventFilter(this);
+
+	// Trigger the initial event manually. The default device has signals
+	// which were created before this object came into being
+	signals_changed();
+
+	// make sure the transparent widgets are on the top
+	cursorheader_->raise();
+	header_->raise();
+
+	// Update the zoom state
+	calculate_tick_spacing();
+}
+
+Session& View::session()
+{
+	return session_;
 }
 
-SigSession& View::session()
+const Session& View::session() const
 {
-	return _session;
+	return session_;
+}
+
+View* View::view()
+{
+	return this;
+}
+
+const View* View::view() const
+{
+	return this;
+}
+
+Viewport* View::viewport()
+{
+	return viewport_;
+}
+
+const Viewport* View::viewport() const
+{
+	return viewport_;
+}
+
+vector< shared_ptr<TimeItem> > View::time_items() const
+{
+	vector< shared_ptr<TimeItem> > items;
+	items.push_back(cursors_->first());
+	items.push_back(cursors_->second());
+	return items;
 }
 
 double View::scale() const
 {
-	return _scale;
+	return scale_;
 }
 
 double View::offset() const
 {
-	return _offset;
+	return offset_;
+}
+
+int View::owner_visual_v_offset() const
+{
+	return -v_offset_;
 }
 
-int View::v_offset() const
+unsigned int View::depth() const
 {
-	return _v_offset;
+	return 0;
+}
+
+unsigned int View::tick_prefix() const
+{
+	return tick_prefix_;
+}
+
+double View::tick_period() const
+{
+	return tick_period_;
 }
 
 void View::zoom(double steps)
 {
-	zoom(steps, (width() - LabelMarginWidth) / 2);
+	zoom(steps, viewport_->width() / 2);
 }
 
 void View::zoom(double steps, int offset)
 {
-	const double cursor_offset = _offset + _scale * offset;
-	_scale *= pow(3.0/2.0, -steps);
-	_scale = max(min(_scale, MaxScale), MinScale);
-	_offset = cursor_offset - _scale * offset;
+	set_zoom(scale_ * pow(3.0/2.0, -steps), offset);
+}
 
-	_ruler->update();
-	_viewport->update();
-	update_scroll();
+void View::zoom_fit()
+{
+	const pair<double, double> extents = get_time_extents();
+	const double delta = extents.second - extents.first;
+	if (delta < 1e-12)
+		return;
+
+	assert(viewport_);
+	const int w = viewport_->width();
+	if (w <= 0)
+		return;
+
+	const double scale = max(min(delta / w, MaxScale), MinScale);
+	set_scale_offset(scale, extents.first);
 }
 
+void View::zoom_one_to_one()
+{
+	using pv::data::SignalData;
+
+	// Make a set of all the visible data objects
+	set< shared_ptr<SignalData> > visible_data = get_visible_data();
+	if (visible_data.empty())
+		return;
+
+	double samplerate = 0.0;
+	for (const shared_ptr<SignalData> d : visible_data) {
+		assert(d);
+		const vector< shared_ptr<Segment> > segments =
+			d->segments();
+		for (const shared_ptr<Segment> &s : segments)
+			samplerate = max(samplerate, s->samplerate());
+	}
+
+	if (samplerate == 0.0)
+		return;
+
+	assert(viewport_);
+	const int w = viewport_->width();
+	if (w <= 0)
+		return;
+
+	set_zoom(1.0 / samplerate, w / 2);
+}
 
 void View::set_scale_offset(double scale, double offset)
 {
-	_scale = scale;
-	_offset = offset;
+	scale_ = scale;
+	offset_ = offset;
+
+	calculate_tick_spacing();
 
 	update_scroll();
-	_ruler->update();
-	_viewport->update();
+	ruler_->update();
+	cursorheader_->update();
+	viewport_->update();
+	scale_offset_changed();
+}
+
+set< shared_ptr<SignalData> > View::get_visible_data() const
+{
+	shared_lock<shared_mutex> lock(session().signals_mutex());
+	const vector< shared_ptr<Signal> > &sigs(session().signals());
+
+	// Make a set of all the visible data objects
+	set< shared_ptr<SignalData> > visible_data;
+	for (const shared_ptr<Signal> sig : sigs)
+		if (sig->enabled())
+			visible_data.insert(sig->data());
+
+	return visible_data;
+}
+
+pair<double, double> View::get_time_extents() const
+{
+	double left_time = DBL_MAX, right_time = DBL_MIN;
+	const set< shared_ptr<SignalData> > visible_data = get_visible_data();
+	for (const shared_ptr<SignalData> d : visible_data)
+	{
+		const vector< shared_ptr<Segment> > segments =
+			d->segments();
+		for (const shared_ptr<Segment> &s : segments) {
+			double samplerate = s->samplerate();
+			samplerate = (samplerate <= 0.0) ? 1.0 : samplerate;
+
+			const double start_time = s->start_time();
+			left_time = min(left_time, start_time);
+			right_time = max(right_time, start_time +
+				d->get_max_sample_count() / samplerate);
+		}
+	}
+
+	if (left_time == DBL_MAX && right_time == DBL_MIN)
+		return make_pair(0.0, 0.0);
+
+	assert(left_time < right_time);
+	return make_pair(left_time, right_time);
+}
+
+bool View::cursors_shown() const
+{
+	return show_cursors_;
+}
+
+void View::show_cursors(bool show)
+{
+	show_cursors_ = show;
+	cursorheader_->update();
+	viewport_->update();
+}
+
+void View::centre_cursors()
+{
+	const double time_width = scale_ * viewport_->width();
+	cursors_->first()->set_time(offset_ + time_width * 0.4);
+	cursors_->second()->set_time(offset_ + time_width * 0.6);
+	cursorheader_->update();
+	viewport_->update();
+}
+
+std::shared_ptr<CursorPair> View::cursors() const
+{
+	return cursors_;
+}
+
+const QPoint& View::hover_point() const
+{
+	return hover_point_;
+}
+
+void View::update_viewport()
+{
+	assert(viewport_);
+	viewport_->update();
+	header_->update();
+}
+
+void View::restack_all_row_items()
+{
+	// Make a set of owners
+	unordered_set< RowItemOwner* > owners;
+	for (const auto &r : *this)
+		owners.insert(r->owner());
+
+	// Make a list that is sorted from deepest first
+	vector< RowItemOwner* > sorted_owners(owners.begin(), owners.end());
+	sort(sorted_owners.begin(), sorted_owners.end(),
+		[](const RowItemOwner* a, const RowItemOwner *b) {
+			return a->depth() > b->depth(); });
+
+	// Restack the items recursively
+	for (auto &o : sorted_owners)
+		o->restack_items();
+
+	// Animate the items to their destination
+	for (const auto &r : *this)
+		r->animate_to_layout_v_offset();
 }
 
 void View::get_scroll_layout(double &length, double &offset) const
 {
-	const shared_ptr<SignalData> sig_data = _session.get_data();
-	if(!sig_data)
-		return;
+	const pair<double, double> extents = get_time_extents();
+	length = (extents.second - extents.first) / scale_;
+	offset = offset_ / scale_;
+}
 
-	length = _data_length / (sig_data->get_samplerate() * _scale);
-	offset = _offset / _scale;
+void View::set_zoom(double scale, int offset)
+{
+	const double cursor_offset = offset_ + scale_ * offset;
+	const double new_scale = max(min(scale, MaxScale), MinScale);
+	const double new_offset = cursor_offset - new_scale * offset;
+	set_scale_offset(new_scale, new_offset);
+}
+
+void View::calculate_tick_spacing()
+{
+	const double SpacingIncrement = 32.0f;
+	const double MinValueSpacing = 32.0f;
+
+	double min_width = SpacingIncrement, typical_width;
+
+	QFontMetrics m(QApplication::font());
+
+	do {
+		const double min_period = scale_ * min_width;
+
+		const int order = (int)floorf(log10f(min_period));
+		const double order_decimal = pow(10.0, order);
+
+		unsigned int unit = 0;
+
+		do {
+			tick_period_ = order_decimal * ScaleUnits[unit++];
+		} while (tick_period_ < min_period &&
+			unit < countof(ScaleUnits));
+
+		tick_prefix_ = (order - pv::util::FirstSIPrefixPower) / 3;
+
+		typical_width = m.boundingRect(0, 0, INT_MAX, INT_MAX,
+			Qt::AlignLeft | Qt::AlignTop,
+			format_time(offset_, tick_prefix_)).width() +
+				MinValueSpacing;
+
+		min_width += SpacingIncrement;
+
+	} while(typical_width > tick_period_ / scale_);
 }
 
 void View::update_scroll()
 {
-	assert(_viewport);
+	assert(viewport_);
 
-	const QSize areaSize = _viewport->size();
+	const QSize areaSize = viewport_->size();
 
 	// Set the horizontal scroll bar
 	double length = 0, offset = 0;
 	get_scroll_layout(length, offset);
 	length = max(length - areaSize.width(), 0.0);
 
-	horizontalScrollBar()->setPageStep(areaSize.width());
+	int major_tick_distance = tick_period_ / scale_;
+
+	horizontalScrollBar()->setPageStep(areaSize.width() / 2);
+	horizontalScrollBar()->setSingleStep(major_tick_distance);
 
-	if(length < MaxScrollValue) {
+	updating_scroll_ = true;
+
+	if (length < MaxScrollValue) {
 		horizontalScrollBar()->setRange(0, length);
 		horizontalScrollBar()->setSliderPosition(offset);
 	} else {
 		horizontalScrollBar()->setRange(0, MaxScrollValue);
 		horizontalScrollBar()->setSliderPosition(
-			_offset * MaxScrollValue / (_scale * length));
+			offset_ * MaxScrollValue / (scale_ * length));
 	}
 
+	updating_scroll_ = false;
+
 	// Set the vertical scrollbar
 	verticalScrollBar()->setPageStep(areaSize.height());
-	verticalScrollBar()->setRange(0,
-		_viewport->get_total_height() - areaSize.height());
+
+	const pair<int, int> extents = v_extents();
+	const int extra_scroll_height = (extents.second - extents.first) / 4;
+	verticalScrollBar()->setRange(extents.first - extra_scroll_height,
+		extents.first + extra_scroll_height);
+}
+
+void View::update_layout()
+{
+	setViewportMargins(
+		header_->sizeHint().width() - pv::view::Header::BaselineOffset,
+		ruler_->sizeHint().height(), 0, 0);
+	ruler_->setGeometry(viewport_->x(), 0,
+		viewport_->width(), viewport_->y());
+	cursorheader_->setGeometry(
+		viewport_->x(),
+		ruler_->sizeHint().height() - cursorheader_->sizeHint().height() / 2,
+		viewport_->width(), cursorheader_->sizeHint().height());
+	header_->setGeometry(0, viewport_->y(),
+		header_->sizeHint().width(), viewport_->height());
+	update_scroll();
+}
+
+void View::paint_label(QPainter &p, const QRect &rect, bool hover)
+{
+	(void)p;
+	(void)rect;
+	(void)hover;
+}
+
+QRectF View::label_rect(const QRectF &rect)
+{
+	(void)rect;
+	return QRectF();
+}
+
+bool View::add_channels_to_owner(
+	const vector< shared_ptr<sigrok::Channel> > &channels,
+	RowItemOwner *owner, int &offset,
+	unordered_map<shared_ptr<sigrok::Channel>, shared_ptr<Signal> >
+		&signal_map,
+	std::function<bool (shared_ptr<RowItem>)> filter_func)
+{
+	bool any_added = false;
+
+	assert(owner);
+
+	for (const auto &channel : channels)
+	{
+		const auto iter = signal_map.find(channel);
+		if (iter == signal_map.end() ||
+			(filter_func && !filter_func((*iter).second)))
+			continue;
+
+		shared_ptr<RowItem> row_item = (*iter).second;
+		owner->add_child_item(row_item);
+		apply_offset(row_item, offset);
+		signal_map.erase(iter);
+
+		any_added = true;
+	}
+
+	return any_added;
+}
+
+void View::apply_offset(shared_ptr<RowItem> row_item, int &offset) {
+	assert(row_item);
+	const pair<int, int> extents = row_item->v_extents();
+	if (row_item->enabled())
+		offset += -extents.first;
+	row_item->force_to_v_offset(offset);
+	if (row_item->enabled())
+		offset += extents.second;
+}
+
+bool View::eventFilter(QObject *object, QEvent *event)
+{
+	const QEvent::Type type = event->type();
+	if (type == QEvent::MouseMove) {
+
+		const QMouseEvent *const mouse_event = (QMouseEvent*)event;
+		if (object == viewport_)
+			hover_point_ = mouse_event->pos();
+		else if (object == ruler_ || object == cursorheader_)
+			hover_point_ = QPoint(mouse_event->x(), 0);
+		else if (object == header_)
+			hover_point_ = QPoint(0, mouse_event->y());
+		else
+			hover_point_ = QPoint(-1, -1);
+
+		hover_point_changed();
+
+	} else if (type == QEvent::Leave) {
+		hover_point_ = QPoint(-1, -1);
+		hover_point_changed();
+	}
+
+	return QObject::eventFilter(object, event);
 }
 
 bool View::viewportEvent(QEvent *e)
@@ -169,6 +591,9 @@ bool View::viewportEvent(QEvent *e)
 	case QEvent::MouseButtonDblClick:
 	case QEvent::MouseMove:
 	case QEvent::Wheel:
+	case QEvent::TouchBegin:
+	case QEvent::TouchUpdate:
+	case QEvent::TouchEnd:
 		return false;
 
 	default:
@@ -176,56 +601,159 @@ bool View::viewportEvent(QEvent *e)
 	}
 }
 
-void View::resizeEvent(QResizeEvent *e)
+void View::resizeEvent(QResizeEvent*)
 {
-	_ruler->setGeometry(_viewport->x(), 0,
-		_viewport->width(), _viewport->y());
-	_header->setGeometry(0, _viewport->y(),
-		_viewport->x(), _viewport->height());
-	update_scroll();
+	update_layout();
+}
+
+void View::appearance_changed(bool label, bool content)
+{
+	if (label)
+		header_->update();
+	if (content)
+		viewport_->update();
+}
+
+void View::extents_changed(bool horz, bool vert)
+{
+	sticky_events_ |=
+		(horz ? SelectableItemHExtentsChanged : 0) |
+		(vert ? SelectableItemVExtentsChanged : 0);
+	lazy_event_handler_.start();
 }
 
 void View::h_scroll_value_changed(int value)
 {
+	if (updating_scroll_)
+		return;
+
 	const int range = horizontalScrollBar()->maximum();
-	if(range < MaxScrollValue)
-		_offset = _scale * value;
+	if (range < MaxScrollValue)
+		offset_ = scale_ * value;
 	else {
 		double length = 0, offset;
 		get_scroll_layout(length, offset);
-		_offset = _scale * length * value / MaxScrollValue;
+		offset_ = scale_ * length * value / MaxScrollValue;
 	}
 
-	_ruler->update();
-	_viewport->update();
+	ruler_->update();
+	cursorheader_->update();
+	viewport_->update();
 }
 
 void View::v_scroll_value_changed(int value)
 {
-	_v_offset = value;
-	_header->update();
-	_viewport->update();
+	v_offset_ = value;
+	header_->update();
+	viewport_->update();
 }
 
-void View::data_updated()
+void View::signals_changed()
 {
-	// Get the new data length
-	_data_length = 0;
-	shared_ptr<LogicData> sig_data = _session.get_data();
-	if(sig_data) {
-		deque< shared_ptr<LogicDataSnapshot> > &snapshots =
-			sig_data->get_snapshots();
-		BOOST_FOREACH(shared_ptr<LogicDataSnapshot> s, snapshots)
-			if(s)
-				_data_length = max(_data_length,
-					s->get_sample_count());
+	int offset = 0;
+
+	// Populate the traces
+	clear_child_items();
+
+	shared_ptr<sigrok::Device> device = session_.device();
+	assert(device);
+
+	// Collect a set of signals
+	unordered_map<shared_ptr<sigrok::Channel>, shared_ptr<Signal> >
+		signal_map;
+
+	shared_lock<shared_mutex> lock(session_.signals_mutex());
+	const vector< shared_ptr<Signal> > &sigs(session_.signals());
+
+	for (const shared_ptr<Signal> &sig : sigs)
+		signal_map[sig->channel()] = sig;
+
+	// Populate channel groups
+	for (auto entry : device->channel_groups())
+	{
+		const shared_ptr<sigrok::ChannelGroup> &group = entry.second;
+
+		if (group->channels().size() <= 1)
+			continue;
+
+		shared_ptr<TraceGroup> trace_group(new TraceGroup());
+		int child_offset = 0;
+		if (add_channels_to_owner(group->channels(),
+			trace_group.get(), child_offset, signal_map))
+		{
+			add_child_item(trace_group);
+			apply_offset(trace_group, offset);
+		}
+	}
+
+	// Add the remaining logic channels
+	shared_ptr<TraceGroup> logic_trace_group(new TraceGroup());
+	int child_offset = 0;
+
+	if (add_channels_to_owner(device->channels(),
+		logic_trace_group.get(), child_offset, signal_map,
+		[](shared_ptr<RowItem> r) -> bool {
+			return dynamic_pointer_cast<LogicSignal>(r) != nullptr;
+			}))
+
+	{
+		add_child_item(logic_trace_group);
+		apply_offset(logic_trace_group, offset);
 	}
 
+	// Add the remaining channels
+	add_channels_to_owner(device->channels(), this, offset, signal_map);
+	assert(signal_map.empty());
+
+	// Add decode signals
+#ifdef ENABLE_DECODE
+	const vector< shared_ptr<DecodeTrace> > decode_sigs(
+		session().get_decode_signals());
+	for (auto s : decode_sigs) {
+		add_child_item(s);
+		apply_offset(s, offset);
+	}
+#endif
+
+	update_layout();
+}
+
+void View::data_updated()
+{
 	// Update the scroll bars
 	update_scroll();
 
 	// Repaint the view
-	_viewport->update();
+	viewport_->update();
+}
+
+void View::marker_time_changed()
+{
+	cursorheader_->update();
+	viewport_->update();
+}
+
+void View::on_signals_moved()
+{
+	update_scroll();
+	signals_moved();
+}
+
+void View::process_sticky_events()
+{
+	if (sticky_events_ & SelectableItemHExtentsChanged)
+		update_layout();
+	if (sticky_events_ & SelectableItemVExtentsChanged)
+		restack_all_row_items();
+
+	// Clear the sticky events
+	sticky_events_ = 0;
+}
+
+void View::on_hover_point_changed()
+{
+	for (shared_ptr<RowItem> r : *this)
+		r->hover_point_changed();
 }
 
 } // namespace view